92704[BUGFIX] Keep current page in record module in returnUrl if search is used
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Sebastian Klein +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Sebastian Klein +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1823
-
Georg Ringer uploaded patch set 1 02/06/26, 09:59
-
Georg Ringer commented on patch set 1 02/06/26, 09:59
This change is ready for review. -
core-ci voted on patch set 1 V +1 02/06/26, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95258
-
Garvin Hicking commented on patch set 1 02/06/26, 16:46
DatabaseRecordList.php:2931```suggestion } elseif ($this->searchString !== '' && $this->page !== '' && $this->page !== 0) { ``` -
Georg Ringer commented on patch set 2
V +102/06/26, 17:20Published edit on patch set 1. -
core-ci voted on patch set 2 V -1 02/06/26, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95333
-
Garvin Hicking commented on patch set 2 02/06/26, 17:34
The joys of phpdoc inferred types without strict typing. Dunno if this one is safe enougn.DatabaseRecordList.php:2931ReplyDoneDatabaseRecordList.php:2931```suggestion } elseif ($this->searchString !== '' && $this->page !== 0) { ``` -
Georg Ringer uploaded patch set 3
V -102/06/26, 20:01 -
Georg Ringer commented on patch set 3 02/06/26, 20:01
DatabaseRecordList.php:2931ReplyFix applied. -
core-ci voted on patch set 3 V +1 02/06/26, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95341
-
Garvin Hicking commented on patch set 3 CR +1 V +1 02/06/26, 20:16
DatabaseRecordList.php:2931ReplyDone -
Josua Vogel voted on patch set 3 CR +1 V +1 02/06/26, 20:31
-
Sebastian Klein commented on patch set 3 V -1 02/13/26, 06:51
Tested patch version 3 in current main, with matching content in different parts of the page tree. Steps to reproduce: Using module "Content > Records", I selected the root page of a site (as well as a subpage) as a starting point, enabled "4 levels down" for the search form and searched for content. Results are properly listed. After I open and close a record, the page tree still highlights the formerly selected page, but the breadcrumb shows PID 0. As a result, the Records module returns "There are no records on this page.". The search form still shows the search term and the select option "4 levels down" is active. When clicking the "search" button, search results will be shown again, but starting from PID 0. -
Benni Mack updated the commit message in patch set 4
CR +1V +104/22/26, 06:56 -
core-ci voted on patch set 4 V -1 04/22/26, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100839
-
Georg Ringer uploaded patch set 5
V -109/11/26, 21:08 -
core-ci voted on patch set 5 V +1 09/11/26, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108317
-
Georg Ringer commented on patch set 5 11/03/26, 20:14
Reply
Done -
Benni Mack voted on patch set 5 CR +1 V +1 11/09/26, 15:00
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 11/09/26, 15:07
-
Sebastian Klein voted on patch set 5 CR +1 V +1 11/09/26, 17:46
-
Benni Mack voted on patch set 5 CR +2 V +2 11/09/26, 18:02
-
Benni Mack merged patch set 6 11/09/26, 18:02