Review main Merged

92704[BUGFIX] Keep current page in record module in returnUrl if search is used

Georg Ringer CR +2 V +2 Normal +52 −1 updated 11/09/26, 18:02

Commit message

If searching in the record module, the return url must use the current page id
and not the one of the record. After the change, when editing a search result and
closing it again, the user comes back to the original page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sebastian Klein +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sebastian Klein +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1823

  1. Georg Ringer uploaded patch set 1 02/06/26, 09:59

  2. Georg Ringer commented on patch set 1 02/06/26, 09:59

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/06/26, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95258

  4. Garvin Hicking commented on patch set 1 02/06/26, 16:46

    DatabaseRecordList.php:2931

    ```suggestion } elseif ($this->searchString !== '' && $this->page !== '' && $this->page !== 0) { ```
  5. Georg Ringer commented on patch set 2 V +1 02/06/26, 17:20

    Published edit on patch set 1.
  6. core-ci voted on patch set 2 V -1 02/06/26, 17:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95333

  7. Garvin Hicking commented on patch set 2 02/06/26, 17:34

    The joys of phpdoc inferred types without strict typing. Dunno if this one is safe enougn.

    DatabaseRecordList.php:2931 Reply

    Done

    DatabaseRecordList.php:2931

    ```suggestion } elseif ($this->searchString !== '' && $this->page !== 0) { ```
  8. Georg Ringer uploaded patch set 3 V -1 02/06/26, 20:01

  9. Georg Ringer commented on patch set 3 02/06/26, 20:01

    DatabaseRecordList.php:2931 Reply

    Fix applied.
  10. core-ci voted on patch set 3 V +1 02/06/26, 20:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95341

  11. Garvin Hicking commented on patch set 3 CR +1 V +1 02/06/26, 20:16

    DatabaseRecordList.php:2931 Reply

    Done
  12. Josua Vogel voted on patch set 3 CR +1 V +1 02/06/26, 20:31

  13. Sebastian Klein commented on patch set 3 V -1 02/13/26, 06:51

    Tested patch version 3 in current main, with matching content in different parts of the page tree. Steps to reproduce: Using module "Content > Records", I selected the root page of a site (as well as a subpage) as a starting point, enabled "4 levels down" for the search form and searched for content. Results are properly listed. After I open and close a record, the page tree still highlights the formerly selected page, but the breadcrumb shows PID 0. As a result, the Records module returns "There are no records on this page.". The search form still shows the search term and the select option "4 levels down" is active. When clicking the "search" button, search results will be shown again, but starting from PID 0.
  14. Benni Mack updated the commit message in patch set 4 CR +1 V +1 04/22/26, 06:56

  15. core-ci voted on patch set 4 V -1 04/22/26, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100839

  16. Georg Ringer uploaded patch set 5 V -1 09/11/26, 21:08

  17. core-ci voted on patch set 5 V +1 09/11/26, 21:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108317

  18. Georg Ringer commented on patch set 5 11/03/26, 20:14

    Reply

    Done
  19. Benni Mack voted on patch set 5 CR +1 V +1 11/09/26, 15:00

  20. Simon Schaufelberger voted on patch set 5 CR +1 V +1 11/09/26, 15:07

  21. Sebastian Klein voted on patch set 5 CR +1 V +1 11/09/26, 17:46

  22. Benni Mack voted on patch set 5 CR +2 V +2 11/09/26, 18:02

  23. Benni Mack merged patch set 6 11/09/26, 18:02