Review main Merged

92707[TASK] Centralize open document tracking in EXT:opendocs

Benjamin Kott CR +2 V +2 Nightmare +1908 −1737 updated 02/25/26, 11:47

Commit message

All open document logic is moved from EXT:backend and EXT:dashboard
into EXT:opendocs, making it the single owner of this feature.

EXT:backend now dispatches an AfterRecordOpenedEvent (PSR-14) from
EditDocumentController when a record is opened. EXT:opendocs handles
this via TrackOpenDocumentsEventListener, replacing the inline tracking
logic in the controller. The OpenDocument model and repository are
moved from EXT:backend into EXT:opendocs accordingly.

The ability to manually close individual documents from the list is
removed. Editors rarely understood what closing a document meant in
this context, and it is a fundamentally different concern from knowing
that a user has actively been editing a record — which is a separate
feature. Open documents is a personal convenience list of recently
visited records for the current user only, not shared with others.

The recently opened documents dashboard widget is moved from
EXT:dashboard into EXT:opendocs, eliminating the implicit dependency
on EXT:opendocs being installed. Only records that already exist are
tracked; in-between states such as new unsaved records are no longer
counted.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 44

Show 24 more files

Review log 3562

Show 2037 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/06/26, 11:25

  2. core-ci voted on patch set 1 V -1 02/06/26, 12:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95270

  3. Benjamin Kott uploaded patch set 2 V -1 02/10/26, 11:52

  4. Benjamin Kott rebased onto patch set 3 02/10/26, 11:59

  5. core-ci voted on patch set 2 V -1 02/10/26, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95536

  6. core-ci voted on patch set 3 V -1 02/10/26, 12:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95537

  7. Benjamin Kott uploaded patch set 4 V -1 02/11/26, 13:48

  8. core-ci voted on patch set 4 V -1 02/11/26, 14:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95621

  9. Benjamin Kott uploaded patch set 5 V -1 02/12/26, 08:04

  10. core-ci voted on patch set 5 V -1 02/12/26, 08:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95689

  11. Benjamin Kott uploaded patch set 6 V -1 02/12/26, 17:06

  12. core-ci voted on patch set 6 V -1 02/12/26, 17:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95758

  13. Benjamin Kott uploaded patch set 7 V -1 02/16/26, 17:16

  14. core-ci voted on patch set 7 V -1 02/16/26, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95984

  15. Benjamin Kott uploaded patch set 8 V -1 02/18/26, 09:31

  16. core-ci voted on patch set 8 V -1 02/18/26, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96109

  17. Benjamin Kott uploaded patch set 9 V -1 02/18/26, 10:30

  18. core-ci voted on patch set 9 V -1 02/18/26, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96117

  19. Benjamin Kott uploaded patch set 10 V -1 02/19/26, 14:53

  20. core-ci voted on patch set 10 V -1 02/19/26, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96258

  21. Benjamin Kott uploaded patch set 11 V -1 02/19/26, 16:04

  22. core-ci voted on patch set 11 V -1 02/19/26, 16:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96265

  23. Benjamin Kott uploaded patch set 12 V -1 02/19/26, 16:19

  24. Benjamin Kott uploaded patch set 13 02/19/26, 16:31

  25. Benjamin Kott uploaded patch set 14 02/19/26, 16:43

  26. core-ci voted on patch set 13 V -1 02/19/26, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96269

  27. core-ci voted on patch set 12 V -1 02/19/26, 16:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96266

  28. core-ci voted on patch set 14 V -1 02/19/26, 16:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96270

  29. Benjamin Kott commented on patch set 14 02/19/26, 17:04

    open-document-menu-element.ts:87

    should read <file> <timestamp> <path>
  30. Benjamin Kott uploaded patch set 15 V -1 02/19/26, 17:29

  31. core-ci voted on patch set 15 V -1 02/19/26, 17:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96276

  32. Benjamin Kott uploaded patch set 16 V -1 02/23/26, 08:09

  33. core-ci voted on patch set 16 V -1 02/23/26, 08:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96540

  34. Benjamin Kott uploaded patch set 17 V -1 02/23/26, 16:36

  35. Benjamin Kott commented on patch set 17 02/23/26, 16:46

    open-document-menu-element.ts:87 Reply

    Done
  36. core-ci voted on patch set 17 V -1 02/23/26, 16:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96603

  37. Benjamin Kott uploaded patch set 18 V -1 02/23/26, 20:35

  1. core-ci voted on patch set 18 V -1 02/23/26, 21:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96615

  2. Benjamin Kott rebased onto patch set 19 V -1 02/23/26, 21:34

  3. core-ci voted on patch set 18 V -1 02/23/26, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96615

  4. core-ci voted on patch set 19 V -1 02/23/26, 21:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96619

  5. Benjamin Kott uploaded patch set 20 V -1 02/23/26, 22:11

  6. core-ci voted on patch set 20 V -1 02/23/26, 22:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96620

  7. core-ci commented on patch set 20 02/24/26, 06:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96620

  8. Benjamin Kott uploaded patch set 21 V -1 02/24/26, 11:08

  9. core-ci voted on patch set 21 V -1 02/24/26, 11:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96711

  10. core-ci voted on patch set 21 V +1 02/24/26, 12:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96711

  11. Simon Schaufelberger commented on patch set 21 02/24/26, 19:34

    open-document-menu-element.ts:47

    may i ask why this is disabled here?

    open-document-menu-element.ts:75

    these 2 empty lines could be removed

    recent-documents-widget-element.ts:72

    remove empty line

    recent-documents-widget-element.ts:73

    why is it here disabled but above in render() not?

    OpenDocumentToolbarItem.php:38

    since this is private, the getBackendUser can also be private

    OpenDocumentController.php:186

    useless empty line added
  12. Benjamin Kott uploaded patch set 22 V +1 02/24/26, 22:07

  13. Benjamin Kott commented on patch set 22 02/24/26, 22:08

    open-document-menu-element.ts:47 Reply

    the indention gets wired when using inline functions

    open-document-menu-element.ts:75 Reply

    Done

    recent-documents-widget-element.ts:72 Reply

    Done

    recent-documents-widget-element.ts:73 Reply

    the indention gets wired when using inline functions, this is not nessesary in the render function

    OpenDocumentToolbarItem.php:38 Reply

    Done

    OpenDocumentController.php:186 Reply

    Done
  14. core-ci voted on patch set 22 V +1 02/24/26, 22:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96780

  15. Simon Schaufelberger commented on patch set 22 CR +1 V +1 02/24/26, 22:50

    love it!
  16. Benjamin Franzke commented on patch set 22 V -1 02/25/26, 10:05

    OpenDocumentRepository.php:149

    migrated document from 14.1 are not correctly migrated here (see DM)
  17. Benjamin Kott uploaded patch set 23 CR +1 V +1 02/25/26, 10:44

  18. Benjamin Kott commented on patch set 23 02/25/26, 10:44

    OpenDocumentRepository.php:149 Reply

    Done
  19. Benjamin Franzke commented on patch set 23 02/25/26, 10:50

    OpenDocumentRepository.php:149 Reply

    ack, works.
  20. Benjamin Franzke voted on patch set 23 CR +1 V +1 02/25/26, 10:53

  21. Simon Schaufelberger voted on patch set 23 CR +1 V +1 02/25/26, 11:04

  22. core-ci voted on patch set 23 V -1 02/25/26, 11:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96810

  23. core-ci voted on patch set 23 V +1 02/25/26, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96810

  24. Benjamin Kott voted on patch set 23 CR +2 V +2 02/25/26, 11:47

  25. Benjamin Kott merged patch set 24 02/25/26, 11:47