Review main Merged

92710[TASK] Improve wording of fallback description

Georg Ringer CR +2 V +2 Easy +2 −2 updated 05/02/26, 15:22

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2227

Show 2 earlier messages
  1. Georg Ringer uploaded patch set 1 02/06/26, 11:41

  2. Georg Ringer commented on patch set 1 02/06/26, 11:41

    This change is ready for review.
  1. core-ci voted on patch set 1 V -1 02/06/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95275

  2. core-ci voted on patch set 1 V +1 02/06/26, 13:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95275

  3. Riccardo De Contardi voted on patch set 1 V +1 02/06/26, 14:16

  4. Benni Mack voted on patch set 1 CR +1 V +1 04/21/26, 15:02

  5. Benni Mack updated the commit message in patch set 2 CR +1 V +1 04/22/26, 06:54

  6. Benni Mack voted on patch set 2 CR +1 V +1 04/22/26, 06:54

  7. core-ci voted on patch set 2 V -1 04/22/26, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100828

  8. Benni Mack rebased onto patch set 3 CR +1 V +1 04/22/26, 13:07

  9. Benni Mack voted on patch set 3 CR +1 V +1 04/22/26, 13:07

  10. core-ci voted on patch set 3 V +1 04/22/26, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100907

  11. Josef Glatz voted on patch set 3 CR +1 V +1 04/22/26, 18:29

  12. Christian Kuhn voted on patch set 3 CR +2 V +2 04/22/26, 22:11

  13. Garvin Hicking commented on patch set 3 CR -1 04/22/26, 22:25

    hang on
  14. Garvin Hicking commented on patch set 3 04/22/26, 22:25

    Naming things: Is a "default translation" the "content element in the default language"? Because then it's not a translation, it's the origin? So I propose: "Also show content records without translation" "Also show content records without default language" "Also show content records without translation origin"
  15. Garvin Hicking voted on patch set 3 CR -2 04/22/26, 22:26

  16. Christian Kuhn voted on patch set 3 CR 0 V 0 04/22/26, 22:26

  17. Christian Kuhn commented on patch set 3 04/22/26, 22:27

    Reply

    do you edit (main & backport)?
  18. Garvin Hicking commented on patch set 3 04/28/26, 14:19

    Reply

    I would need to know which wording to use, I'm uncertain
  19. Christian Kuhn uploaded patch set 4 CR +1 V +1 05/02/26, 14:04

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  20. Christian Kuhn commented on patch set 4 05/02/26, 14:04

    Reply

    Took the liberty to pick a wording: "Also show records that only exist in this language." Drops "default translation" (contradictory, as you noted: the default-language record is the origin, not a translation) and avoids "default language" (reads as "without a default language configured"). Applies to both rows since strict and fallback both end up with floating records included.
  21. Christian Kuhn commented on patch set 4 CR +1 V +1 05/02/26, 14:05

    note v14 backport needs update when main is merged.
  22. core-ci voted on patch set 4 V +1 05/02/26, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101394

  23. Garvin Hicking commented on patch set 4 CR +1 V +1 05/02/26, 14:18

    Am a bit unsure about "this" but since it relates to the current site config language option I guess its good enough to understand.
  24. Christian Kuhn voted on patch set 4 CR +2 V +2 05/02/26, 14:24

  25. Christian Kuhn merged patch set 5 05/02/26, 15:22