Review main Merged

92720[TASK] Allow whitespace in typeList of ExtensionManagementUtility::addToAllTCAtypes

Georg Ringer CR +2 V +2 Normal +69 −1 updated 11/14/26, 07:56

Commit message

Make the life of developers easier by allowing whitespaces in the optional
list of types in `ExtensionManagementUtility::addToAllTCAtypes`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1520

  1. Georg Ringer uploaded patch set 1 02/06/26, 15:07

  2. Georg Ringer commented on patch set 1 02/06/26, 15:07

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/06/26, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95302

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 02/06/26, 15:54

  5. Guido Schmechel voted on patch set 1 CR +1 V +1 02/07/26, 10:58

  6. Benni Mack commented on patch set 1 02/12/26, 16:44

    ExtensionManagementUtility.php:200

    we shouldn't remove the empty values, if "0" could be empty?

    ExtensionManagementUtility.php:204

    using "true" would actually avoid going to "int" values such as "0,1,2,3" if we have something like this. Although I like your solution, we somehow should always cast the type to string then I'd assume?
  7. Benni Mack wrote 04/21/26, 14:52

    Removed cc Benni Mack.
  8. Benni Mack updated the commit message in patch set 2 CR +1 V +1 04/22/26, 06:50

  9. core-ci voted on patch set 2 V -1 04/22/26, 12:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100808

  10. Benni Mack rebased onto patch set 3 V -1 07/22/26, 09:18

  11. core-ci voted on patch set 3 V +1 07/22/26, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105155

  12. Georg Ringer uploaded patch set 4 V +1 09/01/26, 18:34

  13. core-ci voted on patch set 4 V +1 09/01/26, 18:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107505

  14. Georg Ringer rebased onto patch set 5 V +1 10/22/26, 15:46

  15. core-ci voted on patch set 5 V +1 10/22/26, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112137

  16. Georg Ringer commented on patch set 5 11/03/26, 20:38

    ExtensionManagementUtility.php:200 Reply

    Done

    ExtensionManagementUtility.php:204 Reply

    Done
  17. Benni Mack commented on patch set 5 11/04/26, 15:28

    ExtensionManagementUtility.php:200

    what happens to the "0" type?
  18. Oliver Klee voted on patch set 5 CR +1 V +1 11/04/26, 15:54

  19. Benni Mack commented on patch set 5 CR +2 V +2 11/14/26, 07:56

    ExtensionManagementUtility.php:200 Reply

    Done
  20. Benni Mack merged patch set 6 11/14/26, 07:56