Review main Merged

92723[TASK] Add `Allow` header in 405 responses in backend routes

Benjamin Franzke CR +2 V +2 Easy +8 −32 updated 04/03/26, 04:24

Commit message

Use `MethodNotAllowedException` from EXT:core which already allows
to carry the allowed methods and adds the `Allow` header to
the generated response.

Note: This exception has been introduced with #104456 as part
of a security release. The existing exception was not removed
back then to be minimally invasive, but is removed now, since
it became superfluous.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1521

  1. Benjamin Franzke uploaded patch set 1 02/06/26, 15:25

  2. Benjamin Franzke rebased onto patch set 2 02/28/26, 10:24

  3. core-ci voted on patch set 2 V +1 02/28/26, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97019

  4. Benjamin Franzke uploaded patch set 3 V +1 03/03/26, 14:13

  5. Benjamin Franzke marked it ready for review 03/03/26, 14:13

  6. core-ci voted on patch set 3 V -1 03/03/26, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97186

  7. Benjamin Franzke uploaded patch set 4 V -1 03/03/26, 15:14

  8. core-ci voted on patch set 4 V -1 03/03/26, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97194

  9. Benjamin Franzke uploaded patch set 5 V -1 03/03/26, 15:46

  10. core-ci voted on patch set 5 V +1 03/03/26, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97201

  11. Benjamin Franzke wrote 03/03/26, 17:27

    Hashtag added: actions
  12. Benjamin Franzke rebased onto patch set 6 V +1 03/27/26, 20:15

  13. core-ci voted on patch set 6 V +1 03/27/26, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/98917

  14. Benjamin Franzke rebased onto patch set 7 V +1 03/30/26, 23:39

  15. Stefan Bürk voted on patch set 7 CR +1 03/30/26, 23:43

  16. core-ci voted on patch set 7 V +1 03/30/26, 23:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/99189

  17. Benjamin Franzke commented on patch set 7 04/02/26, 10:22

    Can be tested via browser console by requesting a POST-only route via GET: ``` const response = await fetch(TYPO3.settings.ajaxUrls.link_resource) console.log(response.headers.get('Allow')) ```
  18. Benjamin Kott voted on patch set 7 CR +1 V +1 04/02/26, 11:42

  19. Stefan Bürk voted on patch set 7 V +1 04/02/26, 20:38

  20. Benjamin Franzke voted on patch set 7 CR +2 V +2 04/03/26, 04:24

  21. Benjamin Franzke merged patch set 8 04/03/26, 04:24