Review main Merged

92726[BUGFIX] Fix inline usage of the new `f:render.*` ViewHelpers

Matthias Vogel CR +2 V +2 Hard +409 −8 updated 02/08/26, 12:55

Commit message

Inline usage with getContentArgumentName() cannot enforce required
arguments. Mark arguments as optional and add manual validation.

Add tests to cover inline rendering.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1316

  1. Matthias Vogel uploaded patch set 1 02/06/26, 16:11

  2. Matthias Vogel marked it work in progress 02/06/26, 16:11

  3. core-ci voted on patch set 1 V +1 02/06/26, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95326

  4. Matthias Vogel uploaded patch set 2 V +1 02/08/26, 08:49

  5. Matthias Vogel marked it ready for review 02/08/26, 08:49

  6. core-ci voted on patch set 2 V +1 02/08/26, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95399

  7. Garvin Hicking commented on patch set 2 02/08/26, 09:06

    Could you use this patch to also drive-by fix the wrong changelog markup for these two VHs?
  8. Matthias Vogel uploaded patch set 3 V +1 02/08/26, 09:09

  9. Matthias Vogel commented on patch set 3 02/08/26, 09:09

    Reply

    Done
  10. Garvin Hicking commented on patch set 3 02/08/26, 09:09

    ContentAreaViewHelperTest.php:137

    Sorry if this is a stupid question at this point, but I need to note this down for me Would <f:render.contentArea>{contentArea}</f:render.conteArea> and {contentArea -> f:render.contentArea()} also work? (And if not can we make it work? :))
  11. core-ci voted on patch set 3 V +1 02/08/26, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95400

  12. Matthias Vogel commented on patch set 3 02/08/26, 09:21

    ContentAreaViewHelperTest.php:137 Reply

    {contentArea -> f:render.contentArea()} Is testet in line 157. <f:render.contentArea>{contentArea}</f:render.conteArea> is most likely also working. But we I want to add something like this in the future: <f:render.contentArea contentArea="{contentArea}" recordAs="record" renderedContentAs="rendered"> Above each content elment. Record is a {record.mainType} {rendered} Below each content elment. </f:render.conteArea>
  13. Matthias Vogel commented on patch set 3 02/08/26, 09:37

    ContentAreaViewHelperTest.php:137 Reply

    Acknowledged
  14. Garvin Hicking voted on patch set 3 CR +1 V +1 02/08/26, 11:17

  15. Simon Praetorius voted on patch set 3 CR +2 V +2 02/08/26, 12:55

  16. Simon Praetorius merged patch set 4 02/08/26, 12:55