92726[BUGFIX] Fix inline usage of the new `f:render.*` ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
-
Verified V +2 Done
- Simon Praetorius +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108868-IntroduceFluidRenderRichTextViewHelper.rst+1 −1
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-108868-IntroduceFluidRenderTextViewHelper.rst+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Render/ContentAreaViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Render/RecordViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Render/RichTextViewHelper.php+4 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Render/TextViewHelper.php+4 −2
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Render/ContentAreaViewHelperTest.php3+40 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Render/RecordViewHelperTest.php+40 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Render/RichTextViewHelperTest.phpnew+161 −0
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/Render/TextViewHelperTest.phpnew+156 −0
Review log 1316
-
Matthias Vogel uploaded patch set 1 02/06/26, 16:11
-
Matthias Vogel marked it work in progress 02/06/26, 16:11
-
core-ci voted on patch set 1 V +1 02/06/26, 16:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95326
-
Matthias Vogel uploaded patch set 2
V +102/08/26, 08:49 -
Matthias Vogel marked it ready for review 02/08/26, 08:49
-
core-ci voted on patch set 2 V +1 02/08/26, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95399
-
Garvin Hicking commented on patch set 2 02/08/26, 09:06
Could you use this patch to also drive-by fix the wrong changelog markup for these two VHs? -
Matthias Vogel uploaded patch set 3
V +102/08/26, 09:09 -
Matthias Vogel commented on patch set 3 02/08/26, 09:09
Reply
Done -
Garvin Hicking commented on patch set 3 02/08/26, 09:09
ContentAreaViewHelperTest.php:137Sorry if this is a stupid question at this point, but I need to note this down for me Would <f:render.contentArea>{contentArea}</f:render.conteArea> and {contentArea -> f:render.contentArea()} also work? (And if not can we make it work? :)) -
core-ci voted on patch set 3 V +1 02/08/26, 09:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95400
-
Matthias Vogel commented on patch set 3 02/08/26, 09:21
ContentAreaViewHelperTest.php:137Reply{contentArea -> f:render.contentArea()} Is testet in line 157. <f:render.contentArea>{contentArea}</f:render.conteArea> is most likely also working. But we I want to add something like this in the future: <f:render.contentArea contentArea="{contentArea}" recordAs="record" renderedContentAs="rendered"> Above each content elment. Record is a {record.mainType} {rendered} Below each content elment. </f:render.conteArea> -
Matthias Vogel commented on patch set 3 02/08/26, 09:37
ContentAreaViewHelperTest.php:137ReplyAcknowledged -
Garvin Hicking voted on patch set 3 CR +1 V +1 02/08/26, 11:17
-
Simon Praetorius voted on patch set 3 CR +2 V +2 02/08/26, 12:55
-
Simon Praetorius merged patch set 4 02/08/26, 12:55