Review main Merged

92732[BUGFIX] Use correct form editor return URL after editing content element

Josua Vogel CR +2 V +2 Normal +55 −5 updated 02/09/26, 13:34

Commit message

When editing a content element within the form editor preview mode
and closing it after saving, the system returned to the wrong URL,
causing a "Required argument 'formDefinition' is not set" exception.

The issue occurred because the content element's edit link used the
current request URI as return URL, which pointed back to the preview
rendering endpoint.

This change fixes the issue by:

* Passing formPersistenceIdentifier through the rendering chain
* TypeScript: Send persistenceIdentifier in AJAX request
* Controller: Accept formPersistenceIdentifier parameter and set it
  as rendering option
* Fluid: Pass formPersistenceIdentifier to ViewHelper
* ViewHelper: Generate correct return URL to FormEditor->index
  with formPersistenceIdentifier parameter using UriBuilder
* Request manipulation: Override NormalizedParams to customize
  the return URL used by PageLayoutContext

The return URL now correctly points to the form editor with the
appropriate formPersistenceIdentifier, ensuring users can close
content element editing and return seamlessly to their form.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sven Liebert +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sven Liebert +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 710

  1. Josua Vogel uploaded patch set 1 02/06/26, 19:10

  2. core-ci voted on patch set 1 V +1 02/06/26, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95337

  3. Benni Mack updated the commit message in patch set 2 V +1 02/08/26, 11:47

  4. Benni Mack voted on patch set 2 CR +1 V +1 02/08/26, 11:47

  5. core-ci voted on patch set 2 V -1 02/08/26, 11:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95405

  6. Benni Mack rebased onto patch set 3 CR +1 V +1 02/08/26, 11:59

  7. core-ci voted on patch set 3 V +1 02/08/26, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95406

  8. Sven Liebert voted on patch set 3 CR +1 V +1 02/09/26, 08:32

  9. Benni Mack voted on patch set 3 CR +2 V +2 02/09/26, 13:34

  10. Benni Mack merged patch set 4 02/09/26, 13:34