Review main Merged

92736[BUGFIX] Use "default" as default group

Georg Ringer CR +2 V +2 Easy +4 −1 updated 06/24/26, 13:51

Commit message

If `ExtensionManagementUtility::addTcaSelectItem` is used to provide a new
element - typically a new content element - the default group is now set
to "default" instead of "-".

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Nikita Hovratov +1
    • Josua Vogel +1
    • Ravi Sachaniya +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Nikita Hovratov +1
    • Josua Vogel +1
    • Ravi Sachaniya +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2633

Show 58 earlier messages
  1. Georg Ringer uploaded patch set 1 02/07/26, 09:54

  2. Georg Ringer commented on patch set 1 02/07/26, 09:55

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 02/07/26, 10:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95377

  4. Georg Ringer rebased onto patch set 2 V -1 03/06/26, 15:45

  5. core-ci voted on patch set 2 V -1 03/06/26, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97518

  6. Georg Ringer uploaded patch set 3 V -1 03/06/26, 16:24

  7. Nikita Hovratov commented on patch set 3 03/06/26, 16:51

    ExtensionManagementUtility.php:414

    Should we restrict this to table tt_content and field CType? Everywhere else the "default" group might not exist.
  8. core-ci voted on patch set 3 V +1 03/06/26, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97519

  1. Georg Ringer uploaded patch set 4 V +1 03/07/26, 06:32

  2. core-ci voted on patch set 4 V -1 03/07/26, 06:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97542

  3. Georg Ringer uploaded patch set 5 V -1 03/07/26, 07:19

  4. core-ci voted on patch set 5 V +1 03/07/26, 07:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97544

  5. Simon Schaufelberger commented on patch set 5 CR +1 V +1 03/07/26, 09:20

    ExtensionManagementUtility.php:414 Reply

    Done
  6. Christian Kuhn voted on patch set 5 CR +1 03/07/26, 10:32

  7. Nikita Hovratov commented on patch set 5 03/09/26, 08:09

    ExtensionManagementUtility.php:414 Reply

    Thanks! I think we also need a restriction for $field == 'CType'
  8. Josua Vogel voted on patch set 5 CR +1 V +1 03/11/26, 20:31

  9. Georg Ringer commented on patch set 6 CR +1 V +1 03/11/26, 21:18

    Published edit on patch set 5.
  10. Garvin Hicking voted on patch set 6 CR +1 V +1 03/11/26, 21:21

  11. core-ci voted on patch set 6 V +1 03/11/26, 21:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97780

  12. Simon Schaufelberger commented on patch set 6 CR +1 V +1 03/11/26, 21:32

    ExtensionManagementUtility.php:414 Reply

    Done
  13. Josua Vogel voted on patch set 6 CR +1 V +1 03/11/26, 21:49

  14. Nikita Hovratov voted on patch set 6 CR +1 03/12/26, 07:23

  15. Nikita Hovratov voted on patch set 6 V +1 03/13/26, 08:20

  16. Mathias Brodala commented on patch set 6 04/16/26, 08:02

    IMO "TCA select item" should be mentioned here, too. Otherwise it's impossible to understand the topic just from the title.
  17. Benni Mack updated the commit message in patch set 7 CR +1 V +1 04/22/26, 06:56

  18. core-ci voted on patch set 7 V +1 04/22/26, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100840

  19. Simon Schaufelberger voted on patch set 7 CR +1 V +1 05/09/26, 18:13

  20. Nikita Hovratov voted on patch set 7 CR +1 V +1 05/11/26, 07:39

  21. Josua Vogel voted on patch set 7 CR +1 V +1 05/12/26, 16:47

  22. Christian Kuhn wrote 06/18/26, 23:08

    Removed reviewer Christian Kuhn.
  23. Ravi Sachaniya voted on patch set 7 CR +1 V +1 06/24/26, 06:24

  24. Garvin Hicking commented on patch set 7 CR +2 V +2 06/24/26, 13:24

    Reply

    I'll merge this as-is because I don't want to do revotes just because of this. I agree it would've been clearer with that title, I hope you can overlook the unspecificicitifitity. ;)
  25. Garvin Hicking merged patch set 8 06/24/26, 13:51