Review 13.4 Merged

92737[TASK] Improve test coverage for extbase BooleanValidator

Georg Ringer CR +2 V +2 Normal +44 −15 updated 02/07/26, 10:34

Commit message

The `BooleanValidator` accepts various representations of boolean
values (`true`, `'true'`, `1`, `'1'` for `true` and `false`,
`'false'`, `0`, `'0'`, `''` for `false`) for the `is` validator
option.

This change adds data providers to test all valid representations
instead of testing only a single variant per test case.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 02/07/26, 10:20

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 02/07/26, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95378

  3. Georg Ringer voted on patch set 1 CR +2 V +2 02/07/26, 10:34

  4. Georg Ringer merged patch set 2 02/07/26, 10:34