Review main Merged

92738[BUGFIX] Remove inherited pageContext from TableListViewHelper

Florian E. CR +2 V +2 Easy +1 −1 updated 02/09/26, 06:29

Commit message

The TableListViewHelper passes the full server request including
the pageContext attribute to DatabaseRecordList. This causes
unintended language filtering when the Page Module has a language
filter active, resulting in empty output in custom backend modules.

Strip the pageContext attribute from the request before passing it
to DatabaseRecordList to prevent inherited language filtering.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Florian E. uploaded patch set 1 02/07/26, 10:54

  2. core-ci voted on patch set 1 V -1 02/07/26, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95379

  3. Florian E. uploaded patch set 2 V -1 02/07/26, 11:08

  4. core-ci voted on patch set 2 V +1 02/07/26, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95380

  5. Benni Mack voted on patch set 2 CR +1 V +1 02/07/26, 11:53

  6. Garvin Hicking commented on patch set 2 02/08/26, 20:17

    How about making this optional with an argument to the VH. We might even want to keep the page context by default then, and then the consumer can decide if he needs it contextless? I think the page context is a good step that we should not completely uncoditionally bypass here...?
  7. Georg Ringer commented on patch set 2 02/09/26, 06:29

    Reply Unresolved

    but the context alone is not enough, then you also need the whole module properly setup to be able to switch languages. if you do that, you can also initialize the DB list yourself. I see this VH as as simple "fire & forget" solution
  8. Georg Ringer voted on patch set 2 CR +2 V +2 02/09/26, 06:29

  9. Georg Ringer merged patch set 3 02/09/26, 06:29