Review main Merged

92742[BUGFIX] Add space for dialog close button label

Richard Krikler CR +2 V +2 Easy +2 −2 updated 02/11/26, 20:13

Commit message

Using MacOS VoiceOver to read backend dialog close button label appears
to miss space between "Close" and following words (modalTitle).

Due to lit's rendering the space between button-close and modalTitle
disappears in the outputted template:
`<!--?lit$784970363$-->Close<!--?lit$784970363$-->Search`

The browser's accessibility tree will then interpret it as:
`Name: "CloseSearch"`

This is resolved by directly concatenating the space inside one template
 literal.

Commands executed:
  ./Build/Scripts/runTests.sh -s build

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1619

  1. Richard Krikler uploaded patch set 1 02/07/26, 23:07

  2. core-ci voted on patch set 1 V +1 02/07/26, 23:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95387

  3. Richard Krikler commented on patch set 1 02/08/26, 11:32

    If this is fine, a patch for 13.4 is also necessary to solve this issue in that version. (As the build js output is different in 13.4)
  4. Georg Ringer updated the commit message in patch set 2 02/09/26, 06:48

  5. Georg Ringer voted on patch set 2 CR +1 V +1 02/09/26, 06:49

  6. core-ci voted on patch set 2 V +1 02/09/26, 06:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95436

  7. Garvin Hicking commented on patch set 2 02/09/26, 10:59

    Reply

    We cherry-pick patches from this, that's the core merger's "job". You've created a separate patch which we cannot merge. I'll abandon the other one, and we'll take care when merging. Thank you! :) (I can't comment on the actual problem. I wonder why we need a non breaking space here, then other words should also be read wrongly if they just have a "regular" space)
  8. Josef Glatz voted on patch set 2 CR +1 V +1 02/09/26, 11:52

  9. Simon Schaufelberger commented on patch set 2 02/10/26, 17:05

    Reply

    I find this patch also a bit weird as a normal space character must be considered as space.
  10. Richard Krikler commented on patch set 2 02/10/26, 17:50

    Reply

    I think that this is due to lit's rendering. The parsed output with a normal space character is the following: ```HTML <span class="visually-hidden"><!--?lit$784970363$-->Close<!--?lit$784970363$-->Search</span> ``` The browser's accessibility tree will then interpret it as: `Name: "CloseSearch"` Another (probably better than a HTML character entity) solution might be to concatenate both strings in the lit-template: ```HTML <span class="visually-hidden">${(TYPO3?.lang?.['button.close'] || 'Close') + ' ' + this.modalTitle}</span> ``` This will result in a combined string (not interrupted by lit-rendering): ```HTML <span class="visually-hidden"><!--?lit$100237209$-->Close Search</span> ``` The browser's accessibility tree will then interpret it as: `Name: "Close Search"`
  11. Garvin Hicking commented on patch set 2 02/10/26, 18:16

    Reply

    That would look better to me :)
  12. Richard Krikler uploaded patch set 3 CR +1 V +1 02/10/26, 19:41

  13. Richard Krikler commented on patch set 3 02/10/26, 19:41

    Reply

    Done
  14. core-ci voted on patch set 3 V +1 02/10/26, 19:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95572

  15. Garvin Hicking voted on patch set 3 CR +1 V +1 02/10/26, 19:57

  16. Simon Schaufelberger voted on patch set 3 CR +1 V +1 02/10/26, 20:50

  17. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/11/26, 19:50

  18. Garvin Hicking voted on patch set 3 CR +2 V +2 02/11/26, 19:54

  19. Garvin Hicking merged patch set 4 02/11/26, 20:13