Review main Merged

92745[TASK] Replace "OK" label in sys_note modals and use the new syntax

Riccardo De Contardi CR +2 V +2 Easy +12 −5 updated 02/18/26, 19:25

Commit message

within the ext:sys_note:
- replace "OK" on the delete modal with a label coherent
with the actual action performed
- Use the new language domain syntax for the labels inside
 the modal wherever possible
- adjust the modal title and message to be more descriptive

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Josua Vogel +1
    • Peter Kraume +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Josua Vogel +1
    • Peter Kraume +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1217

  1. Riccardo De Contardi uploaded patch set 1 02/08/26, 16:41

  2. core-ci voted on patch set 1 V -1 02/08/26, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95412

  3. Riccardo De Contardi uploaded patch set 2 V -1 02/08/26, 16:55

  4. core-ci voted on patch set 2 V +1 02/08/26, 17:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95413

  5. Peter Kraume voted on patch set 2 CR +1 V +1 02/08/26, 17:38

  6. Garvin Hicking commented on patch set 2 02/08/26, 19:18

    label.xlf:1

    Do we need one file for just this one label? I think we should put it into locallang.xlf which could be moved conpletely to messages.xlf in v15. Loading distinct files is always overhead for the file access layer and caching.
  7. Riccardo De Contardi uploaded patch set 3 CR +1 V +1 02/09/26, 10:25

  8. Garvin Hicking commented on patch set 3 CR +1 V +1 02/09/26, 10:55

    label.xlf:1 Reply

    Done
  9. core-ci voted on patch set 3 V -1 02/09/26, 10:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95457

  10. Garvin Hicking uploaded patch set 4 CR +1 V +1 02/09/26, 11:09

  11. core-ci voted on patch set 4 V -1 02/09/26, 11:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95461

  12. Garvin Hicking rebased onto patch set 5 V -1 02/09/26, 13:35

  13. core-ci voted on patch set 5 V +1 02/09/26, 13:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95467

  14. Peter Kraume voted on patch set 5 CR +1 V +1 02/09/26, 14:48

  15. Josua Vogel voted on patch set 5 CR +1 V +1 02/17/26, 21:07

  16. Anja Leichsenring voted on patch set 5 CR +2 V +2 02/18/26, 19:25

  17. Anja Leichsenring merged patch set 6 02/18/26, 19:25