Review main Merged

92747[BUGFIX] Prevent usage of dot-notation in reworked TSConfig access

Garvin Hicking CR +2 V +2 Easy +3 −3 updated 02/09/26, 17:53

Commit message

In #108016 we introduced the PageContext to RecordListController and
thus DatabaseRecordList, which uses a simplified TSConfig access
without the 'dot' notation of nested arrays, so be interoperable
with TCA Schema API.

We missed however a few instances in DatabaseRecordList where the
old dot notation was still accessed. This patch adjusts these
use cases.

Can be reproduced for example by setting:

```
mod.web_list.table.tt_content.hideTable = 1
```

which did not work without this change.

Note that only `tableTSconfigOverTCA` has the dot-removed syntax,
the `modTSconfig` one still has the dot-notation in effect.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Felix Nagel +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Felix Nagel +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1013

  1. Garvin Hicking uploaded patch set 1 02/09/26, 07:39

  2. Felix Nagel commented on patch set 1 CR +1 V +1 02/09/26, 08:10

    +1 by reading and testing in a 14.1.0 instance
  3. core-ci voted on patch set 1 V -1 02/09/26, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95439

  4. Garvin Hicking commented on patch set 1 CR -1 02/09/26, 08:18

    OK I'm sorry, the CI reports failures on the download preset tests. Needs more evaluation for that.
  5. Garvin Hicking uploaded patch set 2 CR +1 V +1 02/09/26, 08:22

    Hooray for tests
  6. core-ci voted on patch set 2 V +1 02/09/26, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95443

  7. Felix Nagel commented on patch set 2 CR -1 02/09/26, 08:43

    DatabaseRecordList.php:1112

    @garvin@hick.ing Adding to dots (e.g. "table.." as array key) here does look suspicious to me. Is that on purpose?
  8. Garvin Hicking commented on patch set 3 CR -1 V +1 02/09/26, 10:04

    Published edit on patch set 2.
  9. Garvin Hicking commented on patch set 3 02/09/26, 10:04

    DatabaseRecordList.php:1112

    ```suggestion $shouldRenderSelector = (bool)$this->modTSconfig['table.'][$table . '.']['displayColumnSelector']; ```

    DatabaseRecordList.php:1112 Reply

    Totally. I made a boo there when reverting this part. Sorry and thanks for catching this!
  10. core-ci voted on patch set 3 V +1 02/09/26, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95454

  11. Felix Nagel commented on patch set 3 CR +1 V +1 02/09/26, 13:24

    +1 by reading and testing in v14.1.0
  12. Georg Ringer voted on patch set 3 CR +2 V +2 02/09/26, 17:53

  13. Georg Ringer merged patch set 4 02/09/26, 17:53