92747[BUGFIX] Prevent usage of dot-notation in reworked TSConfig access
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Felix Nagel +1
-
Verified V +2 Done
- Georg Ringer +2
- Felix Nagel +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1013
-
Garvin Hicking uploaded patch set 1 02/09/26, 07:39
-
Felix Nagel commented on patch set 1 CR +1 V +1 02/09/26, 08:10
+1 by reading and testing in a 14.1.0 instance -
core-ci voted on patch set 1 V -1 02/09/26, 08:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95439
-
Garvin Hicking commented on patch set 1 CR -1 02/09/26, 08:18
OK I'm sorry, the CI reports failures on the download preset tests. Needs more evaluation for that. -
Garvin Hicking uploaded patch set 2
CR +1V +102/09/26, 08:22Hooray for tests -
core-ci voted on patch set 2 V +1 02/09/26, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95443
-
Felix Nagel commented on patch set 2 CR -1 02/09/26, 08:43
DatabaseRecordList.php:1112@garvin@hick.ing Adding to dots (e.g. "table.." as array key) here does look suspicious to me. Is that on purpose? -
Garvin Hicking commented on patch set 3
CR -1V +102/09/26, 10:04Published edit on patch set 2. -
Garvin Hicking commented on patch set 3 02/09/26, 10:04
DatabaseRecordList.php:1112```suggestion $shouldRenderSelector = (bool)$this->modTSconfig['table.'][$table . '.']['displayColumnSelector']; ```DatabaseRecordList.php:1112ReplyTotally. I made a boo there when reverting this part. Sorry and thanks for catching this! -
core-ci voted on patch set 3 V +1 02/09/26, 10:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95454
-
Felix Nagel commented on patch set 3 CR +1 V +1 02/09/26, 13:24
+1 by reading and testing in v14.1.0 -
Georg Ringer voted on patch set 3 CR +2 V +2 02/09/26, 17:53
-
Georg Ringer merged patch set 4 02/09/26, 17:53