Review main Abandoned

9275[BUGFIX] Incorrect redirect with multiple user groups

Dmitry Dulepov CR 0 V 0 Easy +15 −7 updated 06/03/13, 20:49

Commit message

If the "redirectMode" is set to "groupLogin" and there are several
groups with "felogin_redirectPid", the redirect should happen to
the first or last group (depending on the mode of "redirectFirst"
flag. The actual redirect result is undefined because felogin
fetches groups from the database without any sorting. Depending
on MySQL internal index state, results can come in any order and
this order can change over time. In addition felogin uses
$GLOBALS['TSFE']->fe_user->groupData['uid'], which contains sorted
uid values for groups. This prevents correct redirects for
multiple groups too.

Felogin should ensure that it adds redirects URLs in the proper order.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Files 1