92750[FEATURE] Add generic error action for HTTP status codes in ErrorController
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Anja Leichsenring +1
- Josua Vogel +1
-
Verified V +2 Done
- Garvin Hicking +2
- Anja Leichsenring +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 2
Review log 3647
Show 1422 earlier messages
-
Torben Hansen uploaded patch set 1 02/09/26, 10:07
-
core-ci voted on patch set 1 V +1 02/09/26, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95456
-
Torben Hansen marked it work in progress 02/09/26, 10:26
-
Torben Hansen updated the commit message in patch set 2
V +102/09/26, 10:26 -
core-ci voted on patch set 2 V +1 02/09/26, 10:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95458
-
Torben Hansen uploaded patch set 3
V +102/09/26, 18:28 -
Torben Hansen marked it ready for review 02/09/26, 18:29
-
core-ci voted on patch set 3 V +1 02/09/26, 18:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95482
-
Anja Leichsenring updated the commit message in patch set 4
V +102/09/26, 19:22 -
Anja Leichsenring uploaded patch set 5 02/09/26, 19:29
-
core-ci voted on patch set 4 V +1 02/09/26, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95485
-
Anja Leichsenring commented on patch set 5 02/09/26, 19:31
-
core-ci voted on patch set 5 V +1 02/09/26, 19:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95486
-
Simon Schaufelberger commented on patch set 5 02/09/26, 23:01
As an... -
Anja Leichsenring updated the commit message in patch set 6
V +102/10/26, 05:27 -
Anja Leichsenring commented on patch set 6 02/10/26, 05:27
Reply
Done -
core-ci voted on patch set 6 V +1 02/10/26, 05:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95523
-
Torben Hansen uploaded patch set 7
V +102/11/26, 08:02 -
Torben Hansen commented on patch set 7 02/11/26, 08:10
ErrorController.php:149ReplyI renamed one of the variables to be more clear what it is used for and also added a new doc comment to clarify, what the `$reasons` array is used for. Basically, `$reasons` is only used in TYPO3 core in site error handlers to determine, if the error handler is responsible. The array can have several keys like e.g. `code` with a `PageAccessFailureReasons` or `sub_section` with some additonal information. This is some kind of unfortunate, but I have no idea how to improve this without being breaking. -
core-ci voted on patch set 7 V -1 02/11/26, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95601
-
Torben Hansen rebased onto patch set 8
V -102/11/26, 08:39 -
core-ci voted on patch set 8 V +1 02/11/26, 08:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95604
-
Anja Leichsenring commented on patch set 8 CR +1 V +1 02/11/26, 19:39
ErrorController.php:149ReplyAcknowledged -
Georg Ringer commented on patch set 8 02/11/26, 21:33
if it is a feature we need a feature.rst -
Oliver Klee voted on patch set 8 CR +1 02/11/26, 23:15
-
Torben Hansen uploaded patch set 9
CR +1V +102/14/26, 10:49 -
Torben Hansen commented on patch set 9 02/14/26, 10:49
Reply
Good catch, I completely forgot the feature RST. -
core-ci voted on patch set 9 V +1 02/14/26, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95882
-
Oliver Klee voted on patch set 9 CR +1 02/14/26, 12:19
-
Simon Schaufelberger commented on patch set 9 02/14/26, 12:22
Feature-108904-AddGenericErrorActionForCustomHTTPStatusCodesInErrorController.rst:15I don't know if it's relevant but there is a space after `:php:` -
Torben Hansen commented on patch set 10
CR +1V +102/14/26, 12:40Published edit on patch set 9. -
Torben Hansen commented on patch set 10 02/14/26, 12:40
Feature-108904-AddGenericErrorActionForCustomHTTPStatusCodesInErrorController.rst:15ReplyDone -
core-ci voted on patch set 10 V +1 02/14/26, 12:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95890
-
Simon Schaufelberger voted on patch set 10 CR +1 V +1 02/14/26, 12:50
-
Oliver Klee voted on patch set 10 CR +1 02/14/26, 12:54
-
Anja Leichsenring voted on patch set 10 CR +1 V +1 02/15/26, 05:34
-
Anja Leichsenring commented on patch set 10 CR 0 02/16/26, 16:38
Actually, why do you deprecate a protected method in ErrorController? This one should not be overridden or directly called in userland code. To give credit where it is due: Benni spotted it. As far as I am concerned, the feature.rst is sufficient and we don't need any formal deprecation for handleDefaultError(). -
Torben Hansen commented on patch set 10 02/16/26, 17:07
Reply
Thanks for the feedback. So is it ok then to remove the function completely? -
Anja Leichsenring commented on patch set 10 02/16/26, 18:08
Reply
yes, that should be fine. Protected methods are not part of public API. -
Benni Mack uploaded patch set 11
CR +1V +102/27/26, 19:09 -
Benni Mack commented on patch set 11 02/27/26, 19:09
Reply
Done -
core-ci voted on patch set 11 V +1 02/27/26, 19:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96991
-
Oliver Klee voted on patch set 11 CR +1 02/27/26, 19:43
-
Anja Leichsenring voted on patch set 11 CR +1 V +1 03/04/26, 08:33
-
Josua Vogel voted on patch set 11 CR +1 V +1 03/04/26, 08:34
-
Garvin Hicking voted on patch set 11 CR +2 V +2 03/04/26, 08:37
-
Garvin Hicking merged patch set 12 03/04/26, 08:38
ErrorController.php:149