Review main Abandoned

92756[BUGFIX] Prevent evaluating hidden TypoScript in backend modules

Oliver Hader CR 0 V 0 Normal +223 −16 updated 02/09/26, 16:15

Commit message

The `SysTemplateRepository` fetches database records from sys_template
by checking the visibility context aspect. In the backend module,
this is set to 'includeHiddenContent: true' by default (greedy backend),
so that hidden records (or those with time restrictions) can always be
revealed.

This is important to be able to edit/modify the `sys_template` records,
and to enable/disable them, or put starttime/endtime on them.

But, hidden records should NOT be evaluated inside the modules:

* Active TypoScript
* Included TypoScript
* Constant Editor

In the context of these controllers, the visibility aspect is now
changed to 'includeHiddenContent: false' plus
'includeScheduledRecords: false'. Since this is done in three
controllers dealing with simulation, that assignment is done
in the `AbstractTemplateModuleController`, and called from
the specific three instances.

Tests are added to verify that the `SysTemplateRepository` properly
evaluates the contexts.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 2

Files 9

Review log 34

  1. Oliver Hader uploaded patch set 1 02/09/26, 15:43

  2. Oliver Hader uploaded patch set 2 02/09/26, 15:45

  3. core-ci voted on patch set 2 V +1 02/09/26, 15:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95476

  4. Oliver Hader abandoned the change 02/09/26, 16:15