Review main Merged

92760[BUGFIX] Apply CSP headers to default error responses

Oliver Hader CR +2 V +2 Normal +161 −33 updated 02/27/26, 07:44

Commit message

Error responses from ErrorController::handleDefaultError()
bypass the ContentSecurityPolicyHeaders middleware since it
sits deeper in the stack. Centralize CSP application logic
in ContentSecurityPolicyHeaders via a new applyToResponse()
method and call it from ErrorController for default error
responses.

Configured error handlers (e.g. PageContentErrorHandler)
already apply their own CSP headers via subrequest, so only
the fallback handleDefaultError() path needs wrapping.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1319

  1. Oliver Hader uploaded patch set 1 02/09/26, 23:06

  2. Oliver Hader marked it work in progress 02/09/26, 23:06

  3. core-ci voted on patch set 1 V -1 02/09/26, 23:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95496

  4. Oliver Hader uploaded patch set 2 V -1 02/09/26, 23:19

  5. core-ci voted on patch set 2 V +1 02/09/26, 23:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95498

  6. Torben Hansen updated the commit message in patch set 3 V +1 02/10/26, 09:53

  7. core-ci voted on patch set 3 V +1 02/10/26, 10:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95532

  8. Torben Hansen uploaded patch set 4 V +1 02/10/26, 18:24

  9. core-ci voted on patch set 4 V +1 02/10/26, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95569

  10. Torben Hansen updated the commit message in patch set 5 V +1 02/14/26, 10:33

  11. core-ci voted on patch set 5 V +1 02/14/26, 10:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95879

  12. Oliver Hader commented on patch set 5 02/14/26, 10:51

    This change is ready for review.
  13. Torben Hansen voted on patch set 5 CR +1 V +1 02/14/26, 11:04

  14. Simon Schaufelberger uploaded patch set 6 CR +1 V +1 02/14/26, 12:01

  15. Simon Schaufelberger voted on patch set 6 CR +1 V +1 02/14/26, 12:02

  16. core-ci voted on patch set 6 V +1 02/14/26, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95888

  17. Benni Mack voted on patch set 6 CR +1 V +1 02/21/26, 08:42

  18. Oliver Hader voted on patch set 6 CR +2 V +2 02/27/26, 07:44

  19. Oliver Hader merged patch set 7 02/27/26, 07:44