Review 12.4 Merged

92766[BUGFIX] Handle invalid UTF-8 in sudo mode session data

Oliver Hader CR +2 V +2 Normal +75 −1 updated 02/10/26, 07:43

Commit message

ServerRequestInstruction captures $_SERVER parameters which
may contain Latin-1 encoded values (e.g. GEOIP_CITY with
\xFC for ü). When AccessStorage::commitItems() calls
json_encode() on such data, it returns false, silently
losing all stored claims and grants.

Add JSON_INVALID_UTF8_SUBSTITUTE flag so invalid UTF-8
bytes are replaced with U+FFFD instead of failing the
entire encode operation.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 02/09/26, 23:38

  2. core-ci voted on patch set 1 V +1 02/09/26, 23:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95504

  3. Oliver Hader voted on patch set 1 CR +2 V +2 02/10/26, 07:42

  4. Oliver Hader merged patch set 2 02/10/26, 07:43