92779[TASK] Add QR code to generated preview links in modal
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1318
-
Georg Ringer uploaded patch set 1 02/10/26, 17:03
-
Georg Ringer commented on patch set 1 02/10/26, 17:03
This change is ready for review. -
core-ci voted on patch set 1 V +1 02/10/26, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95563
-
Peter Kraume commented on patch set 1 02/11/26, 07:32
There should be at least one line break between the link and the QR Code. And while on it: would it be possible to add a button to copy the link to the clipboard? -
Josef Glatz commented on patch set 1 02/11/26, 11:39
Reply
AD copy link: that was already a suggestion which was mentioned as feature request at mtug. -
Josef Glatz commented on patch set 1 CR -1 02/11/26, 11:51
beside Peter's mentioned ux topic: patch introduces an error in the browser console for each generated qr code: ``` NotAllowedError: Failed to set the 'adoptedStyleSheets' property on 'ShadowRoot': Sharing constructed stylesheets in multiple documents is not allowed at S (css-tag.js?bust=1770810330:6:1019) .... ``` -
Georg Ringer uploaded patch set 2
CR -1V +109/10/26, 20:49 -
core-ci voted on patch set 2 V +1 09/10/26, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108270
-
Georg Ringer uploaded patch set 3
V +110/10/26, 09:07 -
core-ci voted on patch set 3 V +1 10/10/26, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110778
-
Oli Bartsch commented on patch set 3 10/10/26, 17:25
Suggest to do a dual button instead of the showing the link directly. So having two buttons "Open preview" - "Copy Preview Link" and the QR Code below -
Georg Ringer uploaded patch set 4
V +110/11/26, 12:49 -
core-ci voted on patch set 4 V +1 10/11/26, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110852
-
Oli Bartsch uploaded patch set 5
V +110/12/26, 07:17 -
Oli Bartsch commented on patch set 5 CR +1 V +1 10/12/26, 07:17
Reply
Done -
core-ci voted on patch set 5 V +1 10/12/26, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110888
-
Benni Mack voted on patch set 5 CR +2 V +2 10/12/26, 08:24
-
Benni Mack merged patch set 6 10/12/26, 08:24