Review main Merged

92779[TASK] Add QR code to generated preview links in modal

Georg Ringer CR +2 V +2 Normal +37 −24 updated 10/12/26, 08:24

Commit message

The modal with the generated workspace preview links now shows two
buttons for every link, one to open the preview and one to copy the
link to the clipboard, followed by a QR code of the link.

The used web components are imported into the top frame, since the
modal is rendered there. Creating them in the module iframe made the
browser refuse the constructed stylesheets of the components.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1318

  1. Georg Ringer uploaded patch set 1 02/10/26, 17:03

  2. Georg Ringer commented on patch set 1 02/10/26, 17:03

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/10/26, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95563

  4. Peter Kraume commented on patch set 1 02/11/26, 07:32

    There should be at least one line break between the link and the QR Code. And while on it: would it be possible to add a button to copy the link to the clipboard?
  5. Josef Glatz commented on patch set 1 02/11/26, 11:39

    Reply

    AD copy link: that was already a suggestion which was mentioned as feature request at mtug.
  6. Josef Glatz commented on patch set 1 CR -1 02/11/26, 11:51

    beside Peter's mentioned ux topic: patch introduces an error in the browser console for each generated qr code: ``` NotAllowedError: Failed to set the 'adoptedStyleSheets' property on 'ShadowRoot': Sharing constructed stylesheets in multiple documents is not allowed at S (css-tag.js?bust=1770810330:6:1019) .... ```
  7. Georg Ringer uploaded patch set 2 CR -1 V +1 09/10/26, 20:49

  8. core-ci voted on patch set 2 V +1 09/10/26, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108270

  9. Georg Ringer uploaded patch set 3 V +1 10/10/26, 09:07

  10. core-ci voted on patch set 3 V +1 10/10/26, 09:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110778

  11. Oli Bartsch commented on patch set 3 10/10/26, 17:25

    Suggest to do a dual button instead of the showing the link directly. So having two buttons "Open preview" - "Copy Preview Link" and the QR Code below
  12. Georg Ringer uploaded patch set 4 V +1 10/11/26, 12:49

  13. core-ci voted on patch set 4 V +1 10/11/26, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110852

  14. Oli Bartsch uploaded patch set 5 V +1 10/12/26, 07:17

  15. Oli Bartsch commented on patch set 5 CR +1 V +1 10/12/26, 07:17

    Reply

    Done
  16. core-ci voted on patch set 5 V +1 10/12/26, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/110888

  17. Benni Mack voted on patch set 5 CR +2 V +2 10/12/26, 08:24

  18. Benni Mack merged patch set 6 10/12/26, 08:24