Review main Merged

92782[BUGFIX] Add fallback for GridColumnItem->getRecordType

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 02/11/26, 21:31

Commit message

GridColumnItems can contain other records besides
Content Elements, which might not have a type.
Previous patches already established the possibility
to be record-agnostic.

A recent patch established the usage of RecordInterface
in backend previews and introduced a regression in the
process. To fix this, the method returns an empty
string again if no type is available like it used to.

Right now, this feature is only used by Content Blocks
to display previews of Collections, which led to the
discovery of this bug.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 67

  1. Nikita Hovratov uploaded patch set 1 02/10/26, 18:12

  2. core-ci voted on patch set 1 V +1 02/10/26, 18:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95568

  3. Oliver Klee commented on patch set 1 02/10/26, 18:21

    Is there any way we could have a regression test for this?
  4. Nikita Hovratov commented on patch set 1 02/10/26, 18:35

    Reply Unresolved

    Normally, this would be covered by phpstan, because the return type is ?string. But I think the level is not high enough.
  5. Anja Leichsenring voted on patch set 1 CR +1 V +1 02/11/26, 19:51

  6. Georg Ringer voted on patch set 1 CR +2 V +2 02/11/26, 21:31

  7. Georg Ringer merged patch set 2 02/11/26, 21:31