Review main Merged

92785[TASK] Create compatibility for ImageMagick 7

André Buchmann CR +2 V +2 Easy +5 −4 updated 02/12/26, 21:04

Commit message

ImageMagick 7 has removed the legacy "+matte" command line
operator, which was previously used to disable the alpha channel.
This causes image processing to produce incorrect outputs when
using newer versions of ImageMagick.

This patch replaces all occurrences of "+matte" with "-alpha off"
for ImageMagick, which is the modern equivalent supported by
ImageMagick 6/7.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1518

  1. André Buchmann uploaded patch set 1 02/10/26, 23:00

  2. core-ci voted on patch set 1 V +1 02/10/26, 23:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95577

  3. Garvin Hicking commented on patch set 1 CR +1 V +1 02/11/26, 07:12

    (Asking other mergers for 12.4 scope)
  4. Oliver Hader voted on patch set 1 CR +1 02/11/26, 07:51

  5. Garvin Hicking commented on patch set 1 CR -1 V -1 02/11/26, 08:01

    Sorry: The "-alpha" command does NOT work for graphicsmagick. So we'll need a switch here. @andy.schliesser@gmail.com Do you want to update the patch?
  6. André Buchmann commented on patch set 1 02/11/26, 08:04

    Reply

    I really hope we can add this to 12.4 also as we are very very late adopters to the deprecation of +matte. IM6 is now already phasing out (e.g. Debian Trixie now comes with IM7. Even 12.4 projects will likely get a server update until the end of ELTS for this TYPO3 version.
  7. André Buchmann uploaded patch set 2 CR +1 V +1 02/11/26, 16:26

  8. André Buchmann commented on patch set 2 02/11/26, 16:27

    Reply

    Done
  9. core-ci voted on patch set 2 V -1 02/11/26, 16:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95637

  10. Garvin Hicking commented on patch set 2 02/11/26, 20:00

    GifBuilder.php:951

    This here needs the same logic. "imageMagickExec" sounds as if it would only affect imageMagick, but it applies to graphicsMagick too. -.-
  11. Garvin Hicking commented on patch set 2 02/11/26, 20:00

    Reply

    Yes, we'll take it for 12.4
  12. André Buchmann uploaded patch set 3 V -1 02/12/26, 08:18

  13. André Buchmann commented on patch set 3 02/12/26, 08:24

    GifBuilder.php:951 Reply

    Very confusing naming. Done
  14. core-ci voted on patch set 3 V +1 02/12/26, 08:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95693

  15. Garvin Hicking commented on patch set 3 CR +1 V +1 02/12/26, 11:34

    Thanks this does the trick for me in both ImageMagick and GraphicsMagick scenarios
  16. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/12/26, 19:50

  17. Garvin Hicking voted on patch set 3 CR +2 V +2 02/12/26, 20:09

  18. Garvin Hicking merged patch set 4 02/12/26, 21:04