92793[BUGFIX] Reload backend after extension state changes
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Benjamin Kott +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Benjamin Kott +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 28
- Build/Sources/TypeScript/extensionmanager/dependency-check.tsnew+179 −0
- Build/Sources/TypeScript/extensionmanager/extension-toggle-button.ts4new+201 −0
- Build/Sources/TypeScript/extensionmanager/main.ts+1 −22
- Build/Sources/TypeScript/extensionmanager/repository.ts+1 −1
- typo3/sysext/core/Tests/Acceptance/Application/Extensionmanager/InstalledExtensionsCest.php+10 −1
- typo3/sysext/extensionmanager/Classes/Controller/AbstractController.php+0 −24
- typo3/sysext/extensionmanager/Classes/Controller/ActionController.php+67 −19
- typo3/sysext/extensionmanager/Classes/Controller/DistributionController.php+1 −0
- typo3/sysext/extensionmanager/Classes/Controller/DownloadController.php+83 −20
- typo3/sysext/extensionmanager/Classes/Controller/ListController.php+29 −35
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+5 −15
- typo3/sysext/extensionmanager/Classes/ViewHelpers/Be/TriggerViewHelper.phpdeleted+0 −76
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.phpdeleted+0 −100
- typo3/sysext/extensionmanager/Configuration/Backend/Modules.php+3 −3
- typo3/sysext/extensionmanager/Resources/Private/Language/locallang.xlf+17 −9
- typo3/sysext/extensionmanager/Resources/Private/Partials/List/Distribution.fluid.html3+7 −3
- typo3/sysext/extensionmanager/Resources/Private/Templates/Distribution/Show.fluid.html2+7 −8
- typo3/sysext/extensionmanager/Resources/Private/Templates/ExtensionComposerStatus/Detail.fluid.html+0 −3
- typo3/sysext/extensionmanager/Resources/Private/Templates/ExtensionComposerStatus/List.fluid.html+0 −3
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Distributions.fluid.html+6 −11
Show 8 more files
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Index.fluid.html+3 −3
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/ShowAllVersions.fluid.html+0 −2
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Ter.fluid.html+0 −3
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/UnresolvedDependencies.fluid.htmldeleted+0 −32
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/dependency-check.jsnew+13 −0
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/extension-toggle-button.jsnew+13 −0
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/main.js+2 −2
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/repository.js+2 −2
Review log 2130
Show 35 earlier messages
-
Oli Bartsch uploaded patch set 1 02/11/26, 09:10
-
core-ci voted on patch set 1 V -1 02/11/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95606
-
Josef Glatz commented on patch set 1 02/11/26, 11:58
@bo@cedev.de would be perfect if this patch does also reload the backend on installing ext:workspaces. -
Oli Bartsch uploaded patch set 2
V -102/12/26, 12:20 -
core-ci voted on patch set 2 V -1 02/12/26, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95711
-
Oli Bartsch uploaded patch set 3
V -102/12/26, 12:49 -
core-ci voted on patch set 3 V +1 02/12/26, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95719
-
Benjamin Kott commented on patch set 3 CR -1 02/12/26, 14:27
i think we can optimize the workflow here currently i am accepting that the backend is reloaded after installation, then i get a view to accept the dependencies, it should be the other way around, first warn then go. ideally i think we can merge these 2 views, and inform about dependency errors / inform about the reload -
Oli Bartsch uploaded patch set 4
CR -1V +102/12/26, 17:42 -
core-ci voted on patch set 4 V -1 02/12/26, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95761
-
core-ci voted on patch set 4 V +1 02/12/26, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95761
-
Oli Bartsch commented on patch set 4 02/12/26, 21:57
Reply
Done -
Benjamin Kott commented on patch set 4 CR -1 02/14/26, 07:49
extension-toggle-button.ts:142this is a problem, we are informing that the backend will reload when the user installs the extension, but extension is already installed when this happens. before the user hits activate no action should be taken, aside a preflight check for the dependencies. installation process etc should only be triggered when the user actually clicks activate. during that process we should inert the backend and show some kind of loading animation because the next step could take some time to complete. -
Oli Bartsch uploaded patch set 5
CR -1V +102/20/26, 09:19 -
Oli Bartsch commented on patch set 5 02/20/26, 09:19
extension-toggle-button.ts:142ReplyDone -
core-ci voted on patch set 5 V -1 02/20/26, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96320
-
Oli Bartsch uploaded patch set 6
V -102/20/26, 09:45 -
core-ci voted on patch set 6 V +1 02/20/26, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96328
-
Oli Bartsch uploaded patch set 7
V +102/20/26, 17:35 -
core-ci voted on patch set 7 V +1 02/20/26, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96393
-
Benni Mack commented on patch set 7 V -1 02/23/26, 19:38
extension-toggle-button.ts:125lll syntax is no more... the confirm dialog is now empty. -
Benni Mack commented on patch set 7 V 0 02/23/26, 19:42
Distribution.fluid.html:47this button does not contain "check-url" property, even though it is defined in the WC as string (I assume, it should be always there?) -
Benni Mack commented on patch set 7 02/23/26, 19:54
Show.fluid.html:35see the previous message. No "check-url" - is that OK? -
Oli Bartsch uploaded patch set 8
V +102/25/26, 10:52 -
Oli Bartsch commented on patch set 8 02/25/26, 10:58
extension-toggle-button.ts:125ReplyDoneDistribution.fluid.html:47ReplyDoneShow.fluid.html:35ReplyDone -
core-ci voted on patch set 8 V +1 02/25/26, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96812
-
Benjamin Kott commented on patch set 8 CR +1 V +1 02/25/26, 12:53
Distribution.fluid.html:47Replythe button does not show the installation state but it´s the same as before. should be addressed, with some cleanup in the extension manager later on. -
Benni Mack voted on patch set 8 CR +1 V +1 02/25/26, 13:13
-
Oli Bartsch voted on patch set 8 CR +2 V +2 02/25/26, 13:28
-
Oli Bartsch merged patch set 9 02/25/26, 13:28