Review main Merged

92793[BUGFIX] Reload backend after extension state changes

Oli Bartsch CR +2 V +2 Expert +650 −397 updated 02/25/26, 13:28

Commit message

After activating or deactivating extensions, the backend must
be fully reloaded. Otherwise global components like the
workspace selector display stale state, old JavaScript
continues to execute, and module links may stop working.

This patch replaces the old form-based navigation with an
AJAX-driven flow using a new `<typo3-extension-toggle-button>`
web component. Every state change now requires explicit user
confirmation via a modal before proceeding. On success, the
entire backend is reloaded.

When unresolved dependencies are detected during activation,
they are displayed inline in the modal using a new
`<typo3-extensionmanager-dependency-check>` web component,
with an option to skip the check. This replaces the previous
flow that navigated to a separate page, which lost context and
caused issues when forwarding to JSON-only actions.

The distribution install now reuses the same toggle button
component, giving users the same confirmation and reload
behavior. The `unresolvedDependencies` action and its template
have been removed since all dependency resolution is now
handled through the modal.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Kott +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Kott +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 28

Show 8 more files

Review log 2130

Show 35 earlier messages
  1. Oli Bartsch uploaded patch set 1 02/11/26, 09:10

  2. core-ci voted on patch set 1 V -1 02/11/26, 09:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95606

  3. Josef Glatz commented on patch set 1 02/11/26, 11:58

    @bo@cedev.de would be perfect if this patch does also reload the backend on installing ext:workspaces.
  4. Oli Bartsch uploaded patch set 2 V -1 02/12/26, 12:20

  5. core-ci voted on patch set 2 V -1 02/12/26, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95711

  1. Oli Bartsch uploaded patch set 3 V -1 02/12/26, 12:49

  2. core-ci voted on patch set 3 V +1 02/12/26, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95719

  3. Benjamin Kott commented on patch set 3 CR -1 02/12/26, 14:27

    i think we can optimize the workflow here currently i am accepting that the backend is reloaded after installation, then i get a view to accept the dependencies, it should be the other way around, first warn then go. ideally i think we can merge these 2 views, and inform about dependency errors / inform about the reload
  4. Oli Bartsch uploaded patch set 4 CR -1 V +1 02/12/26, 17:42

  5. core-ci voted on patch set 4 V -1 02/12/26, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95761

  6. core-ci voted on patch set 4 V +1 02/12/26, 21:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95761

  7. Oli Bartsch commented on patch set 4 02/12/26, 21:57

    Reply

    Done
  8. Benjamin Kott commented on patch set 4 CR -1 02/14/26, 07:49

    extension-toggle-button.ts:142

    this is a problem, we are informing that the backend will reload when the user installs the extension, but extension is already installed when this happens. before the user hits activate no action should be taken, aside a preflight check for the dependencies. installation process etc should only be triggered when the user actually clicks activate. during that process we should inert the backend and show some kind of loading animation because the next step could take some time to complete.
  9. Oli Bartsch uploaded patch set 5 CR -1 V +1 02/20/26, 09:19

  10. Oli Bartsch commented on patch set 5 02/20/26, 09:19

    extension-toggle-button.ts:142 Reply

    Done
  11. core-ci voted on patch set 5 V -1 02/20/26, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96320

  12. Oli Bartsch uploaded patch set 6 V -1 02/20/26, 09:45

  13. core-ci voted on patch set 6 V +1 02/20/26, 09:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96328

  14. Oli Bartsch uploaded patch set 7 V +1 02/20/26, 17:35

  15. core-ci voted on patch set 7 V +1 02/20/26, 18:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96393

  16. Benni Mack commented on patch set 7 V -1 02/23/26, 19:38

    extension-toggle-button.ts:125

    lll syntax is no more... the confirm dialog is now empty.
  17. Benni Mack commented on patch set 7 V 0 02/23/26, 19:42

    Distribution.fluid.html:47

    this button does not contain "check-url" property, even though it is defined in the WC as string (I assume, it should be always there?)
  18. Benni Mack commented on patch set 7 02/23/26, 19:54

    Show.fluid.html:35

    see the previous message. No "check-url" - is that OK?
  19. Oli Bartsch uploaded patch set 8 V +1 02/25/26, 10:52

  20. Oli Bartsch commented on patch set 8 02/25/26, 10:58

    extension-toggle-button.ts:125 Reply

    Done

    Distribution.fluid.html:47 Reply

    Done

    Show.fluid.html:35 Reply

    Done
  21. core-ci voted on patch set 8 V +1 02/25/26, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96812

  22. Benjamin Kott commented on patch set 8 CR +1 V +1 02/25/26, 12:53

    Distribution.fluid.html:47 Reply

    the button does not show the installation state but it´s the same as before. should be addressed, with some cleanup in the extension manager later on.
  23. Benni Mack voted on patch set 8 CR +1 V +1 02/25/26, 13:13

  24. Oli Bartsch voted on patch set 8 CR +2 V +2 02/25/26, 13:28

  25. Oli Bartsch merged patch set 9 02/25/26, 13:28