92794[TASK] Remove redundant type checks proven safe by native PHP types
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 22
- Build/phpstan/phpstan-baseline.neon+0 −138
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+1 −1
- typo3/sysext/backend/Classes/Controller/ContextMenuController.php+0 −3
- typo3/sysext/backend/Classes/Form/Element/SelectSingleElement.php+7 −9
- typo3/sysext/backend/Classes/Form/FieldWizard/SelectIcons.php+3 −5
- typo3/sysext/backend/Classes/Template/Components/MetaInformation.php+2 −2
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+6 −10
- typo3/sysext/core/Classes/Configuration/Processor/Placeholder/EnvVariableProcessor.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/AbstractArgon2PasswordHash.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/BcryptPasswordHash.php+1 −1
- typo3/sysext/core/Classes/Crypto/PasswordHashing/BlowfishPasswordHash.php2+2 −2
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+4 −8
- typo3/sysext/core/Classes/Database/Query/QueryBuilder.php+5 −5
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+0 −6
- typo3/sysext/core/Classes/Database/ConnectionPool.php+1 −2
- typo3/sysext/core/Classes/Error/PageErrorHandler/PageContentErrorHandler.php+0 −4
- typo3/sysext/core/Classes/Error/DebugExceptionHandler.php+1 −4
- typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php+1 −4
- typo3/sysext/core/Classes/EventDispatcher/ListenerProvider.php+2 −2
- typo3/sysext/core/Classes/Log/Writer/SyslogWriter.php+1 −4
Review log 1013
-
Benni Mack uploaded patch set 1 02/11/26, 14:00
-
core-ci voted on patch set 1 V -1 02/11/26, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95623
-
Benni Mack uploaded patch set 2
V -102/11/26, 14:47 -
Benni Mack marked it ready for review 02/11/26, 14:47
-
Oliver Klee commented on patch set 2 V +1 02/11/26, 14:53
-
Benni Mack commented on patch set 3
V +102/11/26, 14:54Published edit on patch set 2. -
Benni Mack commented on patch set 3 02/11/26, 14:55
BlowfishPasswordHash.php:172ReplyDone -
core-ci voted on patch set 2 V +1 02/11/26, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95627
-
Oliver Klee voted on patch set 3 CR +1 V +1 02/11/26, 14:56
-
core-ci voted on patch set 3 V +1 02/11/26, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95629
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 02/11/26, 15:04
-
Benni Mack voted on patch set 3 CR +2 V +2 02/11/26, 15:29
-
Benni Mack merged patch set 4 02/11/26, 15:29
BlowfishPasswordHash.php:172