92796[FEATURE] Support username and password in Redis session backend
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Anja Leichsenring +1
- Josua Vogel +1
-
Verified V +2 Done
- Benni Mack +2
- Anja Leichsenring +1
- Josua Vogel +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/core/Classes/Cache/Backend/RedisBackend.php+1 −1
- typo3/sysext/core/Classes/Session/Backend/RedisSessionBackend.php3+23 −5
- typo3/sysext/core/Documentation/Changelog/14.2/Deprecation-107802-DeprecateUsageOfArrayInPasswordForAuthenticationInRedisSessionBackend.rstnew+91 −0
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-107802-SupportUsernameAndPasswordInRedisSessionBackend.rstnew+41 −0
Review log 1316
-
Sven Liebert uploaded patch set 1 02/11/26, 16:43
-
Josef Glatz commented on patch set 1 02/11/26, 16:47
@mail@sven-liebert.de I'm confused: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/14.0/Feature-107725-RedisCacheBackendAuthenticationWithUsernameAndPassword.html#feature-107725-support-username-for-authentication-in-redis-cache-backend there is already support for it? -
Josef Glatz updated the commit message in patch set 2 02/11/26, 16:48
-
Sven Liebert commented on patch set 2 02/11/26, 16:50
Reply
Cache backend isn't the same as session backend. The mentioned feature is only for caching. -
core-ci voted on patch set 1 V +1 02/11/26, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95638
-
core-ci voted on patch set 2 V +1 02/11/26, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95639
-
Josef Glatz commented on patch set 2 02/11/26, 17:37
😅 ok sorry for the noise -
Anja Leichsenring commented on patch set 2 02/11/26, 19:18
RedisSessionBackend.php:260should this message not be generalized to support both cases, username and password or password alone? Something along the lines of 'credentials for authitcation were not accepted.' ? -
Josua Vogel commented on patch set 2 02/12/26, 06:41
RedisSessionBackend.php:260ReplyI think a general message such as “Authentication to Redis failed” should suffice. Please also adjust this as a drive-by in the cache backend; here, too, only the password is explicitly mentioned. -
Sven Liebert uploaded patch set 3
V +102/12/26, 18:04 -
Sven Liebert commented on patch set 3 02/12/26, 18:04
RedisSessionBackend.php:260ReplyDone -
Josua Vogel voted on patch set 3 CR +1 V +1 02/12/26, 18:12
-
core-ci voted on patch set 3 V +1 02/12/26, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95762
-
Anja Leichsenring voted on patch set 3 CR +1 V +1 02/12/26, 19:44
-
Benni Mack voted on patch set 3 CR +2 V +2 02/13/26, 09:32
-
Benni Mack merged patch set 4 02/13/26, 09:32