Review main Merged

92796[FEATURE] Support username and password in Redis session backend

Sven Liebert CR +2 V +2 Normal +156 −6 updated 02/13/26, 09:32

Commit message

Starting with redis 6.0 authentication with `username & password` tuple
is supported, which was not reflected directly as configuration for the
`RedisSessionBackend` of TYPO3.

This change provides now official support to configure `username` and
`password` for the redis connection of the cache backend while keeping
the workaround to configure an array as `password`, which is deprecated
now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1316

  1. Sven Liebert uploaded patch set 1 02/11/26, 16:43

  2. Josef Glatz updated the commit message in patch set 2 02/11/26, 16:48

  3. Sven Liebert commented on patch set 2 02/11/26, 16:50

    Reply

    Cache backend isn't the same as session backend. The mentioned feature is only for caching.
  4. core-ci voted on patch set 1 V +1 02/11/26, 16:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95638

  5. core-ci voted on patch set 2 V +1 02/11/26, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95639

  6. Josef Glatz commented on patch set 2 02/11/26, 17:37

    😅 ok sorry for the noise
  7. Anja Leichsenring commented on patch set 2 02/11/26, 19:18

    RedisSessionBackend.php:260

    should this message not be generalized to support both cases, username and password or password alone? Something along the lines of 'credentials for authitcation were not accepted.' ?
  8. Josua Vogel commented on patch set 2 02/12/26, 06:41

    RedisSessionBackend.php:260 Reply

    I think a general message such as “Authentication to Redis failed” should suffice. Please also adjust this as a drive-by in the cache backend; here, too, only the password is explicitly mentioned.
  9. Sven Liebert uploaded patch set 3 V +1 02/12/26, 18:04

  10. Sven Liebert commented on patch set 3 02/12/26, 18:04

    RedisSessionBackend.php:260 Reply

    Done
  11. Josua Vogel voted on patch set 3 CR +1 V +1 02/12/26, 18:12

  12. core-ci voted on patch set 3 V +1 02/12/26, 18:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95762

  13. Anja Leichsenring voted on patch set 3 CR +1 V +1 02/12/26, 19:44

  14. Benni Mack voted on patch set 3 CR +2 V +2 02/13/26, 09:32

  15. Benni Mack merged patch set 4 02/13/26, 09:32