Review main Merged

92798[TASK] Resolve PHPStan baseline entries for trivial type issues

Benni Mack CR +2 V +2 Hard +101 −450 updated 02/12/26, 13:26

Commit message

Remove superfluous array_values() calls on parameters that are
already lists, fix incorrect return types and PHPDoc annotations,
and remove @var tags that contradict native types.

This resolves many PHPStan baseline entries across the categories
- arrayValues.list
- return.type
- return.unusedType
- varTag.nativeType
- phpDoc.parseError

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 30

Show 10 more files

Review log 1424

  1. Benni Mack uploaded patch set 1 02/11/26, 18:11

  2. core-ci voted on patch set 1 V -1 02/11/26, 18:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95642

  3. core-ci commented on patch set 1 02/11/26, 19:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95642

  4. Benni Mack uploaded patch set 2 V -1 02/11/26, 19:32

  5. core-ci voted on patch set 2 V -1 02/11/26, 19:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95646

  6. Benni Mack uploaded patch set 3 V -1 02/11/26, 20:42

  7. core-ci voted on patch set 3 V -1 02/11/26, 21:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95656

  8. Benni Mack commented on patch set 4 V -1 02/12/26, 08:50

    Published edit on patch set 3.
  9. core-ci voted on patch set 4 V -1 02/12/26, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95696

  10. Benni Mack commented on patch set 5 V -1 02/12/26, 09:58

    Published edit on patch set 4.
  11. core-ci voted on patch set 5 V -1 02/12/26, 10:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95701

  12. Benni Mack commented on patch set 6 V -1 02/12/26, 10:54

    Published edit on patch set 5.
  13. core-ci voted on patch set 6 V -1 02/12/26, 11:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95703

  14. Benni Mack uploaded patch set 7 V -1 02/12/26, 11:52

  15. Benni Mack commented on patch set 8 02/12/26, 12:20

    Published edit on patch set 7.
  16. Benni Mack commented on patch set 9 02/12/26, 12:20

    Published edit on patch set 8.
  17. core-ci voted on patch set 7 V +1 02/12/26, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95707

  18. core-ci voted on patch set 9 V +1 02/12/26, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95712

  19. Oliver Klee voted on patch set 9 V +1 02/12/26, 12:40

  20. Oliver Klee voted on patch set 9 CR +1 02/12/26, 12:42

  21. Anja Leichsenring voted on patch set 9 CR +1 V +1 02/12/26, 13:15

  22. core-ci voted on patch set 8 V -1 02/12/26, 13:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95709

  23. Benni Mack voted on patch set 9 CR +2 V +2 02/12/26, 13:26

  24. Benni Mack merged patch set 10 02/12/26, 13:26