Review main Merged

92804[BUGFIX] Fix removeSysRedirectPermission wiping user permissions

Oli Bartsch CR +2 V +2 Normal +135 −2 updated 02/12/26, 11:40

Commit message

removeSysRedirectPermission() received the groupData
key name (e.g. "tables_select") but treated it as the
literal permission string instead of looking up the
actual value from $GLOBALS['BE_USER']->groupData.

This caused all existing table permissions to be
replaced with the key name string whenever a
temporarily added sys_redirect permission was
removed. This is fixed now and covered by tests.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Bastien Lutz +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Bastien Lutz +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Oli Bartsch uploaded patch set 1 02/11/26, 22:52

  2. core-ci voted on patch set 1 V +1 02/11/26, 23:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95661

  3. Garvin Hicking voted on patch set 1 CR +1 02/12/26, 05:48

  4. Bastien Lutz voted on patch set 1 CR +1 V +1 02/12/26, 08:08

  5. Garvin Hicking voted on patch set 1 V +1 02/12/26, 11:39

  6. Oli Bartsch voted on patch set 1 CR +2 V +2 02/12/26, 11:40

  7. Oli Bartsch merged patch set 2 02/12/26, 11:40