Review 12.4 Merged

92809[TASK] Update PHPStan to v2.1.39

Garvin Hicking CR +2 V +2 Easy +7 −13 updated 02/12/26, 08:42

Commit message

Updates PHPStan to the latest version 2.1.39 and regenerates the
baseline. Since the relevant `is_array` check is actually superfluous,
it is removed. In addition, global functions used in functional tests
are added to PHPStan's bootstrap files in order to make PHPStan aware of
the available functions.

Executed commands:

> Build/Scripts/runTests.sh -s composer -- \
      require --dev phpstan/phpstan:^2.1.39
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 69

  1. Garvin Hicking commented on patch set 1 02/12/26, 07:06

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/phpstan/phpstan-baseline.neon * composer.json * composer.lock * typo3/sysext/impexp/Classes/Import.php
  2. core-ci voted on patch set 1 V -1 02/12/26, 07:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95687

  3. Garvin Hicking uploaded patch set 2 V -1 02/12/26, 08:32

  4. Garvin Hicking uploaded patch set 3 02/12/26, 08:35

  5. Garvin Hicking marked it ready for review 02/12/26, 08:35

  6. core-ci voted on patch set 2 V -1 02/12/26, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95694

  7. core-ci voted on patch set 3 V +1 02/12/26, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95695

  8. Garvin Hicking voted on patch set 3 CR +2 V +2 02/12/26, 08:42

  9. Garvin Hicking merged patch set 4 02/12/26, 08:42