92813[TASK] Migrate Property to TypeInfo via TypeAdapter
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Anja Leichsenring +1
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Anja Leichsenring +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/Property.php+86 −14
- typo3/sysext/extbase/Classes/Reflection/ClassSchema/TypeAdapter.phpnew+120 −0
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+8 −5
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/Property/PropertyWithoutTypeDeclarationsTest.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/Property/PropertyWithTypeDeclarationsTest.php+7 −7
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchema/PropertyTest.php+24 −6
Review log 1621
-
Oliver Hader uploaded patch set 1 02/12/26, 11:27
-
core-ci voted on patch set 1 V +1 02/12/26, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95704
-
Oliver Hader uploaded patch set 2
V +102/12/26, 12:38 -
Oliver Hader commented on patch set 2 02/12/26, 12:39
This change is ready for review. -
Oliver Hader updated the commit message in patch set 3 02/12/26, 12:41
-
Benni Mack commented on patch set 3 02/12/26, 12:58
should we add this to 13.4 as well? -
core-ci voted on patch set 3 V -1 02/12/26, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95716
-
Oliver Hader updated the commit message in patch set 4
V -102/12/26, 13:28 -
Oliver Hader commented on patch set 4 02/12/26, 13:30
Reply
By using the `TypeAdapter` it should be doable. However, any user-land code that relied directly on `Symfony\Component\PropertyInfo\Type` would break. -
core-ci voted on patch set 4 V +1 02/12/26, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95729
-
Oliver Hader rebased onto patch set 5
V +102/12/26, 16:32 -
core-ci voted on patch set 5 V +1 02/12/26, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95752
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 02/12/26, 19:30
-
Benni Mack commented on patch set 5 CR +1 V +1 02/12/26, 20:32
Reply
Done -
Oliver Hader uploaded patch set 6
CR +1V +102/12/26, 21:12 -
Oliver Hader commented on patch set 6 02/12/26, 21:12
I've added some more tests -
core-ci voted on patch set 6 V +1 02/12/26, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95779
-
Benni Mack voted on patch set 6 CR +1 V +1 02/13/26, 08:11
-
Anja Leichsenring voted on patch set 6 CR +1 V +1 02/13/26, 08:12
-
Oliver Hader commented on patch set 6 CR +2 V +2 02/13/26, 08:17
Thx folks 😊 -
Oliver Hader merged patch set 7 02/13/26, 08:18