Review main Merged

92813[TASK] Migrate Property to TypeInfo via TypeAdapter

Oliver Hader CR +2 V +2 Hard +250 −37 updated 02/13/26, 08:18

Commit message

Symfony deprecated PropertyInfoExtractor::getTypes()
(returning PropertyInfo\Type[]) in favour of getType()
(returning a single TypeInfo\Type) with version 7.3.
see https://github.com/symfony/symfony/pull/59902

The old PropertyInfo\Type class will be removed in a
future Symfony release, so the extbase reflection layer
needs to stop depending on it.

The TypeAdapter is introduced, wrapping TypeInfo\Type
with the deprecated PropertyInfo\Type API so consumers
of ClassSchema\Property need no immediate changes.

* ClassSchema calls getType() (singular) now
* Property returns LegacyType from public methods
* getTypes() decomposes Nullable/Union/Intersection
* ValidatorResolver instanceof uses TypeAdapter
* Tests adjusted for TypeInfo alphabetical ordering

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Anja Leichsenring +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1621

  1. Oliver Hader uploaded patch set 1 02/12/26, 11:27

  2. core-ci voted on patch set 1 V +1 02/12/26, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95704

  3. Oliver Hader uploaded patch set 2 V +1 02/12/26, 12:38

  4. Oliver Hader commented on patch set 2 02/12/26, 12:39

    This change is ready for review.
  5. Oliver Hader updated the commit message in patch set 3 02/12/26, 12:41

  6. Benni Mack commented on patch set 3 02/12/26, 12:58

    should we add this to 13.4 as well?
  7. core-ci voted on patch set 3 V -1 02/12/26, 13:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95716

  8. Oliver Hader updated the commit message in patch set 4 V -1 02/12/26, 13:28

  9. Oliver Hader commented on patch set 4 02/12/26, 13:30

    Reply

    By using the `TypeAdapter` it should be doable. However, any user-land code that relied directly on `Symfony\Component\PropertyInfo\Type` would break.
  10. core-ci voted on patch set 4 V +1 02/12/26, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95729

  11. Oliver Hader rebased onto patch set 5 V +1 02/12/26, 16:32

  12. core-ci voted on patch set 5 V +1 02/12/26, 17:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95752

  13. Anja Leichsenring voted on patch set 5 CR +1 V +1 02/12/26, 19:30

  14. Benni Mack commented on patch set 5 CR +1 V +1 02/12/26, 20:32

    Reply

    Done
  15. Oliver Hader uploaded patch set 6 CR +1 V +1 02/12/26, 21:12

  16. Oliver Hader commented on patch set 6 02/12/26, 21:12

    I've added some more tests
  17. core-ci voted on patch set 6 V +1 02/12/26, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95779

  18. Benni Mack voted on patch set 6 CR +1 V +1 02/13/26, 08:11

  19. Anja Leichsenring voted on patch set 6 CR +1 V +1 02/13/26, 08:12

  20. Oliver Hader commented on patch set 6 CR +2 V +2 02/13/26, 08:17

    Thx folks 😊
  21. Oliver Hader merged patch set 7 02/13/26, 08:18