Review main Merged

92815[TASK] Migrate bookmark modules to use JavaScript label modules

Benjamin Franzke CR +2 V +2 Normal +124 −124 updated 02/17/26, 18:12

Commit message

Use JavaScript label modules as introduced in #108941 instead
of adding the "core.bookmarks" language domain to TYPO3.lang.

The label availability check that has been added with #108941
found a typo in bookmark-store.ts along the way, which
is now fixed.

Commands executed:
  git grep -l "lll('core.bookmarks:" | xargs sed -i \
    "s/lll('core.bookmarks:/labels.get('/g"

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 11

Review log 1017

  1. Benjamin Franzke uploaded patch set 1 02/12/26, 12:37

  2. Benjamin Franzke rebased onto patch set 2 02/12/26, 12:41

  3. Benjamin Franzke rebased onto patch set 3 02/12/26, 12:54

  4. core-ci voted on patch set 1 V +1 02/12/26, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95714

  5. Benjamin Franzke uploaded patch set 4 02/12/26, 13:04

  6. core-ci voted on patch set 4 V +1 02/12/26, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95725

  7. core-ci voted on patch set 2 V +1 02/12/26, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95718

  8. core-ci voted on patch set 3 V +1 02/12/26, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95722

  9. Benjamin Franzke rebased onto patch set 5 V +1 02/12/26, 13:52

  10. core-ci voted on patch set 5 V -1 02/12/26, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95740

  11. core-ci commented on patch set 5 02/12/26, 14:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95740

  12. core-ci voted on patch set 5 V +1 02/12/26, 14:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95740

  13. Anja Leichsenring voted on patch set 5 CR +1 V +1 02/12/26, 19:43

  14. Benjamin Kott voted on patch set 5 CR +1 V +1 02/17/26, 11:42

  15. Benjamin Franzke voted on patch set 5 CR +2 V +2 02/17/26, 11:45

  16. Benjamin Franzke merged patch set 6 02/17/26, 11:45

  17. Benjamin Franzke wrote 02/17/26, 18:12

    Hashtag added: labels