Review main Merged

92817[TASK] Deprecate `PageRenderer->addInlineLanguageDomain()`

Benjamin Franzke CR +2 V +2 Normal +79 −0 updated 02/17/26, 11:48

Commit message

Deprecate `PageRenderer->addInlineLanguageDomain()` which was
added in #108627 (v14.1) but has been superseded by #108941.

Its sole usage in the bookmarks module has been removed
in #108941.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 79

  1. Benjamin Franzke uploaded patch set 1 02/12/26, 12:54

  2. Benjamin Franzke commented on patch set 1 02/12/26, 13:17

    Shit, this got already merged into 14.1 😞 I fear we should not revert?
  3. core-ci voted on patch set 1 V -1 02/12/26, 13:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95723

  4. Benjamin Franzke uploaded patch set 2 V -1 02/12/26, 14:56

  5. core-ci voted on patch set 2 V +1 02/12/26, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95743

  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/12/26, 19:33

  7. Benjamin Kott voted on patch set 2 CR +1 V +1 02/17/26, 11:42

  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 02/17/26, 11:47

  9. Benjamin Franzke merged patch set 3 02/17/26, 11:48