92819[TASK] Replace $GLOBALS['TCA'] with schema api in formengine
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 29
- typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php+10 −6
- typo3/sysext/backend/Classes/Form/Container/FilesControlContainer.php+5 −1
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+6 −2
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+13 −8
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+5 −2
- typo3/sysext/backend/Classes/Form/Element/LinkElement.php+4 −1
- typo3/sysext/backend/Classes/Form/FieldControl/AddRecord.php+4 −2
- typo3/sysext/backend/Classes/Form/FieldControl/ListModule.php+4 −2
- typo3/sysext/backend/Classes/Form/FieldWizard/TableList.php+4 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+5 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseDefaultLanguagePageRow.php3+12 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/InitializeProcessedTca.php+68 −11
- typo3/sysext/backend/Classes/Form/FormDataProvider/SiteTcaInline.php+7 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFiles.php+22 −5
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInline.php+6 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInlineConfiguration.php+10 −5
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+12 −5
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSiteLanguage.php+9 −6
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaTablePermission.php+4 −1
- typo3/sysext/backend/Classes/Form/InlineStackProcessor.php+12 −1
Show 9 more files
- typo3/sysext/backend/Tests/Functional/Controller/FormInlineAjaxControllerTest.php+2 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaSelectItemsTest.php+2 −0
- typo3/sysext/backend/Tests/Functional/Form/InlineStackProcessorTest.php+4 −3
- typo3/sysext/backend/Tests/Unit/Form/FieldWizard/TableListTest.php+2 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseDefaultLanguagePageRowTest.php+20 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/InitializeProcessedTcaTest.php+37 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaInlineConfigurationTest.php+39 −19
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaTablePermissionTest.php+23 −3
- typo3/sysext/core/Classes/Schema/TcaSchemaFactory.php+6 −0
Review log 3560
Show 2235 earlier messages
-
Bastien Lutz uploaded patch set 1 02/12/26, 13:23
-
Benni Mack commented on patch set 1 02/12/26, 13:27
don't want to spoil the fun, but this won't work due to a super-hacky usage of FormEngine and $GLOBALS[TCA] in SiteConfigurationController... -
core-ci voted on patch set 1 V -1 02/12/26, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95728
-
Bastien Lutz uploaded patch set 2
V -102/12/26, 15:17 -
core-ci voted on patch set 2 V -1 02/12/26, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95744
-
Bastien Lutz uploaded patch set 3
V -102/13/26, 10:31 -
core-ci voted on patch set 3 V -1 02/13/26, 11:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95823
-
Bastien Lutz rebased onto patch set 4
V -102/17/26, 07:38 -
core-ci voted on patch set 4 V -1 02/17/26, 07:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96015
-
Bastien Lutz commented on patch set 4 02/17/26, 08:08
Reply
Is there any reason to not use TcaSchemaFactory->load() in this specific case? -
Bastien Lutz uploaded patch set 5
V -102/17/26, 09:00 -
core-ci voted on patch set 5 V -1 02/17/26, 09:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96018
-
Tobias Wojtylak commented on patch set 5 02/18/26, 10:21
DatabaseDefaultLanguagePageRow.php:41Just out of interest: doesn't a `$this->tcaSchemaFactory->load($GLOBALS['TCA'], true);` also need to be executed beforehand like in the SiteConfiguration Controller? Or in other words, when does this need to be executed? -
Bastien Lutz commented on patch set 5 02/18/26, 11:02
DatabaseDefaultLanguagePageRow.php:41ReplyThis is called in the BootService.php (at the beginning of the request) to initialize the schema api. Usually this must not be called at all except for testing purposes. As the schema API is immutable and should not be modified by adjusting $GLOBALS['TCA'] in the runtime. The SiteConfigurationController fakes the TCA in order to display an edit form using the Formengine. Using this there is just an idea on how to tackle the issue that the TCA is faked there. But i'm not sure yet if we will leave it as at is.DatabaseDefaultLanguagePageRow.php:41ReplyThis is initially done in the BootService.php (start of the request) to setup the schema api. Usually this method must not be called except for testing purposes. The SiteConfigurationController is an edge case. The TCA is faked there to use the formengine to edit sites. Using ->load() in the SiteConfigurationController is only an approach to tackle this. -
Bastien Lutz rebased onto patch set 6
V -102/18/26, 15:35 -
core-ci voted on patch set 6 V -1 02/18/26, 15:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96165
-
Bastien Lutz uploaded patch set 7
V -102/19/26, 09:20 -
core-ci voted on patch set 7 V -1 02/19/26, 09:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96222
-
Bastien Lutz rebased onto patch set 8
V -102/19/26, 10:25The following files contain Git conflicts: * typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php -
Bastien Lutz uploaded patch set 9 02/19/26, 10:27
-
core-ci voted on patch set 9 V -1 02/19/26, 10:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96229
-
core-ci voted on patch set 8 V -1 02/19/26, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96228
-
Bastien Lutz rebased onto patch set 10
V -102/19/26, 13:43 -
core-ci voted on patch set 10 V -1 02/19/26, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96249
-
Bastien Lutz uploaded patch set 11 02/19/26, 13:55
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 11 V +1 02/19/26, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96250
-
Bastien Lutz marked it ready for review 02/19/26, 14:08
-
Bastien Lutz commented on patch set 11 02/20/26, 07:29
Reply
Done -
Oli Bartsch commented on patch set 11 V -1 02/20/26, 08:10
Reply
Not in this state but we "just" need to migrate Site Config in this regard.Could you please explain the scope here? grepping for `GLOBALS['TCA']` still yields around 20 results in FormEngine. -
Oli Bartsch commented on patch set 11 02/20/26, 08:12
Reply
Three of them in `InitializeProcessedTca` -
Bastien Lutz commented on patch set 11 02/20/26, 13:42
Reply
The scope of this patch was to remove $GLOBALS['TCA'] from the dataproviders. But i think you are right it should be removed from other places in the formengine too in this patch. I'll adjust this. InitializeProcessedTca is kind of tricky. As especially ['processedTCA']['columns'] expects the old fashioned TCA syntax containing the config sub-array. I'll take a further look if this can be tackled by the RenderingInstructions provided in https://review.typo3.org/c/Packages/TYPO3.CMS/+/92838 -
Bastien Lutz uploaded patch set 12
V +102/20/26, 15:36 -
core-ci voted on patch set 12 V -1 02/20/26, 15:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96375
-
Bastien Lutz uploaded patch set 13
V -102/20/26, 15:52 -
core-ci voted on patch set 13 V -1 02/20/26, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96379
-
core-ci commented on patch set 13 02/20/26, 22:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96379
-
core-ci commented on patch set 13 02/20/26, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96379
-
Bastien Lutz rebased onto patch set 14
V -102/23/26, 08:54 -
core-ci voted on patch set 14 V +1 02/23/26, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96546
-
Bastien Lutz uploaded patch set 15
V +102/23/26, 12:49 -
core-ci voted on patch set 15 V -1 02/23/26, 13:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96574
-
Bastien Lutz uploaded patch set 16
V -102/23/26, 14:21 -
core-ci voted on patch set 16 V +1 02/23/26, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96585
-
Bastien Lutz commented on patch set 16 02/23/26, 14:38
Reply
Done -
Bastien Lutz rebased onto patch set 17
V +102/24/26, 12:22 -
Bastien Lutz uploaded patch set 18 02/24/26, 12:24
-
core-ci voted on patch set 18 V -1 02/24/26, 13:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96727
-
Bastien Lutz uploaded patch set 19
V -102/24/26, 13:17 -
core-ci voted on patch set 17 V -1 02/24/26, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96726
-
core-ci voted on patch set 19 V -1 02/24/26, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96739
-
Bastien Lutz rebased onto patch set 20
V -102/24/26, 13:49 -
Bastien Lutz rebased onto patch set 21 02/24/26, 13:53
-
core-ci voted on patch set 21 V -1 02/24/26, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96746
-
Bastien Lutz rebased onto patch set 22
V -102/24/26, 14:54 -
core-ci voted on patch set 20 V -1 02/24/26, 14:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96743
-
core-ci voted on patch set 22 V -1 02/24/26, 15:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96756
-
Bastien Lutz rebased onto patch set 23
V -102/25/26, 09:02 -
core-ci voted on patch set 23 V +1 02/25/26, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96802
-
Christian Kuhn commented on patch set 23 03/03/26, 13:40
i would tend to bind the initialized schema to $data instead of injecting the service to single consumers. this allows 'preparing' the structure exactly once within controllers that work with 'fake tca' (like site) and would allow getting rid of all left over globals-tca calls within formEngine *plus* removes the need to set 'fake tca' as globals-tca once and for all. i'm open for a chat here since i also had a rough look at the 'get rid of processedTca' patch along the way: i think we should do this patch here first, then have a second look at the processedTca approach. -
Bastien Lutz abandoned the change 03/17/26, 10:45
Tackled this in another way/patch: 93145: [TASK] Add tca schema as state to formengine $result array | https://review.typo3.org/c/Packages/TYPO3.CMS/+/93145