Review main Merged

92821[TASK] Extract generic wizard component from LocalizationWizard for reuse

Tobias Wojtylak CR +2 V +2 Expert +1273 −970 updated 02/20/26, 16:22

Commit message

Extract a generic wizard base implementation from the LocalizationWizard
to enable reuse by other wizards. The new component allows steps and the
submissionService to be passed from the outside, while keeping the
"Confirm" and "Finish" steps fixed.

The reusable wizard base is now available for other use cases, and the
LocalizationWizard has been simplified and reduced to its specific
functionality.

Generic wizard translations were moved to `Wizards/general.xlf`, and
language labels are now used via virtual JavaScript
modules (introduced in #108941).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 51

Show 31 more files

Review log 5385

Show 3460 earlier messages
  1. Tobias Wojtylak uploaded patch set 1 02/12/26, 13:41

  2. Tobias Wojtylak updated the commit message in patch set 2 02/12/26, 13:43

  3. core-ci voted on patch set 1 V +1 02/12/26, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95734

  4. core-ci voted on patch set 2 V +1 02/12/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95735

  5. Benjamin Kott commented on patch set 2 CR -1 02/12/26, 14:51

    finisher-step.ts:39

    we need to take a deeper look here on the finishing side, we are also returning LocalizationFinisherInterface that should be part of the wizard itself.

    mode-step.ts:24

    not sure but we usually do not break the lines here
  6. Tobias Wojtylak commented on patch set 2 02/12/26, 15:15

    finisher-step.ts:39 Reply

    I would suggest doing that in the next iteration.

    mode-step.ts:24 Reply

    Then we should probably adjust the linter config.
  7. Tobias Wojtylak commented on patch set 2 02/16/26, 08:02

  8. Benjamin Kott commented on patch set 2 02/16/26, 14:16

    mode-step.ts:24 Reply

    Acknowledged
  9. Tobias Wojtylak uploaded patch set 3 CR -1 V +1 02/16/26, 14:29

  10. core-ci voted on patch set 3 V -1 02/16/26, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95966

  11. Tobias Wojtylak uploaded patch set 4 V -1 02/16/26, 14:48

  12. Tobias Wojtylak uploaded patch set 5 02/16/26, 14:55

  13. core-ci voted on patch set 4 V -1 02/16/26, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95968

  14. Tobias Wojtylak uploaded patch set 6 02/16/26, 15:11

  15. core-ci voted on patch set 6 V -1 02/16/26, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95973

  16. Tobias Wojtylak uploaded patch set 7 V -1 02/16/26, 15:30

  17. core-ci voted on patch set 5 V -1 02/16/26, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95970

  18. core-ci voted on patch set 7 V -1 02/16/26, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95974

  19. Tobias Wojtylak uploaded patch set 8 V -1 02/16/26, 15:50

  20. core-ci voted on patch set 8 V +1 02/16/26, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95978

  21. Tobias Wojtylak uploaded patch set 9 V +1 02/17/26, 08:14

  22. core-ci voted on patch set 9 V +1 02/17/26, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96016

  23. Tobias Wojtylak commented on patch set 9 02/17/26, 08:43

    finisher-step.ts:39 Reply

    Done
  24. Tobias Wojtylak uploaded patch set 10 V +1 02/17/26, 10:39

  25. Tobias Wojtylak uploaded patch set 11 02/17/26, 10:51

  26. Tobias Wojtylak uploaded patch set 12 02/17/26, 10:59

  27. core-ci voted on patch set 11 V -1 02/17/26, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96028

  28. Tobias Wojtylak uploaded patch set 13 02/17/26, 11:03

  29. Tobias Wojtylak uploaded patch set 14 02/17/26, 11:09

  30. Tobias Wojtylak uploaded patch set 15 02/17/26, 11:13

  31. core-ci voted on patch set 13 V -1 02/17/26, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96030

  32. Tobias Wojtylak uploaded patch set 16 02/17/26, 11:17

  33. core-ci voted on patch set 14 V -1 02/17/26, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96031

  34. core-ci voted on patch set 10 V -1 02/17/26, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96026

  35. core-ci voted on patch set 16 V -1 02/17/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96033

  36. core-ci voted on patch set 12 V -1 02/17/26, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96029

  37. Tobias Wojtylak uploaded patch set 17 V -1 02/17/26, 11:42

  38. core-ci voted on patch set 15 V -1 02/17/26, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96032

  39. core-ci voted on patch set 17 V -1 02/17/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96037

  40. Tobias Wojtylak uploaded patch set 18 V -1 02/17/26, 11:57

  41. core-ci voted on patch set 18 V +1 02/17/26, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96038

  42. Tobias Wojtylak updated the commit message in patch set 19 V +1 02/17/26, 13:17

  43. Tobias Wojtylak updated the commit message in patch set 20 02/17/26, 13:21

  44. Tobias Wojtylak updated the commit message in patch set 21 02/17/26, 13:22

  45. core-ci voted on patch set 21 V +1 02/17/26, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96055

  46. Tobias Wojtylak rebased onto patch set 22 V +1 02/18/26, 10:06

  47. core-ci voted on patch set 22 V -1 02/18/26, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96115

  48. core-ci voted on patch set 22 V +1 02/18/26, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96115

  49. Tobias Wojtylak uploaded patch set 23 V +1 02/18/26, 11:56

  50. core-ci voted on patch set 23 V +1 02/18/26, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96127

  51. Tobias Wojtylak uploaded patch set 24 V +1 02/18/26, 13:40

  52. Benjamin Kott voted on patch set 24 CR +1 V +1 02/18/26, 14:17

  53. core-ci voted on patch set 24 V -1 02/18/26, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96145

  54. core-ci voted on patch set 24 V +1 02/18/26, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96145

  55. core-ci voted on patch set 24 V -1 02/18/26, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96145

  56. core-ci voted on patch set 24 V +1 02/18/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96145

  57. Josua Vogel commented on patch set 24 02/18/26, 15:28

    I tried the change with the Localization Wizard. In the end, I am not redirected correctly to the newly created language; apparently there is still a bug in the finisher.
  58. Andreas Nedbal commented on patch set 24 CR -1 02/18/26, 16:22

    I don't think we have any interface-only TS files in the codebase yet (otherwise I might just not be able to find them), but I am not a fan of the `.interface.ts` naming. Just calling them `submission-service-interface.ts` should be fine.

    summary.item.interface.ts:1

    Pending discussion due to `.interface.ts` but at least name the file `summary-item.interface.ts`.
  59. Andreas Nedbal commented on patch set 24 02/18/26, 16:30

    Are three separate interfaces necessary for the WizardSteps? All steps I have seen implement 3 interfaces, can't this be combined into just the WizardStepInterface?
  60. Benjamin Kott voted on patch set 24 CR -1 V -1 02/19/26, 07:12

  1. Tobias Wojtylak uploaded patch set 25 CR -1 V +1 02/19/26, 09:02

  2. core-ci voted on patch set 25 V +1 02/19/26, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96220

  3. Tobias Wojtylak commented on patch set 25 02/19/26, 09:13

    Reply

    Thanks. Bug is fixed via https://review.typo3.org/c/Packages/TYPO3.CMS/+/92894, independently of this PR.

    Reply

    Changed it

    Reply

    These interfaces werde introduced in https://github.com/TYPO3/typo3/commit/57c4f799e711746012a1b28a1147000c1f12836a#diff-2f1a4ff5bc969953989bec78b81f3156c48e2fe0feb4711f7a59a207e1104347 Not all steps implement the same functionality. e,g. https://review.typo3.org/c/Packages/TYPO3.CMS/+/92821/25/Build/Sources/TypeScript/backend/localization/steps/finisher-step.ts Each interface signals a specific capability: - e.g. WizardStepSummaryInterface → step can return a summary

    summary.item.interface.ts:1 Reply

    Done
  4. Tobias Wojtylak commented on patch set 25 02/19/26, 09:34

    Reply

    Done
  5. Benjamin Franzke commented on patch set 25 02/19/26, 13:33

    Hey, this line is 244 chars long, we wrap commit message lines at 72 chars, see: https://docs.typo3.org/permalink/t3contribute:commitmessage
  6. Tobias Wojtylak updated the commit message in patch set 26 V +1 02/19/26, 14:43

  7. Tobias Wojtylak commented on patch set 26 02/19/26, 14:43

    Reply

    Done
  8. core-ci voted on patch set 26 V -1 02/19/26, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96255

  9. core-ci commented on patch set 26 02/19/26, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96255

  10. core-ci voted on patch set 26 V +1 02/19/26, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96255

  11. Benjamin Kott voted on patch set 26 CR +1 V +1 02/20/26, 07:25

  12. Andreas Nedbal commented on patch set 26 CR -1 02/20/26, 10:10

    summary.item-interface.ts:1

    Please rename from `summary.item-interface.ts` to `summary-item-interface.ts`
  13. Tobias Wojtylak uploaded patch set 27 CR +1 V +1 02/20/26, 11:16

  14. Tobias Wojtylak commented on patch set 27 02/20/26, 11:16

    summary.item-interface.ts:1 Reply

    Done
  15. Benjamin Kott uploaded patch set 28 02/20/26, 11:17

  16. Benjamin Kott uploaded patch set 29 02/20/26, 11:20

  17. core-ci voted on patch set 29 V +1 02/20/26, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96343

  18. Benjamin Franzke commented on patch set 29 02/20/26, 12:38

    localization-wizard.ts:14

    This import is unneeded since line 21 imports it via ``` import { type DataStore, type Wizard } from '@typo3/backend/wizard/wizard'; ``` Note: we use https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax to ensure that typescript never applies automatic import elision. Our TypeScript environment only remove type-only import, e.g. `import type { … }` instead of `import { type … }` (the examples in the TypeScript documentation explain the difference) => Remove this line
  19. Benjamin Franzke uploaded patch set 30 V +1 02/20/26, 12:41

  20. Benjamin Franzke commented on patch set 30 02/20/26, 12:41

    localization-wizard.ts:14 Reply

    Done
  21. core-ci voted on patch set 30 V +1 02/20/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96346

  22. Benjamin Kott voted on patch set 30 CR +1 V +1 02/20/26, 12:55

  23. Andreas Nedbal voted on patch set 30 CR +1 V +1 02/20/26, 14:03

  24. Benjamin Franzke voted on patch set 30 CR +2 V +2 02/20/26, 16:21

  25. Benjamin Franzke merged patch set 31 02/20/26, 16:22