92821[TASK] Extract generic wizard component from LocalizationWizard for reuse
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Nedbal +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Nedbal +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 51
- Build/Sources/Sass/component/_localization-wizard.scssdeleted+0 −95
- Build/Sources/Sass/component/_wizard.scssnew+95 −0
- Build/Sources/Sass/backend.scss+1 −1
- Build/Sources/TypeScript/backend/localization/finisher/localization-submission-service.tsnew+33 −0
- Build/Sources/TypeScript/backend/localization/steps/confirm-step.tsdeleted+0 −61
- Build/Sources/TypeScript/backend/localization/steps/content-record-selection-step.ts+32 −39
- Build/Sources/TypeScript/backend/localization/steps/finisher-step.ts3deleted+0 −179
- Build/Sources/TypeScript/backend/localization/steps/handler-selection-step.ts+25 −29
- Build/Sources/TypeScript/backend/localization/steps/mode-step.ts4+24 −28
- Build/Sources/TypeScript/backend/localization/steps/source-language-step.ts+26 −28
- Build/Sources/TypeScript/backend/localization/steps/target-language-step.ts+32 −33
- Build/Sources/TypeScript/backend/localization/localization-wizard.ts2+72 −353
- Build/Sources/TypeScript/backend/wizard/events/auto-advance-event.tsnew+21 −0
- Build/Sources/TypeScript/backend/wizard/events/step-summary-event.tsnew+26 −0
- Build/Sources/TypeScript/backend/wizard/finisher/finisher-config.tsnew+19 −0
- Build/Sources/TypeScript/backend/wizard/finisher/finisher-interface.tsrenamed+2 −11
- Build/Sources/TypeScript/backend/wizard/finisher/finisher-result.tsnew+26 −0
- Build/Sources/TypeScript/backend/wizard/finisher/noop-finisher.tsrenamed+3 −2
- Build/Sources/TypeScript/backend/wizard/finisher/redirect-finisher.tsrenamed+3 −2
- Build/Sources/TypeScript/backend/wizard/finisher/reload-finisher.tsrenamed+4 −3
Show 31 more files
- Build/Sources/TypeScript/backend/wizard/finisher/submission-service-interface.tsnew+17 −0
- Build/Sources/TypeScript/backend/wizard/steps/confirm-step.tsnew+63 −0
- Build/Sources/TypeScript/backend/wizard/steps/finisher-step.tsnew+149 −0
- Build/Sources/TypeScript/backend/wizard/steps/summary-item-interface.tsnew+19 −0
- Build/Sources/TypeScript/backend/wizard/steps/wizard-step-interface.tsnew+26 −0
- Build/Sources/TypeScript/backend/wizard/steps/wizard-step-summary-interface.tsnew+18 −0
- Build/Sources/TypeScript/backend/wizard/steps/wizard-step-value-interface.tsnew+20 −0
- Build/Sources/TypeScript/backend/wizard/wizard.tsnew+352 −0
- typo3/sysext/backend/Classes/Localization/Finisher/NoopLocalizationFinisher.php+1 −1
- typo3/sysext/backend/Classes/Localization/Finisher/RedirectLocalizationFinisher.php+1 −1
- typo3/sysext/backend/Classes/Localization/Finisher/ReloadLocalizationFinisher.php+1 −1
- typo3/sysext/backend/Resources/Private/Language/Wizards/general.xlfnew+61 −0
- typo3/sysext/backend/Resources/Private/Language/Wizards/localization.xlf+2 −56
- typo3/sysext/backend/Resources/Public/Css/backend.css+12 −12
- typo3/sysext/backend/Resources/Public/JavaScript/localization/finisher/localization-submission-service.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/localization/steps/confirm-step.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/localization/steps/content-record-selection-step.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization/steps/finisher-step.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/localization/steps/handler-selection-step.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization/steps/mode-step.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization/steps/source-language-step.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization/steps/target-language-step.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/localization/localization-wizard.js+1 −4
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/events/auto-advance-event.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/events/step-summary-event.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/finisher/noop-finisher.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/finisher/redirect-finisher.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/finisher/reload-finisher.jsrenamed+0 −0
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/steps/confirm-step.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/steps/finisher-step.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/wizard/wizard.jsnew+16 −0
Review log 5385
Show 3460 earlier messages
-
Tobias Wojtylak uploaded patch set 1 02/12/26, 13:41
-
Tobias Wojtylak updated the commit message in patch set 2 02/12/26, 13:43
-
core-ci voted on patch set 1 V +1 02/12/26, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95734
-
core-ci voted on patch set 2 V +1 02/12/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95735
-
Benjamin Kott commented on patch set 2 CR -1 02/12/26, 14:51
mode-step.ts:24not sure but we usually do not break the lines here -
Tobias Wojtylak commented on patch set 2 02/12/26, 15:15
finisher-step.ts:39ReplyI would suggest doing that in the next iteration.mode-step.ts:24ReplyThen we should probably adjust the linter config. -
Tobias Wojtylak commented on patch set 2 02/16/26, 08:02
mode-step.ts:24ReplyIt doesn't look like it to me: https://github.com/TYPO3/typo3/blob/main/Build/Sources/TypeScript/form/backend/form-editor/inspector-component.ts -
Benjamin Kott commented on patch set 2 02/16/26, 14:16
mode-step.ts:24ReplyAcknowledged -
Tobias Wojtylak uploaded patch set 3
CR -1V +102/16/26, 14:29 -
core-ci voted on patch set 3 V -1 02/16/26, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95966
-
Tobias Wojtylak uploaded patch set 4
V -102/16/26, 14:48 -
Tobias Wojtylak uploaded patch set 5 02/16/26, 14:55
-
core-ci voted on patch set 4 V -1 02/16/26, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95968
-
Tobias Wojtylak uploaded patch set 6 02/16/26, 15:11
-
core-ci voted on patch set 6 V -1 02/16/26, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95973
-
Tobias Wojtylak uploaded patch set 7
V -102/16/26, 15:30 -
core-ci voted on patch set 5 V -1 02/16/26, 15:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95970
-
core-ci voted on patch set 7 V -1 02/16/26, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95974
-
Tobias Wojtylak uploaded patch set 8
V -102/16/26, 15:50 -
core-ci voted on patch set 8 V +1 02/16/26, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95978
-
Tobias Wojtylak uploaded patch set 9
V +102/17/26, 08:14 -
core-ci voted on patch set 9 V +1 02/17/26, 08:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96016
-
Tobias Wojtylak commented on patch set 9 02/17/26, 08:43
finisher-step.ts:39ReplyDone -
Tobias Wojtylak uploaded patch set 10
V +102/17/26, 10:39 -
Tobias Wojtylak uploaded patch set 11 02/17/26, 10:51
-
Tobias Wojtylak uploaded patch set 12 02/17/26, 10:59
-
core-ci voted on patch set 11 V -1 02/17/26, 11:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96028
-
Tobias Wojtylak uploaded patch set 13 02/17/26, 11:03
-
Tobias Wojtylak uploaded patch set 14 02/17/26, 11:09
-
Tobias Wojtylak uploaded patch set 15 02/17/26, 11:13
-
core-ci voted on patch set 13 V -1 02/17/26, 11:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96030
-
Tobias Wojtylak uploaded patch set 16 02/17/26, 11:17
-
core-ci voted on patch set 14 V -1 02/17/26, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96031
-
core-ci voted on patch set 10 V -1 02/17/26, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96026
-
core-ci voted on patch set 16 V -1 02/17/26, 11:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96033
-
core-ci voted on patch set 12 V -1 02/17/26, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96029
-
Tobias Wojtylak uploaded patch set 17
V -102/17/26, 11:42 -
core-ci voted on patch set 15 V -1 02/17/26, 11:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96032
-
core-ci voted on patch set 17 V -1 02/17/26, 11:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96037
-
Tobias Wojtylak uploaded patch set 18
V -102/17/26, 11:57 -
core-ci voted on patch set 18 V +1 02/17/26, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96038
-
Tobias Wojtylak updated the commit message in patch set 19
V +102/17/26, 13:17 -
Tobias Wojtylak updated the commit message in patch set 20 02/17/26, 13:21
-
Tobias Wojtylak updated the commit message in patch set 21 02/17/26, 13:22
-
core-ci voted on patch set 21 V +1 02/17/26, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96055
-
Tobias Wojtylak rebased onto patch set 22
V +102/18/26, 10:06 -
core-ci voted on patch set 22 V -1 02/18/26, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96115
-
core-ci voted on patch set 22 V +1 02/18/26, 10:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96115
-
Tobias Wojtylak uploaded patch set 23
V +102/18/26, 11:56 -
core-ci voted on patch set 23 V +1 02/18/26, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96127
-
Tobias Wojtylak uploaded patch set 24
V +102/18/26, 13:40 -
Benjamin Kott voted on patch set 24 CR +1 V +1 02/18/26, 14:17
-
core-ci voted on patch set 24 V -1 02/18/26, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96145
-
core-ci voted on patch set 24 V +1 02/18/26, 14:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96145
-
core-ci voted on patch set 24 V -1 02/18/26, 14:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96145
-
core-ci voted on patch set 24 V +1 02/18/26, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96145
-
Josua Vogel commented on patch set 24 02/18/26, 15:28
I tried the change with the Localization Wizard. In the end, I am not redirected correctly to the newly created language; apparently there is still a bug in the finisher. -
Andreas Nedbal commented on patch set 24 CR -1 02/18/26, 16:22
I don't think we have any interface-only TS files in the codebase yet (otherwise I might just not be able to find them), but I am not a fan of the `.interface.ts` naming. Just calling them `submission-service-interface.ts` should be fine.summary.item.interface.ts:1Pending discussion due to `.interface.ts` but at least name the file `summary-item.interface.ts`. -
Andreas Nedbal commented on patch set 24 02/18/26, 16:30
Are three separate interfaces necessary for the WizardSteps? All steps I have seen implement 3 interfaces, can't this be combined into just the WizardStepInterface? -
Benjamin Kott voted on patch set 24 CR -1 V -1 02/19/26, 07:12
-
Tobias Wojtylak uploaded patch set 25
CR -1V +102/19/26, 09:02 -
core-ci voted on patch set 25 V +1 02/19/26, 09:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96220
-
Tobias Wojtylak commented on patch set 25 02/19/26, 09:13
Reply
Thanks. Bug is fixed via https://review.typo3.org/c/Packages/TYPO3.CMS/+/92894, independently of this PR.Reply
Changed itReply
These interfaces werde introduced in https://github.com/TYPO3/typo3/commit/57c4f799e711746012a1b28a1147000c1f12836a#diff-2f1a4ff5bc969953989bec78b81f3156c48e2fe0feb4711f7a59a207e1104347 Not all steps implement the same functionality. e,g. https://review.typo3.org/c/Packages/TYPO3.CMS/+/92821/25/Build/Sources/TypeScript/backend/localization/steps/finisher-step.ts Each interface signals a specific capability: - e.g. WizardStepSummaryInterface → step can return a summarysummary.item.interface.ts:1ReplyDone -
Tobias Wojtylak commented on patch set 25 02/19/26, 09:34
Reply
Done -
Benjamin Franzke commented on patch set 25 02/19/26, 13:33
Hey, this line is 244 chars long, we wrap commit message lines at 72 chars, see: https://docs.typo3.org/permalink/t3contribute:commitmessage -
Tobias Wojtylak updated the commit message in patch set 26
V +102/19/26, 14:43 -
Tobias Wojtylak commented on patch set 26 02/19/26, 14:43
Reply
Done -
core-ci voted on patch set 26 V -1 02/19/26, 14:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96255
-
core-ci commented on patch set 26 02/19/26, 17:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96255
-
core-ci voted on patch set 26 V +1 02/19/26, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96255
-
Benjamin Kott voted on patch set 26 CR +1 V +1 02/20/26, 07:25
-
Andreas Nedbal commented on patch set 26 CR -1 02/20/26, 10:10
summary.item-interface.ts:1Please rename from `summary.item-interface.ts` to `summary-item-interface.ts` -
Tobias Wojtylak uploaded patch set 27
CR +1V +102/20/26, 11:16 -
Tobias Wojtylak commented on patch set 27 02/20/26, 11:16
summary.item-interface.ts:1ReplyDone -
Benjamin Kott uploaded patch set 28 02/20/26, 11:17
-
Benjamin Kott uploaded patch set 29 02/20/26, 11:20
-
core-ci voted on patch set 29 V +1 02/20/26, 12:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96343
-
Benjamin Franzke commented on patch set 29 02/20/26, 12:38
localization-wizard.ts:14This import is unneeded since line 21 imports it via ``` import { type DataStore, type Wizard } from '@typo3/backend/wizard/wizard'; ``` Note: we use https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax to ensure that typescript never applies automatic import elision. Our TypeScript environment only remove type-only import, e.g. `import type { … }` instead of `import { type … }` (the examples in the TypeScript documentation explain the difference) => Remove this line -
Benjamin Franzke uploaded patch set 30
V +102/20/26, 12:41 -
Benjamin Franzke commented on patch set 30 02/20/26, 12:41
localization-wizard.ts:14ReplyDone -
core-ci voted on patch set 30 V +1 02/20/26, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96346
-
Benjamin Kott voted on patch set 30 CR +1 V +1 02/20/26, 12:55
-
Andreas Nedbal voted on patch set 30 CR +1 V +1 02/20/26, 14:03
-
Benjamin Franzke voted on patch set 30 CR +2 V +2 02/20/26, 16:21
-
Benjamin Franzke merged patch set 31 02/20/26, 16:22
finisher-step.ts:39