Review main Abandoned

92822[BUGFIX] Avoid redundant filesystem scans in LanguagePackService

Benni Mack CR 0 V -1 Easy +17 −6 updated 04/21/26, 15:20

Commit message

The method languagePackDownload() called
"getExtensionLanguagePackDetails()" on every invocation, scanning all
active extensions just to validate a single one. For 50 extensions and
5 languages this resulted in 250 redundant full scans and 134,000+
RecursiveDirectoryIterator calls.

Replace the full scan with a targeted check on the single extension
being downloaded. Additionally, fix the LanguagePackCommand download
loop to iterate only the pre-filtered languages instead of all
requested ISOs, and use Finder::hasResults() instead of count() to
avoid iterating all matching files when only checking for existence.

Review

  • Code review CR 0
  • Verified V -1
    • core-ci -1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack uploaded patch set 1 02/12/26, 13:48

  2. core-ci voted on patch set 1 V -1 02/12/26, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95738

  3. Garvin Hicking commented on patch set 1 02/12/26, 21:21

    LanguagePackService.php:199 Unresolved

    That feel's like we should keep the removed comment in place in termy of hackiness. ;) Utilize `EmConfUtility::includeEmConf` here instead? Also you've probably seen the quite similar code in this method too, I think we could use the chance and move this EmConf handling out of the languagePackService domain into eitehr emConfUtility or PackageManager, wdyt?
  4. Benni Mack abandoned the change 04/21/26, 15:20