Review main Merged

92825[TASK] Solve more trivial phpstan baseline information

Benni Mack CR +2 V +2 Hard +126 −533 updated 02/12/26, 19:00

Commit message

Another round of cleanups regarding phpstan baseline
information in order to activate the next level of issues.

Due to proper (= correct) typing some additional tests can
be removed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 32

Show 12 more files

Review log 1115

  1. Benni Mack uploaded patch set 1 02/12/26, 16:02

  2. core-ci voted on patch set 1 V -1 02/12/26, 16:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95750

  3. Benni Mack uploaded patch set 2 V -1 02/12/26, 16:41

  4. Benni Mack marked it ready for review 02/12/26, 16:41

  5. Benni Mack uploaded patch set 3 02/12/26, 17:11

  6. core-ci voted on patch set 2 V +1 02/12/26, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95755

  7. core-ci voted on patch set 3 V +1 02/12/26, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95759

  8. Oliver Klee commented on patch set 3 V +1 02/12/26, 17:51

    CropVariant.php:40

    We can drop these type annotations as they are identical to the native parameter type declarations.
  9. Benni Mack commented on patch set 4 V +1 02/12/26, 18:30

    Published edit on patch set 3.
  10. Benni Mack commented on patch set 4 02/12/26, 18:31

    CropVariant.php:40 Reply

    Done
  11. core-ci voted on patch set 4 V +1 02/12/26, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95764

  12. Oliver Klee voted on patch set 4 CR +1 V +1 02/12/26, 18:42

  13. Anja Leichsenring voted on patch set 4 CR +1 V +1 02/12/26, 19:00

  14. Benni Mack voted on patch set 4 CR +2 V +2 02/12/26, 19:00

  15. Benni Mack merged patch set 5 02/12/26, 19:00