Review main Merged

92835[FEATURE] Show Extbase class configuration in Configuration module

Matthias Vogel CR +2 V +2 Normal +81 −0 updated 02/13/26, 21:02

Commit message

Adds a configuration provider for Extbase persistence class mapping and
exposes it in the lowlevel Configuration module for easier inspection.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1

Issues 1

Files 5

Review log 1520

  1. Matthias Vogel uploaded patch set 1 02/13/26, 12:10

  2. core-ci voted on patch set 1 V +1 02/13/26, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95826

  3. Matthias Vogel uploaded patch set 2 V +1 02/13/26, 12:26

  4. core-ci voted on patch set 2 V -1 02/13/26, 12:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95828

  5. Matthias Vogel uploaded patch set 3 V -1 02/13/26, 12:41

  6. Matthias Vogel marked it ready for review 02/13/26, 12:41

  7. core-ci voted on patch set 3 V -1 02/13/26, 12:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95829

  8. Matthias Vogel uploaded patch set 4 V -1 02/13/26, 13:18

  9. core-ci voted on patch set 4 V +1 02/13/26, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95831

  10. Benni Mack commented on patch set 4 02/13/26, 14:27

    Services.yaml:160

    have you tried this with EXT:lowlevel not being installed? I suggest we need to move this in Services.php, similar to how it's done in EXT:form
  11. Matthias Vogel commented on patch set 4 02/13/26, 15:53

    Services.yaml:160 Reply

    Yes there is nothing breaking about it, as long as no one uses the class if EXT:lowlvel is not installed. In EXT:fluid is currently done the same way. https://github.com/TYPO3/typo3/blob/c2223e5ae88dcf1797df1afa19af792702522e9f/typo3/sysext/fluid/Configuration/Services.yaml#L47-L53
  12. Garvin Hicking commented on patch set 4 02/13/26, 17:22

    Feature-108975-AddConfigurationProviderForExtbaseClassConfiguration.rst:16

    ```suggestion the system extension `lowlevel` is installed. ```

    Feature-108975-AddConfigurationProviderForExtbaseClassConfiguration.rst:19

    ```suggestion it is built by collecting and merging all :file:`Configuration/Extbase/Persistence/Classes.php` ```

    Feature-108975-AddConfigurationProviderForExtbaseClassConfiguration.rst:32

    ```suggestion :file:`Configuration/Extbase/Persistence/Classes.php` file. ```

    locallang.xlf:117

    Let's introduce new language keys with snake_case ```suggestion <trans-unit id="class_configuration"> ```
  13. Garvin Hicking voted on patch set 4 V +1 02/13/26, 17:32

  14. Anja Leichsenring voted on patch set 4 V +1 02/13/26, 19:26

  15. Garvin Hicking commented on patch set 5 V +1 02/13/26, 20:48

    Published edit on patch set 4.
  16. Garvin Hicking commented on patch set 6 02/13/26, 20:49

    Published edit on patch set 5.
  17. Garvin Hicking commented on patch set 6 CR +1 V +1 02/13/26, 20:50

    Feature-108975-AddConfigurationProviderForExtbaseClassConfiguration.rst:16 Reply

    Fix applied.

    Feature-108975-AddConfigurationProviderForExtbaseClassConfiguration.rst:19 Reply

    Fix applied.

    Feature-108975-AddConfigurationProviderForExtbaseClassConfiguration.rst:32 Reply

    Fix applied.

    Services.yaml:160 Reply

    Exactly, just a tag that's not problematic.

    Services.yaml:161

    ```suggestion label: 'extbase.messages:class_configuration' ```

    locallang.xlf:117 Reply

    Fix applied.
  18. Georg Ringer voted on patch set 6 CR +2 V +2 02/13/26, 20:56

  19. Georg Ringer merged patch set 7 02/13/26, 20:56

  20. core-ci voted on patch set 6 V +1 02/13/26, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95847