Review main Merged

92837[BUGFIX] Respect position "top" in EMU::addTcaSelectItemGroup()

TYPO3com CR +2 V +2 Easy +33 −5 updated 06/05/26, 13:43

Commit message

The "referenced group not found" fallback of
ExtensionManagementUtility::addTcaSelectItemGroup() kicks
in unconditionally since the referenced group id is an empty
string when no group is referenced at all. Adding a group
with position "top" is thus rewritten to "bottom" and the
keyword never worked.

The patch fixes this. The test assertion is turned from
assertEquals() into assertSame() since group order matters,
which would have revealed the bug with existing test sets.
They are extended to additionally verify behavior on two
broken setups.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Christian Kuhn +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1119

  1. TYPO3com uploaded patch set 1 02/13/26, 13:33

  2. Sebastian Iffland updated the commit message in patch set 2 02/13/26, 13:38

  3. core-ci voted on patch set 1 V -1 02/13/26, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95832

  4. core-ci voted on patch set 2 V -1 02/13/26, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95833

  5. Sebastian Iffland updated the commit message in patch set 3 V -1 02/13/26, 14:30

  6. core-ci voted on patch set 3 V -1 02/13/26, 14:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95835

  7. Sebastian Iffland updated the commit message in patch set 4 V -1 02/13/26, 15:07

  8. core-ci voted on patch set 4 V -1 02/13/26, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95838

  9. Sebastian Iffland uploaded patch set 5 V -1 02/17/26, 06:52

  10. core-ci voted on patch set 5 V +1 02/17/26, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96012

  11. Benni Mack updated the commit message in patch set 6 V +1 04/22/26, 06:26

  12. core-ci voted on patch set 6 V -1 04/22/26, 06:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100700

  13. Christian Kuhn uploaded patch set 7 V -1 06/05/26, 00:03

  14. Christian Kuhn voted on patch set 7 CR +1 V +1 06/05/26, 00:03

  15. core-ci voted on patch set 7 V +1 06/05/26, 00:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/102996

  16. Garvin Hicking voted on patch set 7 CR +1 V +1 06/05/26, 12:11

  17. Josua Vogel voted on patch set 7 CR +1 V +1 06/05/26, 12:42

  18. Garvin Hicking voted on patch set 7 CR +2 V +2 06/05/26, 13:43

  19. Garvin Hicking merged patch set 8 06/05/26, 13:43