92838[FEATURE] Add FormInstructionSchema to FormEngine
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 22
- typo3/sysext/backend/Classes/Controller/SiteConfigurationController.php1+4 −0
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+3 −0
- typo3/sysext/backend/Classes/Form/FormDataGroup/OrderedProviderList.php6+37 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaColumnsOverrides.php1+6 −2
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaText.php2+17 −9
- typo3/sysext/backend/Classes/Form/InstructionsSchema/FieldTypes/HiddenFieldType.phpnew+41 −0
- typo3/sysext/backend/Classes/Form/InstructionsSchema/FieldTypes/SiteLanguageFieldType.phpnew+41 −0
- typo3/sysext/backend/Classes/Form/InstructionsSchema/FormInstructionSchemaFieldFactory.php3new+75 −0
- typo3/sysext/backend/Classes/Form/InstructionsSchema/FormInstructionSchemaProcessedTcaSynchronizer.phpnew+46 −0
- typo3/sysext/backend/Classes/Form/FormInstructionSchema.php2new+118 −0
- typo3/sysext/backend/Classes/Form/FormInstructionSchemaFactory.phpnew+33 −0
- typo3/sysext/backend/Tests/Functional/Form/FormDataProvider/TcaFlexProcessTest.php+41 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/FlexFormSegmentTest.php+20 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/OrderedProviderListTest.php+78 −5
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/SiteConfigurationDataGroupTest.php+20 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaDatabaseRecordTest.php+20 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaInputPlaceholderRecordTest.php+20 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/TcaSelectTreeAjaxFieldDataTest.php+20 −3
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/InitializeProcessedTcaTest.php+2 −2
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaColumnsOverridesTest.php+35 −0
Review log 5486
Show 3761 earlier messages
-
Bastien Lutz uploaded patch set 1 02/13/26, 14:18
-
Bastien Lutz marked it work in progress 02/13/26, 14:18
-
core-ci voted on patch set 1 V -1 02/13/26, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95834
-
Bastien Lutz uploaded patch set 2
V -102/16/26, 15:39 -
core-ci voted on patch set 2 V -1 02/16/26, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95976
-
Bastien Lutz uploaded patch set 3
V -102/17/26, 07:30 -
core-ci voted on patch set 3 V -1 02/17/26, 07:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96014
-
Oli Bartsch commented on patch set 3 02/17/26, 11:11
RenderingInstructions.php:39I'm not sure about this. Why do we add all fields here? Shouldn't this be limited to the sub schema fields?RenderingInstructions.php:81We need to ensure that we do not run into problems when calling something like `getFieldConfiguration()['config']['xyz']`.RenderingInstructionsFactory.php:42Not really sure it it's a good idea to pass a factory and also the relationMap here. Isn't `RenderingInstructions` more a DTO? I think we should think about passing the constructed FieldType to setFieldConfiguration() and let calling code construct it. Maybe using a special servcie there to prevent duplicate code. -
Bastien Lutz uploaded patch set 4
V -102/17/26, 14:05 -
Bastien Lutz commented on patch set 4 02/17/26, 14:06
InitializeProcessedTca.php:28ReplyDoneRenderingInstructions.php:39ReplyDoneRenderingInstructions.php:81ReplyDoneRenderingInstructionsFactory.php:42ReplyDone -
core-ci voted on patch set 4 V -1 02/17/26, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96059
-
Bastien Lutz uploaded patch set 5
V -102/17/26, 16:18 -
core-ci voted on patch set 5 V -1 02/17/26, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96066
-
Oli Bartsch commented on patch set 5 02/17/26, 20:48
RenderingInstructionsService.php:35This is to late in the request to access `$GLOBALS['TCA']`. This is no longer the source of truth. -
Oli Bartsch commented on patch set 5 02/18/26, 07:27
DatabaseRecordOverrideValues.php:37Why is this change necessary?InitializeProcessedTca.php:47I think we need to ensure that this is always set. Otherwise we risk breaking a lot of third party data providersDatabaseRecordOverrideValuesTest.php:91Why is this change necessary? -
Bastien Lutz uploaded patch set 6
V -102/18/26, 10:48 -
core-ci voted on patch set 6 V -1 02/18/26, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96118
-
Bastien Lutz commented on patch set 6 02/18/26, 12:10
DatabaseRecordOverrideValues.php:37ReplyThe RenderingInstructionsDto trys to instantiate every column to a SchemaApi Field. The type "hidden" is not implemented there and does not seem to be valid. Without this change, editing a page using the context menu, throws an exception as the FieldTypeFactory does not know the type hidden. As the behavior passtrough is intended i changed the type. -
Bastien Lutz uploaded patch set 7
V -102/18/26, 13:10 -
core-ci voted on patch set 7 V -1 02/18/26, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96136
-
Bastien Lutz uploaded patch set 8
V -102/18/26, 13:39 -
Bastien Lutz uploaded patch set 9 02/18/26, 13:53
-
core-ci voted on patch set 8 V -1 02/18/26, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96144
-
core-ci voted on patch set 9 V -1 02/18/26, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96147
-
Bastien Lutz uploaded patch set 10
V -102/18/26, 14:36 -
core-ci voted on patch set 10 V -1 02/18/26, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96151
-
Bastien Lutz uploaded patch set 11
V -102/18/26, 15:19 -
Bastien Lutz rebased onto patch set 12 02/18/26, 15:35
-
Bastien Lutz uploaded patch set 13 02/18/26, 15:37
-
core-ci voted on patch set 11 V -1 02/18/26, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96159
-
core-ci voted on patch set 13 V -1 02/18/26, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96166
-
core-ci voted on patch set 12 V -1 02/18/26, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96164
-
Bastien Lutz commented on patch set 13 02/19/26, 08:25
RenderingInstructionsService.php:35ReplyDone -
Bastien Lutz uploaded patch set 14
V -102/19/26, 10:24 -
core-ci voted on patch set 14 V -1 02/19/26, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96227
-
Bastien Lutz uploaded patch set 15
V -102/19/26, 11:32 -
Bastien Lutz uploaded patch set 16 02/19/26, 11:40
-
core-ci voted on patch set 15 V -1 02/19/26, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96238
-
core-ci voted on patch set 16 V -1 02/19/26, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96239
-
Bastien Lutz uploaded patch set 17 02/19/26, 13:24
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 17 V +1 02/19/26, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96247
-
Bastien Lutz marked it ready for review 02/19/26, 13:43
-
Bastien Lutz uploaded patch set 18
V +102/20/26, 14:25 -
Bastien Lutz commented on patch set 18 02/20/26, 14:26
InitializeProcessedTca.php:47ReplyDone -
core-ci voted on patch set 18 V +1 02/20/26, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96361
-
Bastien Lutz uploaded patch set 19 02/23/26, 08:54
Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 19 V +1 02/23/26, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96545
-
Bastien Lutz uploaded patch set 20
V +102/23/26, 15:39 -
core-ci voted on patch set 20 V -1 02/23/26, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96596
-
Bastien Lutz uploaded patch set 21 02/24/26, 07:14
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 20 V +1 02/24/26, 07:22 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 21 (was Verified-1) (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96596
-
Bastien Lutz commented on patch set 21 02/24/26, 07:25
DatabaseRecordOverrideValues.php:37ReplyAdjusted this by only setting the renderType to hidden.DatabaseRecordOverrideValuesTest.php:91ReplyDone -
core-ci voted on patch set 21 V +1 02/24/26, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96677
-
Benni Mack commented on patch set 21 02/24/26, 08:23
RenderingInstructions.php:24Is it OK if we rename it FormInstructionSchema ? -
Oli Bartsch commented on patch set 21 02/24/26, 09:34
DatabaseRecordOverrideValues.php:37ReplySeems like a good solution 👍 -
Bastien Lutz uploaded patch set 22
V +102/24/26, 11:00 -
Bastien Lutz commented on patch set 22 02/24/26, 11:01
renaming doneRenderingInstructions.php:24ReplyDone -
core-ci voted on patch set 22 V -1 02/24/26, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96709
-
Bastien Lutz uploaded patch set 23 02/24/26, 12:22
Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**") -
core-ci voted on patch set 23 V +1 02/24/26, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96725
-
Bastien Lutz rebased onto patch set 24
V +102/24/26, 13:17
-
Bastien Lutz uploaded patch set 25 02/24/26, 13:53
-
core-ci voted on patch set 24 V +1 02/24/26, 14:18 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 25 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96738
-
core-ci voted on patch set 25 V +1 02/24/26, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96745
-
Bastien Lutz rebased onto patch set 26
V +102/24/26, 14:54 -
core-ci voted on patch set 26 V +1 02/24/26, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96755
-
Bastien Lutz rebased onto patch set 27
V +102/25/26, 09:02 -
core-ci voted on patch set 27 V +1 02/25/26, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96801
-
Benni Mack uploaded patch set 28
V +102/25/26, 16:44 -
Benni Mack commented on patch set 28 02/25/26, 16:44
OrderedProviderList.php:89this is a deep-copy on every iteration = very memory consuming for everything. This _might_ be a huge problem.DatabaseRecordOverrideValues.php:38is it a problem if we remove the "type=hidden" now? Or why did we have to remove it? -
core-ci voted on patch set 28 V +1 02/25/26, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96839
-
Bastien Lutz commented on patch set 28 02/26/26, 07:24
DatabaseRecordOverrideValues.php:38Replyohterwise an exception is thrown when trying to convert this to a SchemaApi-Field. I evaluated that only setting the renderType is sufficient. But we could also handle this like "siteLanguage" if prefered. -
Bastien Lutz commented on patch set 28 02/26/26, 07:50
OrderedProviderList.php:89Replyhow about something like: $signatureBefore = md5(json_encode($result['processedTca'])); $result = $provider->addData($result); if (!empty($result['processedTca']) && md5(json_encode($result['processedTca'])) !== $signatureBefore) { -
Benni Mack commented on patch set 28 02/26/26, 10:56
OrderedProviderList.php:89Replysure. let's do it. it might be that serialize() might be even faster btwDatabaseRecordOverrideValues.php:38ReplyDone -
Bastien Lutz uploaded patch set 29
V +102/26/26, 11:03 -
Bastien Lutz commented on patch set 29 02/26/26, 11:05
Done. Improved code docs. Seperated Service class. Handled deep copy. Introduced HiddenFieldType for FormInstuctionsOrderedProviderList.php:89ReplyDoneDatabaseRecordOverrideValues.php:38ReplyAlready added HiddenFieldType... Won't hurt anyways. -
core-ci voted on patch set 29 V -1 02/26/26, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96901
-
Bastien Lutz uploaded patch set 30
V -102/26/26, 12:46 -
core-ci voted on patch set 30 V +1 02/26/26, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96915
-
Benni Mack commented on patch set 30 02/26/26, 13:28
FormInstructionSchemaFieldFactory.php:39please move this comment to the class (not the method) -
Bastien Lutz uploaded patch set 31
V +102/26/26, 13:30 -
Bastien Lutz commented on patch set 31 02/26/26, 13:30
FormInstructionSchemaFieldFactory.php:39ReplyDone -
core-ci voted on patch set 31 V +1 02/26/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96920
-
Oli Bartsch commented on patch set 31 02/26/26, 22:09
Unresolved
Since this is a feature, please add corresponding changelog file with explanation and examples. -
Oli Bartsch commented on patch set 31 02/26/26, 22:44
SiteConfigurationController.php:229UnresolvedAt some points we need to find a better solution for site config..OrderedProviderList.php:38UnresolvedWe should mention that using the special OnTheFly group, no 'processedTca' is made available anymore.OrderedProviderList.php:125UnresolvedWhy do we only handle columns?TcaColumnsOverrides.php:40UnresolvedShouldn't this be written directly to the schema instead?TcaText.php:45UnresolvedWhy do we create the schema here from scratch? Shouldn't this be shipped in `$result`?TcaText.php:63UnresolvedAccess schema here?FormInstructionSchema.php:41UnresolvedThis is never set?FormInstructionSchema.php:98UnresolvedWhy do we do this? Actually we are actively trying to get rid of the config sub array. That's why schema merges them. I know we need to update access in the providers but this should IMO be the way to go for the future. We need to document this properly, so when extensions migrate to use schema, they are aware, but I don't think we need such backwards layer.FormInstructionSchemaFieldFactory.php:46UnresolvedSince those are really quick workarounds, I suggest to not create new type classes but just return in-place objects here. -
Benni Mack abandoned the change 04/02/26, 10:30
was fixed differently, closing it now
InitializeProcessedTca.php:28