Review main Abandoned

92838[FEATURE] Add FormInstructionSchema to FormEngine

Bastien Lutz CR 0 V 0 Hard +769 −59 updated 04/02/26, 10:30

Commit message

Schema API is now used in FormEngine as well, bridging some custom
functionality and modifiable TCA ("processedTCA") into Schema API
which is currently only used for immutable TCA + FlexForm.

This should serve as replacement to $data['processedTCA'].
It stores configuration overlays and applies them on the schema
api allowing an object oriented way of accessing the TCA in the
formengine elements and data providers.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 5486

Show 3761 earlier messages
  1. Bastien Lutz uploaded patch set 1 02/13/26, 14:18

  2. Bastien Lutz marked it work in progress 02/13/26, 14:18

  3. core-ci voted on patch set 1 V -1 02/13/26, 14:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95834

  4. Bastien Lutz uploaded patch set 2 V -1 02/16/26, 15:39

  5. core-ci voted on patch set 2 V -1 02/16/26, 16:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95976

  6. Bastien Lutz uploaded patch set 3 V -1 02/17/26, 07:30

  7. core-ci voted on patch set 3 V -1 02/17/26, 07:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96014

  8. Oli Bartsch commented on patch set 3 02/17/26, 11:11

    InitializeProcessedTca.php:28

    Those imports are not used

    RenderingInstructions.php:39

    I'm not sure about this. Why do we add all fields here? Shouldn't this be limited to the sub schema fields?

    RenderingInstructions.php:81

    We need to ensure that we do not run into problems when calling something like `getFieldConfiguration()['config']['xyz']`.

    RenderingInstructionsFactory.php:42

    Not really sure it it's a good idea to pass a factory and also the relationMap here. Isn't `RenderingInstructions` more a DTO? I think we should think about passing the constructed FieldType to setFieldConfiguration() and let calling code construct it. Maybe using a special servcie there to prevent duplicate code.
  9. Bastien Lutz uploaded patch set 4 V -1 02/17/26, 14:05

  10. Bastien Lutz commented on patch set 4 02/17/26, 14:06

    InitializeProcessedTca.php:28 Reply

    Done

    RenderingInstructions.php:39 Reply

    Done

    RenderingInstructions.php:81 Reply

    Done

    RenderingInstructionsFactory.php:42 Reply

    Done
  11. core-ci voted on patch set 4 V -1 02/17/26, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96059

  12. Bastien Lutz uploaded patch set 5 V -1 02/17/26, 16:18

  13. core-ci voted on patch set 5 V -1 02/17/26, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96066

  14. Oli Bartsch commented on patch set 5 02/17/26, 20:48

    RenderingInstructionsService.php:35

    This is to late in the request to access `$GLOBALS['TCA']`. This is no longer the source of truth.
  15. Oli Bartsch commented on patch set 5 02/18/26, 07:27

    DatabaseRecordOverrideValues.php:37

    Why is this change necessary?

    InitializeProcessedTca.php:47

    I think we need to ensure that this is always set. Otherwise we risk breaking a lot of third party data providers

    DatabaseRecordOverrideValuesTest.php:91

    Why is this change necessary?
  16. Bastien Lutz uploaded patch set 6 V -1 02/18/26, 10:48

  17. core-ci voted on patch set 6 V -1 02/18/26, 11:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96118

  18. Bastien Lutz commented on patch set 6 02/18/26, 12:10

    DatabaseRecordOverrideValues.php:37 Reply

    The RenderingInstructionsDto trys to instantiate every column to a SchemaApi Field. The type "hidden" is not implemented there and does not seem to be valid. Without this change, editing a page using the context menu, throws an exception as the FieldTypeFactory does not know the type hidden. As the behavior passtrough is intended i changed the type.
  19. Bastien Lutz uploaded patch set 7 V -1 02/18/26, 13:10

  20. core-ci voted on patch set 7 V -1 02/18/26, 13:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96136

  21. Bastien Lutz uploaded patch set 8 V -1 02/18/26, 13:39

  22. Bastien Lutz uploaded patch set 9 02/18/26, 13:53

  23. core-ci voted on patch set 8 V -1 02/18/26, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96144

  24. core-ci voted on patch set 9 V -1 02/18/26, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96147

  25. Bastien Lutz uploaded patch set 10 V -1 02/18/26, 14:36

  26. core-ci voted on patch set 10 V -1 02/18/26, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96151

  27. Bastien Lutz uploaded patch set 11 V -1 02/18/26, 15:19

  28. Bastien Lutz rebased onto patch set 12 02/18/26, 15:35

  29. Bastien Lutz uploaded patch set 13 02/18/26, 15:37

  30. core-ci voted on patch set 11 V -1 02/18/26, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96159

  31. core-ci voted on patch set 13 V -1 02/18/26, 15:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96166

  32. core-ci voted on patch set 12 V -1 02/18/26, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96164

  33. Bastien Lutz commented on patch set 13 02/19/26, 08:25

    RenderingInstructionsService.php:35 Reply

    Done
  34. Bastien Lutz uploaded patch set 14 V -1 02/19/26, 10:24

  35. core-ci voted on patch set 14 V -1 02/19/26, 10:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96227

  36. Bastien Lutz uploaded patch set 15 V -1 02/19/26, 11:32

  37. Bastien Lutz uploaded patch set 16 02/19/26, 11:40

  38. core-ci voted on patch set 15 V -1 02/19/26, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96238

  39. core-ci voted on patch set 16 V -1 02/19/26, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96239

  40. Bastien Lutz uploaded patch set 17 02/19/26, 13:24

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  41. core-ci voted on patch set 17 V +1 02/19/26, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96247

  42. Bastien Lutz marked it ready for review 02/19/26, 13:43

  43. Bastien Lutz uploaded patch set 18 V +1 02/20/26, 14:25

  44. Bastien Lutz commented on patch set 18 02/20/26, 14:26

    InitializeProcessedTca.php:47 Reply

    Done
  45. core-ci voted on patch set 18 V +1 02/20/26, 15:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96361

  46. Bastien Lutz uploaded patch set 19 02/23/26, 08:54

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  47. core-ci voted on patch set 19 V +1 02/23/26, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96545

  48. Bastien Lutz uploaded patch set 20 V +1 02/23/26, 15:39

  49. core-ci voted on patch set 20 V -1 02/23/26, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96596

  50. Bastien Lutz uploaded patch set 21 02/24/26, 07:14

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  51. core-ci voted on patch set 20 V +1 02/24/26, 07:22 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 21 (was Verified-1) (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96596

  52. Bastien Lutz commented on patch set 21 02/24/26, 07:25

    DatabaseRecordOverrideValues.php:37 Reply

    Adjusted this by only setting the renderType to hidden.

    DatabaseRecordOverrideValuesTest.php:91 Reply

    Done
  53. core-ci voted on patch set 21 V +1 02/24/26, 07:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96677

  54. Benni Mack commented on patch set 21 02/24/26, 08:23

    RenderingInstructions.php:24

    Is it OK if we rename it FormInstructionSchema ?
  55. Oli Bartsch commented on patch set 21 02/24/26, 09:34

    DatabaseRecordOverrideValues.php:37 Reply

    Seems like a good solution 👍
  56. Bastien Lutz uploaded patch set 22 V +1 02/24/26, 11:00

  57. Bastien Lutz commented on patch set 22 02/24/26, 11:01

    renaming done

    RenderingInstructions.php:24 Reply

    Done
  58. core-ci voted on patch set 22 V -1 02/24/26, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96709

  59. Bastien Lutz uploaded patch set 23 02/24/26, 12:22

    Copied Votes: * Verified-1 (copy condition: "**changekind:NO_CHANGE**")
  60. core-ci voted on patch set 23 V +1 02/24/26, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96725

  61. Bastien Lutz rebased onto patch set 24 V +1 02/24/26, 13:17

  1. Bastien Lutz uploaded patch set 25 02/24/26, 13:53

  2. core-ci voted on patch set 24 V +1 02/24/26, 14:18 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 25 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96738

  3. core-ci voted on patch set 25 V +1 02/24/26, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96745

  4. Bastien Lutz rebased onto patch set 26 V +1 02/24/26, 14:54

  5. core-ci voted on patch set 26 V +1 02/24/26, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96755

  6. Bastien Lutz rebased onto patch set 27 V +1 02/25/26, 09:02

  7. core-ci voted on patch set 27 V +1 02/25/26, 09:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96801

  8. Benni Mack uploaded patch set 28 V +1 02/25/26, 16:44

  9. Benni Mack commented on patch set 28 02/25/26, 16:44

    OrderedProviderList.php:89

    this is a deep-copy on every iteration = very memory consuming for everything. This _might_ be a huge problem.

    DatabaseRecordOverrideValues.php:38

    is it a problem if we remove the "type=hidden" now? Or why did we have to remove it?
  10. core-ci voted on patch set 28 V +1 02/25/26, 17:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96839

  11. Bastien Lutz commented on patch set 28 02/26/26, 07:24

    DatabaseRecordOverrideValues.php:38 Reply

    ohterwise an exception is thrown when trying to convert this to a SchemaApi-Field. I evaluated that only setting the renderType is sufficient. But we could also handle this like "siteLanguage" if prefered.
  12. Bastien Lutz commented on patch set 28 02/26/26, 07:50

    OrderedProviderList.php:89 Reply

    how about something like: $signatureBefore = md5(json_encode($result['processedTca'])); $result = $provider->addData($result); if (!empty($result['processedTca']) && md5(json_encode($result['processedTca'])) !== $signatureBefore) {
  13. Benni Mack commented on patch set 28 02/26/26, 10:56

    OrderedProviderList.php:89 Reply

    sure. let's do it. it might be that serialize() might be even faster btw

    DatabaseRecordOverrideValues.php:38 Reply

    Done
  14. Bastien Lutz uploaded patch set 29 V +1 02/26/26, 11:03

  15. Bastien Lutz commented on patch set 29 02/26/26, 11:05

    Done. Improved code docs. Seperated Service class. Handled deep copy. Introduced HiddenFieldType for FormInstuctions

    OrderedProviderList.php:89 Reply

    Done

    DatabaseRecordOverrideValues.php:38 Reply

    Already added HiddenFieldType... Won't hurt anyways.
  16. core-ci voted on patch set 29 V -1 02/26/26, 11:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96901

  17. Bastien Lutz uploaded patch set 30 V -1 02/26/26, 12:46

  18. core-ci voted on patch set 30 V +1 02/26/26, 13:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96915

  19. Benni Mack commented on patch set 30 02/26/26, 13:28

    FormInstructionSchemaFieldFactory.php:39

    please move this comment to the class (not the method)
  20. Bastien Lutz uploaded patch set 31 V +1 02/26/26, 13:30

  21. Bastien Lutz commented on patch set 31 02/26/26, 13:30

    FormInstructionSchemaFieldFactory.php:39 Reply

    Done
  22. core-ci voted on patch set 31 V +1 02/26/26, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96920

  23. Oli Bartsch commented on patch set 31 02/26/26, 22:09

    Unresolved

    Since this is a feature, please add corresponding changelog file with explanation and examples.
  24. Oli Bartsch commented on patch set 31 02/26/26, 22:44

    SiteConfigurationController.php:229 Unresolved

    At some points we need to find a better solution for site config..

    OrderedProviderList.php:38 Unresolved

    We should mention that using the special OnTheFly group, no 'processedTca' is made available anymore.

    OrderedProviderList.php:125 Unresolved

    Why do we only handle columns?

    TcaColumnsOverrides.php:40 Unresolved

    Shouldn't this be written directly to the schema instead?

    TcaText.php:45 Unresolved

    Why do we create the schema here from scratch? Shouldn't this be shipped in `$result`?

    TcaText.php:63 Unresolved

    Access schema here?

    FormInstructionSchema.php:41 Unresolved

    This is never set?

    FormInstructionSchema.php:98 Unresolved

    Why do we do this? Actually we are actively trying to get rid of the config sub array. That's why schema merges them. I know we need to update access in the providers but this should IMO be the way to go for the future. We need to document this properly, so when extensions migrate to use schema, they are aware, but I don't think we need such backwards layer.

    FormInstructionSchemaFieldFactory.php:46 Unresolved

    Since those are really quick workarounds, I suggest to not create new type classes but just return in-place objects here.
  25. Benni Mack abandoned the change 04/02/26, 10:30

    was fixed differently, closing it now