Review main Merged

92852[TASK] Remove irrelevant columns in ColumnSelector

Simon Schaufelberger CR +2 V +2 Easy +37 −0 updated 09/04/26, 09:29

Commit message

The following fields are removed from being potential listed from the
possible selection:

- deleted: Deleted records are never listed anyway
- l10n_source, l18n_diffsource: The fields are not editable

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Windloff +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Windloff +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2635

Show 710 earlier messages
  1. Simon Schaufelberger uploaded patch set 1 02/14/26, 18:32

  2. Simon Schaufelberger commented on patch set 1 02/14/26, 18:34

    I'm not sure about the new labels if they fit the wording. I guess you are the right person to ask ;)
  3. Simon Schaufelberger uploaded patch set 2 02/14/26, 18:40

  4. core-ci voted on patch set 1 V -1 02/14/26, 18:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95913

  5. Simon Schaufelberger commented on patch set 2 02/14/26, 18:44

    One thing I found out is that labels that don't have a TCA column definition get fetched from `LLL:EXT:core/Resources/Private/Language/locallang_core.xlf:labels.xxx`
  6. core-ci voted on patch set 2 V -1 02/14/26, 18:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95914

  7. Simon Schaufelberger uploaded patch set 3 V -1 02/14/26, 19:10

  8. Simon Schaufelberger uploaded patch set 4 02/14/26, 19:20

  9. core-ci voted on patch set 4 V +1 02/14/26, 19:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95916

  10. Riccardo De Contardi commented on patch set 4 02/15/26, 09:24

    general.xlf:46

    Just a general question: should this field be selectable in the "Show columns for Page Content" modal of records (list) view?
  1. Simon Schaufelberger commented on patch set 4 02/15/26, 09:30

    general.xlf:46 Reply

    I would say no but I don't know the consequences. Currently it is.
  2. Riccardo De Contardi commented on patch set 4 02/15/26, 09:34

    locallang_core.xlf:244

    Is this just used in the "Show columns for Page Content" modal of records (list) view and then in the table itself? What is the meanding of selecting this column for viewing? It should be just "0" because if the record is deleted I should not see it at all, am I wrong? Or is there a different scenario?
  3. Benni Mack updated the commit message in patch set 5 V +1 04/22/26, 07:14

  4. core-ci voted on patch set 5 V -1 04/22/26, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/100850

  5. Simon Schaufelberger rebased onto patch set 6 V -1 05/09/26, 17:55

  6. core-ci voted on patch set 6 V -1 05/09/26, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101753

  7. Simon Schaufelberger uploaded patch set 7 V -1 05/09/26, 18:10

  8. core-ci voted on patch set 7 V +1 05/09/26, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101756

  9. Garvin Hicking commented on patch set 7 05/10/26, 17:38

    be_users.php:356

    Why use LLL syntax here again?
  10. Simon Schaufelberger commented on patch set 7 05/10/26, 19:04

    be_users.php:356 Reply

    No special reason. Done
  11. Simon Schaufelberger rebased onto patch set 8 V +1 05/10/26, 19:05

  12. Simon Schaufelberger uploaded patch set 9 05/10/26, 19:05

  13. core-ci voted on patch set 9 V +1 05/10/26, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/101787

  14. Georg Ringer uploaded patch set 10 V +1 09/03/26, 13:37

  15. core-ci voted on patch set 10 V +1 09/03/26, 13:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107758

  16. Simon Schaufelberger voted on patch set 10 CR +1 V +1 09/03/26, 14:47

  17. Simon Schaufelberger commented on patch set 10 09/03/26, 14:47

    general.xlf:46 Reply

    Done

    locallang_core.xlf:244 Reply

    Done
  18. Daniel Windloff commented on patch set 10 09/04/26, 07:39

    ColumnSelectorController.php:57

    These values should be fetched based on the TCA table / TcaSchema API as the columns might have different names, like l10n_diffsource instead of l18n_diffsource.
  19. Benni Mack uploaded patch set 11 CR +1 V +1 09/04/26, 08:25

  20. Georg Ringer commented on patch set 11 09/04/26, 08:33

    ColumnSelectorController.php:57 Reply

    Done
  21. Daniel Windloff voted on patch set 11 CR +1 V +1 09/04/26, 08:37

  22. core-ci voted on patch set 11 V +1 09/04/26, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/107824

  23. Benni Mack voted on patch set 11 CR +2 V +2 09/04/26, 08:40

  24. Benni Mack merged patch set 12 09/04/26, 08:40

  25. Simon Schaufelberger commented on patch set 12 09/04/26, 09:29

    Thank you for this very clean solution!