Review main Merged

92853[BUGFIX] Fix extbase argument uploads merging

Torben Hansen CR +2 V +2 Normal +223 −3 updated 02/20/26, 16:38

Commit message

Using array_merge_recursive for uploads in `RequestBuilder`
leads to issues when handling multidimensional arrays in
GET/POST parameters, as numeric keys get renumbered
instead of being replaced.

The correct behavior is to use array_replace_recursive,
which was the original approach removed in #97214 and
incorrectly restored as array_merge_recursive in
change #102283.

This change ensures that uploaded files are properly
merged into request parameters while preserving the
correct array structure, especially for deeply nested
and multidimensional arguments.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Josua Vogel +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Josua Vogel +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 78

  1. Torben Hansen uploaded patch set 1 02/15/26, 18:10

  2. core-ci voted on patch set 1 V +1 02/15/26, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95935

  3. Oliver Klee voted on patch set 1 CR +1 V +1 02/15/26, 18:24

  4. Garvin Hicking commented on patch set 1 CR +1 V +1 02/16/26, 12:36

    These tests finally helped me understand the problem properly. Thanks!! (Not merging yet, because Torben asked for "living" fix-reports and I want to give the chance of feedback getting provided. I will merge this though if no further replies come in until the end of week)
  5. Josua Vogel commented on patch set 1 CR +1 V +1 02/20/26, 16:21

    I was dealing with this exact bug in ext:form today. Thanks for the fix!
  6. Garvin Hicking commented on patch set 1 CR +2 V +2 02/20/26, 16:29

    Will go ahead and merge it because needed for the form multi file upload. Torben saved the day I guess ;)
  7. Garvin Hicking merged patch set 2 02/20/26, 16:29

  8. Josua Vogel commented on patch set 2 02/20/26, 16:38

    Reply

    Absolutely! Now I can get rid of my dirty workaround :D