92854[FEATURE] Introduce custom message in form email finisher
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Sven Liebert +1
-
Verified V +2 Done
- Garvin Hicking +2
- Sven Liebert +1
- core-ci +1 CI
Issues 1
Files 11
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-88470-CustomMessageInFormEmailFinisher.rstnew+40 −0
- typo3/sysext/form/Classes/Domain/Configuration/FormDefinitionConversionService.php+10 −4
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php3+17 −0
- typo3/sysext/form/Configuration/Yaml/Finishers/Confirmation.yaml+2 −0
- typo3/sysext/form/Configuration/Yaml/Finishers/EmailToReceiver.yaml+7 −0
- typo3/sysext/form/Configuration/Yaml/Finishers/EmailToSender.yaml+7 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/Form.yaml+17 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.fluid.html+4 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.fluid.txt+5 −2
- typo3/sysext/form/Resources/Private/Language/Database.xlf+18 −0
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionConversionServiceTest.php+54 −0
Review log 1013
-
Josua Vogel uploaded patch set 1 02/15/26, 18:41
-
core-ci voted on patch set 1 V +1 02/15/26, 19:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95936
-
Josua Vogel uploaded patch set 2
V +102/21/26, 15:08 -
core-ci voted on patch set 2 V +1 02/21/26, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96453
-
Josua Vogel commented on patch set 2 02/21/26, 15:24
In addition this patch contains a bugfix concerning receiving the Rte config for finishers -
Garvin Hicking commented on patch set 2 02/22/26, 00:03
EmailFinisher.php:150This is creative but will fail when people use this placeholder multiple times. I guess throwing an exception for more than once occurence would be fine? Maybe also mention that in the docs and GUI label? -
Josua Vogel commented on patch set 2 02/22/26, 14:18
EmailFinisher.php:150ReplyGood point — I actually considered this during the implementation. From a developer’s perspective, throwing an exception initially felt like the correct approach, since multiple occurrences of the placeholder are not intended or desirable. However, I also tried to look at it from a different angle. Raising an exception would result in an error message being shown to the end customer. In contrast, if a second placeholder is used, it is simply rendered as plain text in the email. Personally, I consider an incorrectly placed second marker to be less critical than blocking the form submission with an error message. We also do not validate spelling or similar content issues — it is ultimately the editor’s responsibility to ensure that the email message is properly written and reviewed before going live. If a template is published without proper checking, having {formValues} appear in the success message is, in my opinion, a reasonable trade-off compared to displaying an error to the end customer. I will improve the situation by extending the notice in the backend. -
Josua Vogel uploaded patch set 3
V +102/22/26, 14:21 -
core-ci voted on patch set 3 V +1 02/22/26, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96507
-
Garvin Hicking commented on patch set 3 CR +1 V +1 02/27/26, 09:29
EmailFinisher.php:150ReplyThanks! This works for me. -
Sven Liebert voted on patch set 3 CR +1 V +1 02/27/26, 11:39
-
Garvin Hicking voted on patch set 3 CR +2 V +2 02/28/26, 08:07
-
Garvin Hicking merged patch set 4 02/28/26, 08:07