92857[TASK] Remove inlined label references from FormEngine
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benjamin Kott +1
- core-ci +1 CI
Issues 1
Files 29
- Build/Sources/TypeScript/backend/form-engine/container/files-control-container.ts+5 −4
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-container-container.ts+3 −2
- Build/Sources/TypeScript/backend/form-engine/container/inline-control-container.ts+7 −5
- Build/Sources/TypeScript/backend/form-engine/container/site-language-container.ts+5 −4
- Build/Sources/TypeScript/backend/context-menu-actions.ts+4 −3
- Build/Sources/TypeScript/backend/drag-uploader.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine-validation.ts+2 −1
- Build/Sources/TypeScript/backend/form-engine.ts4+33 −38
- Build/Sources/TypeScript/backend/grid-editor.ts2+3 −2
- Build/Sources/TypeScript/backend/multi-record-selection-delete-action.ts+2 −1
- Build/Sources/TypeScript/extensionmanager/main.ts+4 −3
- Build/Sources/TypeScript/extensionmanager/repository.ts+3 −2
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+4 −3
- Build/Sources/TypeScript/recycler/recycler.ts+3 −2
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+0 −21
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/files-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-container-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/inline-control-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/site-language-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu-actions.js+1 −1
Show 9 more files
- typo3/sysext/backend/Resources/Public/JavaScript/drag-uploader.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/grid-editor.js+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/multi-record-selection-delete-action.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/main.js+2 −2
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/repository.js+3 −3
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/recycler/Resources/Public/JavaScript/recycler.js+1 −1
Review log 1825
-
Andreas Nedbal uploaded patch set 1 02/16/26, 16:39
-
Andreas Nedbal updated the commit message in patch set 2 02/16/26, 16:40
-
core-ci voted on patch set 1 V -1 02/16/26, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95979
-
Garvin Hicking commented on patch set 2 02/16/26, 16:50
-
core-ci voted on patch set 2 V -1 02/16/26, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95980
-
Andreas Nedbal uploaded patch set 3
V -102/16/26, 17:04 -
Andreas Nedbal commented on patch set 3 02/16/26, 17:07
form-engine.ts:110ReplyI can't, this was how it was called previously and I just replaced the aliases provided by FormEngine (see FormResultCompiler.php). And I can adjust it, I just wanted to keep this patch as "small" as possible only removing the aliasing/label inlining done by FormEngine here though. -
Benjamin Kott commented on patch set 3 02/16/26, 17:12
form-engine.ts:110Replyit´s the actual identifier in the files 🙃 -
core-ci voted on patch set 3 V -1 02/16/26, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95983
-
Garvin Hicking commented on patch set 3 02/16/26, 18:08
form-engine.ts:110ReplyAlright, I see the mess. Probably something for either a followup or pre-patch, but I see this mustn't be scope of this patch, thx. -
Benjamin Franzke commented on patch set 3 02/17/26, 09:25
grid-editor.ts:797This will require a `~labels/*` provider for the JavaScript unit tests. I'll look into providing that. -
Andreas Nedbal uploaded patch set 4
V -102/17/26, 10:07 -
core-ci voted on patch set 4 V -1 02/17/26, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96021
-
Benjamin Franzke rebased onto patch set 5
V -102/17/26, 10:34 -
Benjamin Franzke commented on patch set 5 02/17/26, 10:34
grid-editor.ts:797ReplyPushed a patch and set this one into a relation chain to that one. -
Benjamin Franzke uploaded patch set 6 02/17/26, 10:35
-
core-ci voted on patch set 5 V +1 02/17/26, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96022
-
Benjamin Franzke rebased onto patch set 7 02/17/26, 11:21
-
Benjamin Franzke commented on patch set 7 CR +1 V +1 02/17/26, 11:21
❤️ -
core-ci voted on patch set 6 V +1 02/17/26, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96025
-
core-ci voted on patch set 7 V +1 02/17/26, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96035
-
Benjamin Kott voted on patch set 7 CR +1 V +1 02/17/26, 12:52
-
Benjamin Franzke voted on patch set 7 CR +2 V +2 02/17/26, 12:56
-
Benjamin Franzke merged patch set 8 02/17/26, 12:56
-
Benjamin Franzke wrote 02/17/26, 18:11
Hashtag added: labels
form-engine.ts:110