Review main Merged

92857[TASK] Remove inlined label references from FormEngine

Andreas Nedbal CR +2 V +2 Normal +101 −113 updated 02/17/26, 18:11

Commit message

FormEngine ships a set of label aliases used in JavaScript. These
were shipped as conveneniece to the otherwise longer label references.

With #108941 merged, we can now utilize the same language namespaces
as file imports and thus are not required to have this workaround
for convenience.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 29

Show 9 more files

Review log 1825

  1. Andreas Nedbal uploaded patch set 1 02/16/26, 16:39

  2. Andreas Nedbal updated the commit message in patch set 2 02/16/26, 16:40

  3. core-ci voted on patch set 1 V -1 02/16/26, 16:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95979

  4. Garvin Hicking commented on patch set 2 02/16/26, 16:50

    form-engine.ts:110

    Can you tell me where "mess" comes from, I don't understand it - shouldn't we keep this aligned with a "messages" domain? Sounds messy otherwise. (I don't see this in the prepatch for this either)
  5. core-ci voted on patch set 2 V -1 02/16/26, 16:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95980

  6. Andreas Nedbal uploaded patch set 3 V -1 02/16/26, 17:04

  7. Andreas Nedbal commented on patch set 3 02/16/26, 17:07

    form-engine.ts:110 Reply

    I can't, this was how it was called previously and I just replaced the aliases provided by FormEngine (see FormResultCompiler.php). And I can adjust it, I just wanted to keep this patch as "small" as possible only removing the aliasing/label inlining done by FormEngine here though.
  8. Benjamin Kott commented on patch set 3 02/16/26, 17:12

    form-engine.ts:110 Reply

    it´s the actual identifier in the files 🙃
  9. core-ci voted on patch set 3 V -1 02/16/26, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95983

  10. Garvin Hicking commented on patch set 3 02/16/26, 18:08

    form-engine.ts:110 Reply

    Alright, I see the mess. Probably something for either a followup or pre-patch, but I see this mustn't be scope of this patch, thx.
  11. Benjamin Franzke commented on patch set 3 02/17/26, 09:25

    grid-editor.ts:797

    This will require a `~labels/*` provider for the JavaScript unit tests. I'll look into providing that.
  12. Andreas Nedbal uploaded patch set 4 V -1 02/17/26, 10:07

  13. core-ci voted on patch set 4 V -1 02/17/26, 10:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96021

  14. Benjamin Franzke rebased onto patch set 5 V -1 02/17/26, 10:34

  15. Benjamin Franzke commented on patch set 5 02/17/26, 10:34

    grid-editor.ts:797 Reply

    Pushed a patch and set this one into a relation chain to that one.
  16. Benjamin Franzke uploaded patch set 6 02/17/26, 10:35

  17. core-ci voted on patch set 5 V +1 02/17/26, 11:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96022

  18. Benjamin Franzke rebased onto patch set 7 02/17/26, 11:21

  19. Benjamin Franzke commented on patch set 7 CR +1 V +1 02/17/26, 11:21

    ❤️
  20. core-ci voted on patch set 6 V +1 02/17/26, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96025

  21. core-ci voted on patch set 7 V +1 02/17/26, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96035

  22. Benjamin Kott voted on patch set 7 CR +1 V +1 02/17/26, 12:52

  23. Benjamin Franzke voted on patch set 7 CR +2 V +2 02/17/26, 12:56

  24. Benjamin Franzke merged patch set 8 02/17/26, 12:56

  25. Benjamin Franzke wrote 02/17/26, 18:11

    Hashtag added: labels