Review main Merged

92866[TASK] Use JavaScript label imports in EXT:workspaces

Benjamin Franzke CR +2 V +2 Normal +95 −123 updated 02/20/26, 16:22

Commit message

The workspaces module previously had to inject workspace
labels into custom elements that are rendered in dialogs
inside the top frame, because local workspace labels could
not be loaded globally.

This hack is one of the reasons why #108941 added infrastructure
to load labels as module dependencies.

To streamline the codebase, all label usages in EXT:workspaces
JavaScript modules are streamlined to use this infrastructure.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Andreas Nedbal +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 22

Show 2 more files

Review log 79

  1. Benjamin Franzke uploaded patch set 1 02/17/26, 12:31

  2. core-ci voted on patch set 1 V -1 02/17/26, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96039

  3. Benjamin Franzke uploaded patch set 2 V -1 02/17/26, 13:04

  4. core-ci voted on patch set 2 V +1 02/17/26, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96048

  5. Benjamin Franzke wrote 02/17/26, 18:11

    Hashtag added: labels
  6. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/17/26, 19:31

  7. Andreas Nedbal voted on patch set 2 CR +1 V +1 02/20/26, 15:36

  8. Benjamin Franzke voted on patch set 2 CR +2 V +2 02/20/26, 16:20

  9. Benjamin Franzke merged patch set 3 02/20/26, 16:22