92869[TASK] Use typo3-backend-wizard component in form wizard
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Andreas Nedbal +1
- Josua Vogel +1
-
Verified V +2 Done
- Georg Ringer +2
- Andreas Nedbal +1
- Josua Vogel +1
- core-ci +1 CI
Issues 2
Files 13
- Build/Sources/TypeScript/form/backend/form-manager/view-model.ts5+48 −581
- Build/Sources/TypeScript/form/backend/form-wizard/finisher/create-form-submission-service.ts3new+58 −0
- Build/Sources/TypeScript/form/backend/form-wizard/finisher/duplicate-form-submission-service.tsnew+57 −0
- Build/Sources/TypeScript/form/backend/form-wizard/steps/mode-step.tsnew+135 −0
- Build/Sources/TypeScript/form/backend/form-wizard/steps/settings-step.tsnew+226 −0
- Build/Sources/TypeScript/form/backend/form-wizard/form-wizard.ts2new+133 −0
- typo3/sysext/form/Resources/Private/Language/locallang_formManager_javascript.xlf+9 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-manager/view-model.js+1 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/finisher/create-form-submission-service.jsnew+13 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/finisher/duplicate-form-submission-service.jsnew+13 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/steps/mode-step.jsnew+13 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/steps/settings-step.jsnew+13 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-wizard/form-wizard.jsnew+13 −0
Review log 3454
Show 1729 earlier messages
-
Tobias Wojtylak uploaded patch set 1 02/17/26, 15:01
-
core-ci voted on patch set 1 V -1 02/17/26, 15:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96061
-
Tobias Wojtylak uploaded patch set 2
V -102/17/26, 16:05 -
core-ci voted on patch set 2 V -1 02/17/26, 16:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96064
-
Tobias Wojtylak uploaded patch set 3
V -102/17/26, 16:22 -
Tobias Wojtylak uploaded patch set 4 02/17/26, 16:34
-
core-ci voted on patch set 3 V -1 02/17/26, 16:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96068
-
core-ci voted on patch set 4 V -1 02/17/26, 16:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96070
-
Tobias Wojtylak uploaded patch set 5
V -102/17/26, 16:54 -
core-ci voted on patch set 5 V +1 02/17/26, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96071
-
Anja Leichsenring commented on patch set 5 02/17/26, 19:41
I´d say this is not a task but a feature, same way as in 92577: [FEATURE] Introduce web component-based form editor tree | https://review.typo3.org/c/Packages/TYPO3.CMS/+/92577. So to cite Georg: add a feature.rst and earn your credits ;) A little bit more text in the commit message on what was improved with the migration (again, please refer to the linked patch) would do the work justice and make reviews easier. Thanks for the work you put into the patch. -
Tobias Wojtylak marked it work in progress 02/18/26, 07:51
-
Benjamin Kott commented on patch set 5 02/18/26, 08:21
This change is ready for review.Reply
@aleichsenring@ab-softlab.de this is not a feature, it does not provide any new benefits, it's just aligning code and implementations, we are cleaning up the wizard implementations. -
Benjamin Kott marked it work in progress 02/18/26, 08:21
-
Tobias Wojtylak uploaded patch set 6
V +102/18/26, 09:43 -
Tobias Wojtylak uploaded patch set 7 02/18/26, 09:50
-
core-ci voted on patch set 6 V -1 02/18/26, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96112
-
Tobias Wojtylak marked it ready for review 02/18/26, 09:58
-
core-ci voted on patch set 7 V -1 02/18/26, 10:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96113
-
Tobias Wojtylak rebased onto patch set 8
V -102/18/26, 10:06 -
core-ci voted on patch set 8 V -1 02/18/26, 10:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96116
-
core-ci voted on patch set 8 V +1 02/18/26, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96116
-
Tobias Wojtylak uploaded patch set 9
V +102/18/26, 11:12 -
core-ci voted on patch set 9 V +1 02/18/26, 11:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96122
-
Tobias Wojtylak uploaded patch set 10
V +102/18/26, 11:51 -
Tobias Wojtylak rebased onto patch set 11 02/18/26, 11:56
-
core-ci voted on patch set 11 V +1 02/18/26, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96128
-
core-ci voted on patch set 10 V +1 02/18/26, 12:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96125
-
Tobias Wojtylak uploaded patch set 12
V +102/18/26, 13:33
-
Tobias Wojtylak uploaded patch set 13 02/18/26, 13:40
-
core-ci voted on patch set 12 V -1 02/18/26, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96139
-
Tobias Wojtylak uploaded patch set 14 02/18/26, 13:59
-
Benjamin Kott commented on patch set 14 02/18/26, 14:10
form-wizard.ts:121please use content-form as this is the record icon -
Tobias Wojtylak uploaded patch set 15 02/18/26, 14:18
-
Tobias Wojtylak commented on patch set 15 02/18/26, 14:19
form-wizard.ts:121ReplyDone -
core-ci voted on patch set 14 V +1 02/18/26, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96148
-
core-ci voted on patch set 15 V +1 02/18/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96149
-
Tobias Wojtylak uploaded patch set 16
V +102/19/26, 09:02 -
core-ci voted on patch set 16 V +1 02/19/26, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96221
-
Tobias Wojtylak updated the commit message in patch set 17
V +102/19/26, 14:43 -
core-ci voted on patch set 17 V +1 02/19/26, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96256
-
Tobias Wojtylak uploaded patch set 18
V +102/20/26, 11:16 -
core-ci voted on patch set 18 V +1 02/20/26, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96340
-
Andreas Nedbal commented on patch set 18 CR -1 02/20/26, 16:02
Just some small things I noticed code-wise, functionality works fine!view-model.ts:43While one way to solve this, I don't think that importing and using lit to render a single tag is necessary, just create it by hand: ```suggestion const content = document.createElement('typo3-backend-form-wizard'); content.formManager = formManagerApp; ```view-model.ts:112Also just use `document.createElement` here.create-form-submission-service.ts:37minor nitpick: remove the extra space at the end of the condition -
Tobias Wojtylak commented on patch set 18 02/21/26, 10:33
view-model.ts:43ReplyThis is a not good idea. For one, we would probably have to use `top.document.createElement`. Also I would favor the current implementation because of: - Consistency – It aligns with the existing code style. (see examples below) - Declarative approach https://github.com/TYPO3/typo3/blob/1d7ca8772589add8c6f5166813367c3505070b12/Build/Sources/TypeScript/backend/login-refresh.ts#L201 https://github.com/TYPO3/typo3/blob/1d7ca8772589add8c6f5166813367c3505070b12/Build/Sources/TypeScript/backend/security/element/sudo-mode.ts#L118 https://github.com/TYPO3/typo3/blob/386c30fefa380009c0e8f41dc1b284d76699a7dd/Build/Sources/TypeScript/backend/element/qrcode-modal-button.ts#L56 https://github.com/TYPO3/typo3/blob/1d7ca8772589add8c6f5166813367c3505070b12/Build/Sources/TypeScript/core/authentication/mfa-provider/totp.ts#L32view-model.ts:112ReplyAcknowledgedcreate-form-submission-service.ts:37ReplyAcknowledged -
Tobias Wojtylak uploaded patch set 19
CR -1V +102/21/26, 10:40 -
Tobias Wojtylak commented on patch set 19 02/21/26, 10:40
view-model.ts:43ReplyAcknowledgedcreate-form-submission-service.ts:37Replydone -
core-ci voted on patch set 19 V +1 02/21/26, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96446
-
Tobias Wojtylak uploaded patch set 20
V +102/21/26, 10:58 -
core-ci voted on patch set 20 V +1 02/21/26, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96447
-
Josua Vogel commented on patch set 20 CR +1 V +1 02/21/26, 13:44
Works great — thanks so much for all your hard work! -
Andreas Nedbal voted on patch set 20 CR +1 V +1 02/23/26, 09:30
-
Georg Ringer voted on patch set 20 CR +2 V +2 02/23/26, 09:38
-
Georg Ringer merged patch set 21 02/23/26, 09:38