Review main Merged

92873[TASK] Upgrade `firebase/php-jwt` to 7.0

Andreas Kienast CR +2 V +2 Easy +10 −10 updated 02/19/26, 19:22

Commit message

This commit upgrades the 3rd party component `firebase/php-jwt` to
version 7.0, which also adds key size validation as a security
measure [1].

Executed commands:

    composer req firebase/php-jwt:^7.0.2
    composer req firebase/php-jwt:^7.0.2 -d typo3/sysext/core --no-update

[1] https://github.com/firebase/php-jwt/commit/6b80341b

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Thomas Hohn +1
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Thomas Hohn +1
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Jörg Bösche +1
    • Steffen Frese +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1620

  1. Andreas Kienast uploaded patch set 1 02/18/26, 06:35

  2. Andreas Kienast updated the commit message in patch set 2 02/18/26, 06:36

  3. core-ci voted on patch set 2 V -1 02/18/26, 06:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96098

  4. core-ci voted on patch set 2 V +1 02/18/26, 07:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96098

  5. Anja Leichsenring voted on patch set 2 CR +1 V +1 02/18/26, 07:05

  6. core-ci voted on patch set 1 V +1 02/18/26, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96097

  7. Thomas Hohn voted on patch set 2 CR +1 V +1 02/18/26, 07:25

  8. Benjamin Franzke commented on patch set 2 CR +1 V +1 02/18/26, 07:27

    we could add that we already complied to that security measure, so that we were not "affected". anyway, fine as is…
  9. Oli Bartsch voted on patch set 2 CR +1 V +1 02/18/26, 07:27

  10. Benjamin Franzke commented on patch set 2 02/18/26, 07:28

  11. core-ci commented on patch set 2 02/18/26, 07:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96099

  12. Jörg Bösche voted on patch set 2 CR +1 V +1 02/18/26, 08:51

  13. Andreas Kienast voted on patch set 2 CR +2 V +2 02/18/26, 09:21

  14. Andreas Kienast merged patch set 3 02/18/26, 09:22

  15. Oliver Hader commented on patch set 3 02/18/26, 09:27

    Just a side-note: There were reports of failing key verifications, due to the key-length changes. https://github.com/firebase/php-jwt/issues/618 I did not manage to analyze & test that behavior in particular.
  16. Thomas Hohn commented on patch set 3 02/18/26, 09:31

    Reply

    If you use HS256 the required key-length with version 7 is 32
  17. Oliver Hader commented on patch set 3 02/18/26, 11:22

    Reply

    Thomas, did that change from version 6.x to 7.x create problems on your side? Or was the comment "just FYI"?
  18. Oliver Hader commented on patch set 3 02/18/26, 11:26

    composer.json:55 Unresolved

    I'd suggest to use `^6.10 || ^7.0.2` - otherwise this change would be breaking for projects that still used version 6.x of the package. And in case those projects are affected by the breaking changes in version 7.x, we should not enforce that in our own package.
  19. Thomas Hohn commented on patch set 3 02/18/26, 11:44

    Reply Unresolved

    Actually yes - we have som keys that don't have the proper length - so now we are starting to the kid attribute in our JWT tokens and in the processes of "fixing" it
  20. Steffen Frese voted on patch set 3 CR +1 V +1 02/19/26, 19:22