92878[TASK] Allow `firebase/php-jwt` ^6.10.2||^7.0.2
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Oliver Hader +2
- Benjamin Franzke +1
Issues 1
Files 4
Review log 2434
Show 59 earlier messages
-
Thomas Hohn uploaded patch set 1 02/18/26, 12:30
-
Thomas Hohn updated the commit message in patch set 2 02/18/26, 12:32
-
Thomas Hohn updated the commit message in patch set 3 02/18/26, 12:36
-
core-ci voted on patch set 2 V +1 02/18/26, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96131
-
core-ci voted on patch set 3 V +1 02/18/26, 12:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96133
-
Benjamin Franzke commented on patch set 3 02/18/26, 13:03
Just for reference: This can only lead to problems when the `firebase/php-jwt` is used directly in an extension, since TYPO3 always uses key that are long enough. Upstream discussed this was well, and there is a workaround for applications that *really* need to use insecure keys, and *really* want to keep them (which is of course *NOT* suggested) – please note that TYPO3 itself does not use keys that are to short. https://github.com/firebase/php-jwt/pull/613#issuecomment-3724420360 > `$secret = str_pad($secret, 32, "\0");` Note: I'm not against this change per se, but currently we cannot test against v6 anylonger, since even `composerInstallMin` will install v7 and therefore we do not know if we are compatible with v6. That means: If we *really* want to keep allowing v6, we need to adapt the `composerInstallMin` test to ignore the advisory and ensure that v6 is installed and tested (or want until the invalid advisory is revoked – https://github.com/github/advisory-database/pull/6954) -
core-ci voted on patch set 1 V +1 02/18/26, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96130
-
core-ci voted on patch set 2 V +1 02/18/26, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96135
-
Benjamin Franzke commented on patch set 3 02/18/26, 13:13
Reply
> since TYPO3 always uses key that are long enough Explanation: We create sha256 hash of our encryption key and add a pepper, that means it is >65bytes. The requires key length for HS256 (the only algorithm that we use) is 32: https://github.com/firebase/php-jwt/pull/613/changes#diff-d222ef91955adde55b92542906a8d83265a2e50019c42b812dc76d71c412b4eaR678
-
Thomas Hohn commented on patch set 3 02/18/26, 13:20
Reply
Would composer config -jm audit.ignore '{"CVE-2025-45769":"disputed"}' not fix that issue. My "problem" is that the migrating away from insecure keys could take time at the requirement of ^7 would make it impossible to upgrade the TYPO3 version. My suggestion would be to keep the "patch" until 14 LTS is released - this should give people a fair chance to fix it -
Benjamin Franzke uploaded patch set 4
V +102/18/26, 13:39 -
Benjamin Franzke commented on patch set 4 02/18/26, 13:41
Reply
yup, should work. Let's see: https://git.typo3.org/typo3/CI/cms/-/pipelines/96142 -
core-ci voted on patch set 4 V +1 02/18/26, 14:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96141
-
Thomas Hohn commented on patch set 4 02/18/26, 14:24
Reply
Acknowledged -
core-ci commented on patch set 4 02/18/26, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96142
-
Oliver Hader commented on patch set 4 02/18/26, 14:28
Reply
Looks good: * min tests: `Downgrading firebase/php-jwt (v7.0.2 => v6.10.0)` * max tests: `Installing firebase/php-jwt (v7.0.2)` However, we should us `^6.10.2`, having PHP 8.4 warnings fixed (see https://github.com/firebase/php-jwt/releases/tag/v6.10.2) -
Thomas Hohn uploaded patch set 5
V +102/18/26, 14:40 -
Thomas Hohn updated the commit message in patch set 6 02/18/26, 14:41
-
Benjamin Franzke voted on patch set 6 CR +1 V +1 02/18/26, 14:52
-
Sebastian Iffland commented on patch set 6 CR +1 02/18/26, 15:12
composer normalize suggestions, see commentscomposer.json:74same ```suggestion "firebase/php-jwt": "^6.10.2 || ^7.0.2", ```composer.json:55Shouldn't this be noted normalized (spaces around operator)? ```suggestion "firebase/php-jwt": "^6.10.2 || ^7.0.2", ``` -
core-ci voted on patch set 5 V +1 02/18/26, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96152
-
core-ci voted on patch set 6 V +1 02/18/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96153
-
Thomas Hohn uploaded patch set 7
CR +1V +102/18/26, 15:34 -
Thomas Hohn commented on patch set 7 02/18/26, 15:35
composer.json:74ReplyDonecomposer.json:55ReplyDone -
Sebastian Iffland voted on patch set 7 CR +1 V +1 02/18/26, 15:39
-
core-ci voted on patch set 7 V +1 02/18/26, 16:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96163
-
Benjamin Franzke voted on patch set 7 CR +1 V +1 02/18/26, 16:29
-
Oliver Hader voted on patch set 7 CR +1 V +1 02/18/26, 19:44
-
Oliver Hader updated the commit message in patch set 8
CR +1V +102/18/26, 19:53 -
Oliver Hader voted on patch set 8 CR +1 V +1 02/18/26, 19:58
-
Benjamin Franzke voted on patch set 8 CR +1 V +1 02/18/26, 20:11
-
Oliver Hader voted on patch set 8 CR +2 V +2 02/18/26, 20:12
-
Oliver Hader merged patch set 9 02/18/26, 20:12
-
core-ci voted on patch set 8 V +1 02/18/26, 20:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96187