Review main Merged

92879[TASK] Use JavaScript label imports in FormEngine components

Andreas Nedbal CR +2 V +2 Normal +39 −38 updated 02/19/26, 14:59

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Tobias Wojtylak +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • Tobias Wojtylak +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 1214

  1. Andreas Nedbal uploaded patch set 1 02/18/26, 13:22

  2. Andreas Nedbal wrote 02/18/26, 13:41

    Hashtag added: labels
  3. Benjamin Franzke voted on patch set 1 CR +1 02/18/26, 13:43

  4. Benjamin Franzke commented on patch set 1 CR 0 V -1 02/18/26, 13:47

    char-counter.ts:53

    This results in `Remaining characters: {0}`, since `get()` does not transform `{0}`. You'd need to keep `replace(…)` for now.
  5. Benjamin Franzke commented on patch set 1 02/18/26, 13:49

    char-counter.ts:53 Reply

    So we implemented only %s/%d for now, since that's what we had in `lll()`, of course we'd ideally phase that out and replace with ICU placeholders (soon), but I haven't checked with @benni@typo3.org what the state is regarding that, or if that's not planned at all.
  6. core-ci voted on patch set 1 V +1 02/18/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96138

  7. Andreas Nedbal uploaded patch set 2 V +1 02/19/26, 11:17

  8. Andreas Nedbal commented on patch set 2 02/19/26, 11:18

    char-counter.ts:53 Reply

    Done (reverted to using `replace`)
  9. core-ci voted on patch set 2 V +1 02/19/26, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96236

  10. Tobias Wojtylak voted on patch set 2 CR +1 02/19/26, 12:09

  11. Benjamin Franzke voted on patch set 2 CR +1 V +1 02/19/26, 12:45

  12. Tobias Wojtylak voted on patch set 2 V +1 02/19/26, 14:50

  13. Benjamin Kott voted on patch set 2 CR +2 V +2 02/19/26, 14:59

  14. Benjamin Kott merged patch set 3 02/19/26, 14:59