92879[TASK] Use JavaScript label imports in FormEngine components
Commit message
Review
-
Code review CR +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Tobias Wojtylak +1
-
Verified V +2 Done
- Benjamin Kott +2
- Benjamin Franzke +1
- Tobias Wojtylak +1
- core-ci +1 CI
Issues 1
Files 10
- Build/Sources/TypeScript/backend/form-engine/container/flex-form-container-container.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine/element/extra/char-counter.ts3+2 −2
- Build/Sources/TypeScript/backend/form-engine/element/suggest/result-container.ts+2 −2
- Build/Sources/TypeScript/backend/form-engine/element/select-tree-toolbar.ts+5 −5
- Build/Sources/TypeScript/backend/form-engine/element/table-wizard-element.ts+22 −21
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/container/flex-form-container-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/extra/char-counter.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/suggest/result-container.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-tree-toolbar.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/table-wizard-element.js+2 −2
Review log 1214
-
Andreas Nedbal uploaded patch set 1 02/18/26, 13:22
-
Andreas Nedbal wrote 02/18/26, 13:41
Hashtag added: labels -
Benjamin Franzke voted on patch set 1 CR +1 02/18/26, 13:43
-
Benjamin Franzke commented on patch set 1 CR 0 V -1 02/18/26, 13:47
char-counter.ts:53This results in `Remaining characters: {0}`, since `get()` does not transform `{0}`. You'd need to keep `replace(…)` for now. -
Benjamin Franzke commented on patch set 1 02/18/26, 13:49
char-counter.ts:53ReplySo we implemented only %s/%d for now, since that's what we had in `lll()`, of course we'd ideally phase that out and replace with ICU placeholders (soon), but I haven't checked with @benni@typo3.org what the state is regarding that, or if that's not planned at all. -
core-ci voted on patch set 1 V +1 02/18/26, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96138
-
Andreas Nedbal uploaded patch set 2
V +102/19/26, 11:17 -
Andreas Nedbal commented on patch set 2 02/19/26, 11:18
char-counter.ts:53ReplyDone (reverted to using `replace`) -
core-ci voted on patch set 2 V +1 02/19/26, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96236
-
Tobias Wojtylak voted on patch set 2 CR +1 02/19/26, 12:09
-
Benjamin Franzke voted on patch set 2 CR +1 V +1 02/19/26, 12:45
-
Tobias Wojtylak voted on patch set 2 V +1 02/19/26, 14:50
-
Benjamin Kott voted on patch set 2 CR +2 V +2 02/19/26, 14:59
-
Benjamin Kott merged patch set 3 02/19/26, 14:59