92882[TASK] Resolve most frontend-related phpstan issues
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Garvin Hicking +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Garvin Hicking +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 50
- Build/phpstan/phpstan-baseline.neon+3 −357
- typo3/sysext/adminpanel/Classes/Modules/PreviewModule.php+1 −3
- typo3/sysext/fluid/Classes/ViewHelpers/Be/PageRendererViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Format/BytesViewHelper.php+1 −2
- typo3/sysext/fluid/Classes/ViewHelpers/Link/TypolinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/Uri/TypolinkViewHelper.php+1 −1
- typo3/sysext/fluid/Classes/ViewHelpers/ImageViewHelper.php+1 −4
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/SvgImageViewHelperTest.php+14 −17
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/ClosureFinisher.php+0 −1
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php+7 −2
- typo3/sysext/form/Classes/Domain/Model/FormElements/UnknownFormElement.php+2 −2
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+1 −3
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+12 −16
- typo3/sysext/form/Classes/EventListener/ProcessFileListActionsEventListener.php+2 −1
- typo3/sysext/form/Classes/EventListener/ValidateAdvancedPasswordRenderable.php+4 −0
- typo3/sysext/form/Classes/Mvc/Property/Exception/TypeConverterException.php+2 −5
- typo3/sysext/form/Classes/Mvc/Validation/DateRangeValidator.php+1 −1
- typo3/sysext/form/Classes/Mvc/Validation/FileSizeValidator.php+1 −1
Show 30 more files
- typo3/sysext/form/Classes/Mvc/Validation/MimeTypeValidator.php+1 −1
- typo3/sysext/form/Classes/ViewHelpers/GridColumnClassAutoConfigurationViewHelper.php+0 −3
- typo3/sysext/form/Classes/ViewHelpers/RenderFormValueViewHelper.php+1 −1
- typo3/sysext/form/Tests/Functional/Framework/FormHandling/FormDataFactory.php+2 −1
- typo3/sysext/frontend/Classes/ContentObject/Menu/CategoryMenuUtility.php+2 −6
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+21 −36
- typo3/sysext/frontend/Classes/ContentObject/RecordsContentObject.php+6 −5
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php+9 −15
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+6 −8
- typo3/sysext/frontend/Classes/Resource/FilePathSanitizer.php+1 −3
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/ApplicableConjunction.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/AspectDeclaration.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/Builder.php+2 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/EnhancerDeclaration.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/ExceptionExpectation.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/LanguageContext.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/PageTypeDeclaration.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/Permutation.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/TestSet.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/Variable.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/VariableCompiler.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/VariableItem.php+2 −2
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/Variables.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/VariablesContext.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Framework/Builder/VariableValue.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SiteRequestTest.php+3 −3
- typo3/sysext/frontend/Tests/Functional/SiteHandling/SlugLinkGeneratorTest.php+1 −1
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+0 −4
- typo3/sysext/install/Classes/Configuration/AbstractFeature.php+0 −1
Review log 1014
-
Benni Mack uploaded patch set 1 02/18/26, 14:35
-
core-ci voted on patch set 1 V -1 02/18/26, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96150
-
Benni Mack uploaded patch set 2
V -102/18/26, 16:06 -
Benni Mack marked it ready for review 02/18/26, 16:07
-
core-ci voted on patch set 2 V +1 02/18/26, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96168
-
Benni Mack uploaded patch set 3
V +102/18/26, 16:21 -
Benni Mack uploaded patch set 4 02/18/26, 16:27
-
core-ci voted on patch set 4 V +1 02/18/26, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96174
-
core-ci voted on patch set 3 V +1 02/18/26, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96171
-
Garvin Hicking voted on patch set 4 CR +1 V +1 02/18/26, 17:16
-
Stefan Bürk voted on patch set 4 CR +1 V +1 02/18/26, 17:18
-
Oliver Klee voted on patch set 4 CR +1 V +1 02/18/26, 17:32
-
Benni Mack voted on patch set 4 CR +2 V +2 02/18/26, 17:33
-
Benni Mack merged patch set 5 02/18/26, 17:33