Review main Merged

92882[TASK] Resolve most frontend-related phpstan issues

Benni Mack CR +2 V +2 Hard +130 −527 updated 02/18/26, 17:33

Commit message

Most of the changes here are related to typehints
for PHP methods in stdWrap/cObj related code where
an array is expected, but can't be safely determined
so the typehint is changed to mixed.

Some other areas which have been optimized already,
as well as in test classes, related around EXT:frontend,
EXT:fluid, EXT:form and and EXT:adminpanel.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Garvin Hicking +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 50

Show 30 more files

Review log 1014

  1. Benni Mack uploaded patch set 1 02/18/26, 14:35

  2. core-ci voted on patch set 1 V -1 02/18/26, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96150

  3. Benni Mack uploaded patch set 2 V -1 02/18/26, 16:06

  4. Benni Mack marked it ready for review 02/18/26, 16:07

  5. core-ci voted on patch set 2 V +1 02/18/26, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96168

  6. Benni Mack uploaded patch set 3 V +1 02/18/26, 16:21

  7. Benni Mack uploaded patch set 4 02/18/26, 16:27

  8. core-ci voted on patch set 4 V +1 02/18/26, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96174

  9. core-ci voted on patch set 3 V +1 02/18/26, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96171

  10. Garvin Hicking voted on patch set 4 CR +1 V +1 02/18/26, 17:16

  11. Stefan Bürk voted on patch set 4 CR +1 V +1 02/18/26, 17:18

  12. Oliver Klee voted on patch set 4 CR +1 V +1 02/18/26, 17:32

  13. Benni Mack voted on patch set 4 CR +2 V +2 02/18/26, 17:33

  14. Benni Mack merged patch set 5 02/18/26, 17:33