Review main Merged

92885[TASK] Use JavaScript label imports in EXT:filelist

Andreas Nedbal CR +2 V +2 Normal +66 −59 updated 02/19/26, 17:40

Commit message

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Tobias Wojtylak +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Tobias Wojtylak +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1217

  1. Andreas Nedbal uploaded patch set 1 02/18/26, 15:17

  2. Andreas Nedbal wrote 02/18/26, 15:17

    Hashtag added: labels
  3. Andreas Nedbal updated the commit message in patch set 2 02/18/26, 15:17

  4. core-ci voted on patch set 1 V -1 02/18/26, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96157

  5. core-ci voted on patch set 2 V -1 02/18/26, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96158

  6. Andreas Nedbal uploaded patch set 3 V -1 02/19/26, 12:31

  7. core-ci voted on patch set 3 V +1 02/19/26, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96241

  8. Benjamin Franzke voted on patch set 3 CR +1 V +1 02/19/26, 12:49

  9. Tobias Wojtylak voted on patch set 3 CR +1 02/19/26, 13:08

  10. Tobias Wojtylak commented on patch set 3 V +1 02/19/26, 14:25

    file-delete.ts:47

    This is a little bit dangerous because: - The key is constructed dynamically using string concatenation. - labels.get will throw an error if the key doesn’t exist. This means that if `deleteType` ever has an value not `delete_file` or `delete_folder` the user wont see anything but an error in the console
  11. Andreas Nedbal uploaded patch set 4 CR +1 V +1 02/19/26, 14:53

  12. Andreas Nedbal commented on patch set 4 02/19/26, 14:53

    file-delete.ts:47 Reply

    Done
  13. Tobias Wojtylak voted on patch set 4 CR +1 V +1 02/19/26, 15:01

  14. core-ci voted on patch set 4 V -1 02/19/26, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96257

  15. core-ci voted on patch set 4 V +1 02/19/26, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96257

  16. Benjamin Franzke voted on patch set 4 CR +2 V +2 02/19/26, 17:40

  17. Benjamin Franzke merged patch set 5 02/19/26, 17:40