92885[TASK] Use JavaScript label imports in EXT:filelist
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Tobias Wojtylak +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Tobias Wojtylak +1
- core-ci +1 CI
Issues 1
Files 14
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+10 −10
- Build/Sources/TypeScript/filelist/file-delete.ts2+3 −2
- Build/Sources/TypeScript/filelist/file-list-rename-handler.ts+6 −5
- Build/Sources/TypeScript/filelist/file-list-replace-handler.ts+13 −10
- Build/Sources/TypeScript/filelist/file-list-transfer-handler.ts+8 −7
- Build/Sources/TypeScript/filelist/file-list.ts+13 −12
- Build/Sources/TypeScript/filelist/rename-file.ts+6 −6
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-delete.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-rename-handler.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-replace-handler.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list-transfer-handler.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/file-list.js+1 −1
- typo3/sysext/filelist/Resources/Public/JavaScript/rename-file.js+1 −1
Review log 1217
-
Andreas Nedbal uploaded patch set 1 02/18/26, 15:17
-
Andreas Nedbal wrote 02/18/26, 15:17
Hashtag added: labels -
Andreas Nedbal updated the commit message in patch set 2 02/18/26, 15:17
-
core-ci voted on patch set 1 V -1 02/18/26, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96157
-
core-ci voted on patch set 2 V -1 02/18/26, 15:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96158
-
Andreas Nedbal uploaded patch set 3
V -102/19/26, 12:31 -
core-ci voted on patch set 3 V +1 02/19/26, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96241
-
Benjamin Franzke voted on patch set 3 CR +1 V +1 02/19/26, 12:49
-
Tobias Wojtylak voted on patch set 3 CR +1 02/19/26, 13:08
-
Tobias Wojtylak commented on patch set 3 V +1 02/19/26, 14:25
file-delete.ts:47This is a little bit dangerous because: - The key is constructed dynamically using string concatenation. - labels.get will throw an error if the key doesn’t exist. This means that if `deleteType` ever has an value not `delete_file` or `delete_folder` the user wont see anything but an error in the console -
Andreas Nedbal uploaded patch set 4
CR +1V +102/19/26, 14:53 -
Andreas Nedbal commented on patch set 4 02/19/26, 14:53
file-delete.ts:47ReplyDone -
Tobias Wojtylak voted on patch set 4 CR +1 V +1 02/19/26, 15:01
-
core-ci voted on patch set 4 V -1 02/19/26, 15:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96257
-
core-ci voted on patch set 4 V +1 02/19/26, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96257
-
Benjamin Franzke voted on patch set 4 CR +2 V +2 02/19/26, 17:40
-
Benjamin Franzke merged patch set 5 02/19/26, 17:40