92890[TASK] Remove phpstan warnings in backend-related code
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Garvin Hicking +2
- Oliver Klee +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 39
- Build/phpstan/phpstan-baseline.neon+6 −252
- Build/tests/playwright/e2e/media/file-clipboard.spec.ts+1 −1
- typo3/sysext/backend/Classes/Backend/ToolbarItems/SystemInformationToolbarItem.php+2 −10
- typo3/sysext/backend/Classes/Command/DebugBackendRoutesCommand.php+0 −2
- typo3/sysext/backend/Classes/Controller/File/FileController.php+0 −1
- typo3/sysext/backend/Classes/Form/Behavior/OnFieldChangeTrait.php+3 −4
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/SingleFieldContainer.php4+3 −3
- typo3/sysext/backend/Classes/Form/Element/BackendLayoutWizardElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/ColorElement.php+1 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataGroup/OnTheFly.php+0 −1
- typo3/sysext/backend/Classes/Form/FormDataGroup/OrderedProviderList.php+0 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+4 −4
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+1 −1
- typo3/sysext/backend/Classes/Form/Utility/FormEngineUtility.php+1 −1
- typo3/sysext/backend/Classes/Form/Wizard/SuggestWizardDefaultReceiver.php+4 −7
- typo3/sysext/backend/Classes/Form/FormDataGroupInterface.php+1 −1
- typo3/sysext/backend/Classes/LinkHandler/PageLinkHandler.php+1 −1
- typo3/sysext/backend/Classes/LinkHandler/RecordLinkHandler.php+1 −1
Show 19 more files
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+1 −4
- typo3/sysext/backend/Classes/Routing/Router.php+1 −3
- typo3/sysext/backend/Classes/Security/SudoMode/PasswordVerification.php+2 −5
- typo3/sysext/backend/Classes/Security/CategoryPermissionsAspect.php+5 −8
- typo3/sysext/backend/Classes/Tree/Renderer/UnorderedListTreeRenderer.php2+5 −2
- typo3/sysext/backend/Classes/Tree/View/AbstractContentPagePositionMap.php+6 −8
- typo3/sysext/backend/Classes/Tree/TreeNodeCollection.php+6 −13
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+50 −57
- typo3/sysext/core/Classes/Authentication/IpLocker.php+2 −6
- typo3/sysext/core/Classes/LinkHandling/LinkService.php+0 −3
- typo3/sysext/core/Classes/Resource/Search/FileSearchDemand.php+12 −36
- typo3/sysext/core/Classes/Session/UserSessionManager.php+1 −18
- typo3/sysext/core/Classes/Upgrades/AbstractListTypeToCTypeUpdate.php2+1 −1
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/InvalidCustomCTypeMigrationEmptyArrayValue.php+0 −1
- typo3/sysext/filelist/Classes/Controller/FileListController.php+4 −4
- typo3/sysext/filelist/Classes/FileList.php+2 −5
- typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php+1 −1
- typo3/sysext/lowlevel/Classes/Controller/QuerySearchController.php+2 −2
- typo3/sysext/reactions/Classes/Http/Middleware/ReactionResolver.php+0 −1
Review log 1318
-
Benni Mack uploaded patch set 1 02/18/26, 20:07
-
core-ci voted on patch set 1 V -1 02/18/26, 20:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96189
-
Benni Mack uploaded patch set 2
V -102/19/26, 09:48 -
core-ci voted on patch set 2 V -1 02/19/26, 09:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96224
-
Benni Mack uploaded patch set 3
V -102/19/26, 10:12 -
core-ci voted on patch set 3 V +1 02/19/26, 10:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96226
-
Benni Mack uploaded patch set 4
V +102/19/26, 10:34 -
Benni Mack commented on patch set 5 02/19/26, 10:48
Published edit on patch set 4. -
core-ci voted on patch set 4 V -1 02/19/26, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96231
-
core-ci voted on patch set 5 V +1 02/19/26, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96233
-
Anja Leichsenring voted on patch set 5 CR +1 V +1 02/19/26, 10:58
-
Oliver Klee voted on patch set 5 V +1 02/19/26, 11:09
-
Garvin Hicking commented on patch set 5 02/19/26, 11:12
SingleFieldContainer.php:157```suggestion if (($this->data['inlineStructure']['stable'] ?? []) !== []) { ``` Let's try to avoid introducing new empty() usages? (this suggestion is untested)UnorderedListTreeRenderer.php:62```suggestion // @todo: this doc block is a hack, as it needs to be a TreeRepresentationNode ```AbstractListTypeToCTypeUpdate.php:58Unsure about this one, IMO 'string' is what we want here, and the test for that shouldn't make us be more lax on this just to not annotate a test... -
Oliver Klee voted on patch set 5 CR +1 02/19/26, 11:13
-
Benni Mack commented on patch set 5 02/19/26, 11:59
SingleFieldContainer.php:157ReplyDoneUnorderedListTreeRenderer.php:62ReplyDoneAbstractListTypeToCTypeUpdate.php:58Replynope. it was about a "is_string()". And this is the main problem for me with these type-hints. It's a hint, we still need to check the code (which we do in this case, with is_string()"). I will propose to the mergers to disable "treatPhpDocTypesAsCertain: false" to avoid this in the future. -
Benni Mack commented on patch set 5 02/19/26, 12:01
SingleFieldContainer.php:157Replysorry, not done. -
Garvin Hicking commented on patch set 5 CR +2 V +2 02/19/26, 12:16
SingleFieldContainer.php:157ReplyAcknowledged -
Garvin Hicking merged patch set 6 02/19/26, 12:16