Review main Merged

92892[TASK] Provide resolver delegates to Fluid via DI

Simon Praetorius CR +2 V +2 Normal +64 −47 updated 02/26/26, 16:40

Commit message

Fluid's `ViewHelperResolverDelegate` objects, which are the basis
for component collections, have been capable of dependency injection
from the start. However, they were still fetched on-demand via the
`$container` object in `ViewHelperResolver`, which isn't best practice
and complicates the resolver code.

This change utilizes the existing tags in DI to provide the delegate
objects directly to the `ViewHelperResolver`. They are merged in
advance with the recently introduced `DeclarativeComponentCollection`
objects, which are based on the same Fluid interfaces. A positive
side effect is that less services need to be public now.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Oli Bartsch +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Oli Bartsch +1
    • Matthias Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1216

  1. Simon Praetorius uploaded patch set 1 02/18/26, 23:40

  2. core-ci voted on patch set 1 V -1 02/18/26, 23:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96199

  3. Simon Praetorius uploaded patch set 2 V -1 02/18/26, 23:53

  4. core-ci voted on patch set 2 V -1 02/19/26, 00:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96201

  5. Simon Praetorius uploaded patch set 3 V -1 02/20/26, 15:03

  6. Simon Praetorius marked it ready for review 02/20/26, 15:03

  7. core-ci voted on patch set 3 V +1 02/20/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96365

  8. Matthias Vogel voted on patch set 3 CR +1 V +1 02/21/26, 09:13

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 02/26/26, 14:00

  10. Simon Praetorius rebased onto patch set 4 CR +1 V +1 02/26/26, 14:14

  11. Simon Schaufelberger voted on patch set 4 CR +1 V +1 02/26/26, 14:22

  12. core-ci voted on patch set 4 V +1 02/26/26, 14:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96926

  13. Matthias Vogel voted on patch set 4 CR +1 V +1 02/26/26, 14:30

  14. Oli Bartsch voted on patch set 4 CR +1 V +1 02/26/26, 16:36

  15. Simon Praetorius voted on patch set 4 CR +2 V +2 02/26/26, 16:40

  16. Simon Praetorius merged patch set 5 02/26/26, 16:40